Re: Review Request 52488: GEODE-420: fix Pulse test when not using any SSLConfig

2016-10-03 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52488/#review151256 --- Ship it! Ship It! - Jared Stewart On Oct. 3, 2016, 11:20 p.m

Re: Review Request 52488: GEODE-420: fix Pulse test when not using any SSLConfig

2016-10-03 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52488/#review151255 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 3, 2016, 11:20 p.m

Re: Review Request 52488: GEODE-420: fix Pulse test when not using any SSLConfig

2016-10-03 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52488/ --- (Updated Oct. 3, 2016, 11:20 p.m.) Review request for geode, Jared Stewart, Kev

Re: Review Request 52488: GEODE-420: fix Pulse test when not using any SSLConfig

2016-10-03 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52488/ --- (Updated Oct. 3, 2016, 11:18 p.m.) Review request for geode, Jared Stewart, Kev

Re: Review Request 52488: GEODE-420: fix Pulse test when not using any SSLConfig

2016-10-03 Thread Jinmei Liao
> On Oct. 3, 2016, 6:54 p.m., Udo Kohlmeyer wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/JettyHelper.java, > > line 200 > > > > > > I don't think you should pass null. The SSLConfiguratio

Re: Review Request 52488: GEODE-420: fix Pulse test when not using any SSLConfig

2016-10-03 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52488/#review151207 --- geode-core/src/main/java/org/apache/geode/management/internal/Jet

Re: Review Request 52488: GEODE-420: fix Pulse test when not using any SSLConfig

2016-10-03 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52488/#review151196 --- Ship it! Ship It! - Jared Stewart On Oct. 3, 2016, 5:52 p.m.

Review Request 52488: GEODE-420: fix Pulse test when not using any SSLConfig

2016-10-03 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52488/ --- Review request for geode, Jared Stewart, Kevin Duling, Kirk Lund, and Udo Kohlme