Re: Where should geode example code live

+1 On 11/11/16 9:13 am, Jacob Barrett wrote: +1 On Thu, Nov 10, 2016 at 11:22 AM Swapnil Bawaskar wrote: +1 On Thu, Nov 10, 2016 at 11:12 AM, Kirk Lund wrote: Yep! Replace "gemfire" with "geode" On Thu, Nov 10, 2016 at 11:07 AM, Kevin Duling wrote: +1 Shouldn't that be org.apache.g

Re: Review Request 53557: GEODE-2080 Rest POST put call not working with region valueConstrain

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53557/#review155654 --- Ship it! Ship It! - Udo Kohlmeyer On Nov. 7, 2016, 10:13

Re: Review Request 53652: GEODE-2089 entry-idle-time setting on the client side cache is not working as expected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53652/#review155653 --- Ship it! Ship It! - Udo Kohlmeyer On Nov. 10, 2016, 9:47

Re: Review Request 53652: GEODE-2089 entry-idle-time setting on the client side cache is not working as expected

ide the normal behaviour from AbstractRegionEntry. - Udo Kohlmeyer On Nov. 10, 2016, 4:47 p.m., Bruce Schuchardt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Spring Data Geode 1.0.0-INCUBATING-RELEASE available!

Nice one John!! I look forward to seeing the Spring Security integration as well. --Udo On 11/11/16 5:15 am, John Blum wrote: I am happy to announce the release of /Spring Data/ for /Apache Geode/1.0.0-incubating, which marks the first, official GA release of /Apache Geode/ as well as the fi

Re: Review Request 53557: GEODE-2080 Rest POST put call not working with region valueConstrain

/LocalRegion.java (lines 3269 - 3284) <https://reviews.apache.org/r/53557/#comment225104> Maybe this is better suited on the PDXInstance. Maybe a method like "isTypeOf(Class). Then at least we don't spread the PDX logic everywhere in the code. - Udo Kohlmeyer On Nov. 7, 2016, 1

Re: more spotless problems on Windows

09 PM, Udo Kohlmeyer wrote: I think we seriously have to look at using .gitattributes for this... As I initially said, it should be a no brainer.. it should just automatically just work. --Udo On 4/11/16 9:00 am, Bruce Schuchardt wrote: It's been working on my Windows 7 machine under a cy

Re: more spotless problems on Windows

I think we seriously have to look at using .gitattributes for this... As I initially said, it should be a no brainer.. it should just automatically just work. --Udo On 4/11/16 9:00 am, Bruce Schuchardt wrote: It's been working on my Windows 7 machine under a cygwin shell. I just ran it ag

Review Request 53409: GEODE-2017: Removal of nonSingleHopsCount stat in client

Thanks, Udo Kohlmeyer

Re: Review Request 53388: GEODE-2059 client SSL handshake attempts do not time out

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53388/#review154616 --- Ship it! Ship It! - Udo Kohlmeyer On Nov. 2, 2016, 4:57 p.m

Re: jmh benchmarks

+2 On 3/11/16 5:17 am, Dan Smith wrote: Hi all, I'd like to add some support for running benchmarks with jmh to geode. Is this something we're interested in having? JMH is a framework for easily writing microbenchmarks. It's probably not that useful for large scale multiple member benchmarks,

Re: Tweaking the IntelliJ and Eclipse formatters

1) 0 2) +1 3) +1 4) 0 On 27/10/16 3:11 pm, Kirk Lund wrote: I'd like to propose making a few changes to our IntelliJ and Eclipse formatters as well as the Eclipse importorder (all in etc/): 1) increase max line length (100 is way too short) 2) make (hopefully minor) changes to make the two form

Re: Code Formatting in develop

Kevin, Could you please get latest dev. Barry has fixed. --Udo On 27/10/16 10:41 am, Kevin Duling wrote: I just submitted a PR to geode that Travis CI rejected because of code formatting in classes I had not modified. Prior to my commit, I'd merged in the latest develop branch this morning,

Re: Review Request 53199: GEODE-2000 ClientMemberShipListener at client should see server-bind-address in event memberId

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53199/#review153926 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 26, 2016, 6:30

Re: Review Request 53150: GEODE-2024 Deadlock creating a new distributed lock service Grantor while transactions are in progress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53150/#review153925 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 25, 2016, 4:13

Re: [DISCUSS] Graduation

+1 On 25/10/16 5:43 pm, Joey McAllister wrote: +1 On Tue, Oct 25, 2016 at 5:42 PM Anthony Baker wrote: +1 On Oct 25, 2016, at 5:25 PM, Roman Shaposhnik wrote: Unless somebody objects strongly to my #2 and #3 proposals I'm going to kick of this thread on private@.

Re: Coding practices/standards

rmatter is applied? Thanks, --Mark On Fri, Oct 21, 2016 at 9:03 AM, Kenneth Howe wrote: +1 On Oct 21, 2016, at 8:27 AM, Bruce Schuchardt < bschucha...@pivotal.io> wrote: +1 Le 10/20/2016 à 5:13 PM, Udo Kohlmeyer a écrit : +1 On 20/10/16 4:56 pm, Mark Bretl wrote: +1 as well...

Re: Coding practices/standards

Schuchardt < bschucha...@pivotal.io> wrote: +1 Le 10/20/2016 à 5:13 PM, Udo Kohlmeyer a écrit : +1 On 20/10/16 4:56 pm, Mark Bretl wrote: +1 as well... - Pulled changes - Executed './gradlew clean build' and was successful. - Modified a couple of random files to test - Ran '

Re: C++ Coding Standards

+1 - I'm not a C++ dev but I'm all for consistency. On 21/10/16 8:43 am, Jacob Barrett wrote: Considering the team just formally adopted some standards and enforcement for the Java sources I would like to open the discussion for formally adopting similar standards for the C++ sources. I propos

Re: Coding practices/standards

capable machine? Ken On Oct 12, 2016, at 3:39 PM, Jared Stewart < jstew...@pivotal.io> wrote: If you want to try it out, I pushed a branch to my Geode repo that contains this change: https://github.com/jaredjstewart/incubator-geode/ tree/spotlessPlugin < https://github.com/jared

Re: Removal of nonSingleHopCount stat from client

hat people generally have stats turned off in clients anyway. Le 10/19/2016 à 12:55 PM, Udo Kohlmeyer a écrit : Hi there Guys, I've created https://issues.apache.org/jira/browse/GEODE-2017 to track the removal of the nonSingleHopCount stat from the client, as it is potentially a r

Re: Review Request 53034: GEODE-1927 backward compatibility support

new category, then awesome! - Udo Kohlmeyer On Oct. 19, 2016, 9:16 p.m., Bruce Schuchardt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Removal of nonSingleHopCount stat from client

Hi there Guys, I've created https://issues.apache.org/jira/browse/GEODE-2017 to track the removal of the nonSingleHopCount stat from the client, as it is potentially a redundant stat. From the implementation it only increments on "singleHop" enabled pools when an operation requires more than

Review Request 52933: GEODE-1874: setNextNeighbor method allocates a HashSet on every p2p message received

ache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java aafb498 Diff: https://reviews.apache.org/r/52933/diff/ Testing --- precheckin - Done comms regression - in progress Thanks, Udo Kohlmeyer

Re: GEODE-1466: geode.properties

If such a change is to be introduced.. maybe we call it `SYSTEM_PREFIX` or something more generic that we could use within the Geode. Then we could hopefully cover many to most `gemfire` vs `geode` renaming. But I agree with @Anthony, if we aren't 100% certain about a change then we should hol

Re: Review Request 52836: GEODE-2000 ClientMemberShipListener at client should return hostname on which cacheserver is listening(i.e. server-bind-address)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52836/#review152567 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 13, 2016, 4:26

Re: Coding practices/standards

+1 - adding checkstyle to precheckin. If the developer uses the provided templates ( eclipse + intellij) then most of the formatting issues should be handled before precheckin. Also, if a developer has a questionable coding style, that should lessen as that developer will have resolve the issu

Re: Deprecate DynamicRegionFactory

+1 - I see no real benefit for this. On 12/10/16 1:10 pm, William Markito wrote: +1 - We always discouraged people using dynamic regions On Tue, Oct 11, 2016 at 4:33 PM, Dan Smith wrote: I'd like to reopen the discussion about deprecating DynamicRegionFactory. This is some old crufty code

Re: Review Request 52725: GEODE-1801: Amended Logic to increment nonSingleHopsCount

/src/test/java/org/apache/geode/internal/cache/SingleHopStatsDUnitTest.java a7c7b48 Diff: https://reviews.apache.org/r/52725/diff/ Testing --- Pre-checkin started Thanks, Udo Kohlmeyer

Review Request 52725: GEODE-1801: Amended Logic to increment nonSingleHopsCount

://reviews.apache.org/r/52725/diff/ Testing --- Pre-checkin started Thanks, Udo Kohlmeyer

Re: Review Request 52641: GEODE-1914 removed old versions of dtds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52641/#review152094 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 7, 2016, 7:13 p.m

Re: backward compatibility testing against GemFire 8.x WAN/clients

I believe that a backwards compatibility framework is required. Even if just to confirm the compatibility between supported Geode versions. If this framework were to be used/extended by any user of the Geode ecosystem, then it becomes their responsibility to maintain that extension. --Udo O

Re: Review Request 52524: GEODE-1927 backward compatibility support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52524/#review151587 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 4, 2016, 7:36 p.m

Re: Review Request 52271: GEODE-1938: Big Snapshot File Read Exception via SnapshotReader API

the servers even if it were to fail. - Udo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52271/#review151544 ------- On O

Re: Review Request 52271: GEODE-1938: Big Snapshot File Read Exception via SnapshotReader API

kin - Done regression - snapshot/snapshot.bt - Done Thanks, Udo Kohlmeyer

Re: CI bugs

+1 On 5/10/2016 6:28 AM, Nabarun Nag wrote: Hi, I removed the flaky tags from the test in the WAN module. I went through the commits and made sure they had indeed removed the pauses. Please do let me know if I have missed something. Or if these these tickets should still be marked flaky. Par

Re: Review Request 52488: GEODE-420: fix Pulse test when not using any SSLConfig

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52488/#review151255 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 3, 2016, 11:20

Re: Review Request 52488: GEODE-420: fix Pulse test when not using any SSLConfig

Factory.getSSLConfigForComponent(SecurableCommunicationChannel.WEB)); - Udo Kohlmeyer On Oct. 3, 2016, 5:52 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 52271: GEODE-1938: Big Snapshot File Read Exception via SnapshotReader API

rnal/cache/snapshot/TestObject.java PRE-CREATION Diff: https://reviews.apache.org/r/52271/diff/ Testing (updated) --- precheckin - Done regression - snapshot/snapshot.bt - Done Thanks, Udo Kohlmeyer

Re: Review Request 52172: GEODE-1927: add support for old GemFire remote sites (WAN)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52172/#review150770 --- Ship it! Ship It! - Udo Kohlmeyer On Sept. 28, 2016, 4:08

Review Request 52363: GEODE-1947: Renaming SSL_HTTP_SERVICE_REQUIRE_AUTHENTICATION to SSL_WEB_SERVICE_REQUIRE_AUTHENTICATION

nal/beans/BeanUtilFuncs.java 92d2f62 geode-core/src/test/java/org/apache/geode/internal/net/SSLConfigurationFactoryJUnitTest.java 8b760df Diff: https://reviews.apache.org/r/52363/diff/ Testing --- Thanks, Udo Kohlmeyer

Re: Review Request 52324: GEODE-1941: delete unimplemented tests

> On Sept. 28, 2016, 2:03 a.m., Udo Kohlmeyer wrote: > > Ship It! These tests are valuable... They needed to be completed. I'll complete them. - Udo --- This is an automatically generated e-mail. To reply

Re: Review Request 52324: GEODE-1941: delete unimplemented tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52324/#review150666 --- Ship it! Ship It! - Udo Kohlmeyer On Sept. 28, 2016, 12:18

Re: Build failed in Jenkins: Geode-spark-connector #78

I can easily fix this. Sure we have a utility lying around in the core that can handle "String.isEmpty" --Udo On 24/09/2016 9:56 AM, Anthony Baker wrote: Yep, I’m seeing failures on any client app that doesn’t explicitly include spring as dependency. Exception in thread "main" java.lang.N

Re: Hibernate module and Geode 1.0 ?

this feature on hold until can be brought current. Anthony On Sep 22, 2016, at 3:31 PM, Udo Kohlmeyer wrote: +1 to removing until updated to newer version Do we know if anyone in the big-bad world is using it? --Udo On 23/09/2016 8:15 AM, William Markito wrote: Folks, We're

Re: Hibernate module and Geode 1.0 ?

+1 to removing until updated to newer version Do we know if anyone in the big-bad world is using it? --Udo On 23/09/2016 8:15 AM, William Markito wrote: Folks, We're still building the Hibernate cache module [1] but it's compatible only with a very old version (3.5) and given that the API ha

Re: Review Request 51923: GEODE-1883: making AuthInit optional when starting a server/client

> On Sept. 15, 2016, 6:40 p.m., Kirk Lund wrote: > > geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java, > > line 1728 > > > > > > Why is this deleted? This is for ssl-enabled-compon

Re: Review Request 51923: GEODE-1883: making AuthInit optional when starting a server/client

> On Sept. 15, 2016, 6:40 p.m., Kirk Lund wrote: > > The ssl-enabled-components uses SecurableCommunicationChannels. I'll be updating this javadoc to reflect that. - Udo --- This is an automatically generated e-mail. To reply, visit: h

Re: securing geode components

elease anything exposed in a User API is very difficult to change due to backwards compatibility constraints. I think we should be much more careful with User APIs in Geode going forward to avoid some of the problems we have with pre-existing Geode User APIs that we inherited. -Kirk On

Re: Review Request 51696: GEODE-1777 CI failure: RestAPIsOnMembersFunctionExecutionDUnitTest.testFunctionExecutionEOnSelectedMembers[

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51696/#review148270 --- Ship it! Ship It! - Udo Kohlmeyer On Sept. 7, 2016, 4:25

Re: Review Request 51728: GEODE-1570: upgrade spring libraries and fix tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51728/#review148269 --- Ship it! Ship It! - Udo Kohlmeyer On Sept. 8, 2016, 3:45

Re: securing geode components

As GEODE-420 deals with SSL comms configuration and GEODE-1648 with Authentication&Authorization I think we need to be careful in what is feasible and what is logical. For SSL comms it was decided that the following components are relevant [1]

Re: Review Request 51612: GEODE-1834: initilize the socketcreator with the correct ssl settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51612/#review147929 --- Ship it! Ship It! - Udo Kohlmeyer On Sept. 2, 2016, 6:38

Re: Review Request 51666: GEODE-1792: Configuration consistency in SSL configuration

ning. Thanks, Udo Kohlmeyer

Review Request 51666: GEODE-1729: Configuration consistency in SSL configuration

java/com/gemstone/gemfire/management/JMXMBeanDUnitTest.java f08c172 Diff: https://reviews.apache.org/r/51666/diff/ Testing --- Precheckin currently running. Thanks, Udo Kohlmeyer

Re: M3 is done, what's next?

+1 for package renaming +1 for sooner than later On 3/09/2016 2:46 AM, Dan Smith wrote: +1 For renaming the packages. It would be really nice to graduate ASAP! Is there anything else from a code perspective that we need to do before graduation? If so we should also get that in 1.0. It would b

Re: Review Request 51385: GEODE-900 test endup uding old cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51385/#review146696 --- Ship it! Ship It! - Udo Kohlmeyer On Aug. 24, 2016, 6:30

Re: Review Request 51227: GEODE-420: Locator SSL

://reviews.apache.org/r/51227/diff/ Testing --- precheckin - completed. All green. regression testing to follow Thanks, Udo Kohlmeyer

Re: Review Request 51227: GEODE-420: Locator SSL

gradle/java.gradle 36d88dc Diff: https://reviews.apache.org/r/51227/diff/ Testing --- precheckin - completed. All green. regression testing to follow Thanks, Udo Kohlmeyer

Re: Review Request 51227: GEODE-420: Locator SSL

/java.gradle 36d88dc Diff: https://reviews.apache.org/r/51227/diff/ Testing (updated) --- precheckin - completed. All green. regression testing to follow Thanks, Udo Kohlmeyer

Re: Review Request 49962: Removed extra fields from distributedmember while serialization/de

uickly become unmanageable. - Udo Kohlmeyer On Aug. 10, 2016, 9:25 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 51227: GEODE-420: Locator SSL

gradle/java.gradle 36d88dc Diff: https://reviews.apache.org/r/51227/diff/ Testing (updated) --- precheckin regression testing to follow Thanks, Udo Kohlmeyer

Re: Review Request 51227: GEODE-420: Locator SSL

/internal/configuration/ClusterConfigurationDUnitTest.java bdd5d71 geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/swagger/config/RestApiPathProvider.java b35dce9 gradle/java.gradle 36d88dc Diff: https://reviews.apache.org/r/51227/diff/ Testing --- Thanks, Udo

Re: Trying to upgrade spring-security

I think, if were going to upgrade to 4.1.2, we might considering upgrading the rest of the Spring libraries to the 4.3.2 compatible. spring-hateos.version = 0.16.0.RELEASE > 0.21.0 spring-shell.version = 1.1.0.RELEASE > 1.2.0 spring-ldap-core.version = 1.3.2.RELEASE > 2.1.0 spring-

Re: Publishing of geode javadocs

Maybe the review of the Javadoc for any class should be done as part of the final review of a story. Any public facing classes should be checked that the javadoc is correct for the affected classes. That the render correctly in the IDE, I think might be a side affect of making sure that they

Re: Revised SSL properties failure scenario advice.

et for multi-key keystore On Wed, Aug 10, 2016 at 4:34 PM, Bruce Schuchardt wrote: +1 for ssl-default-alias and failing Le 8/10/2016 à 3:36 PM, Udo Kohlmeyer a écrit : Hi there guys, As per the proposal for the revision of the SSL configuration < https://cwiki.apache.org/confluence/displ

Revised SSL properties failure scenario advice.

Hi there guys, As per the proposal for the revision of the SSL configuration , I'm nearing the completion of this feature. What I have come across is some scenarios where a system is configured with a multi-key keystor

Re: Javadoc warnings

Hmmm... Can you please get your team in check I get the following since updating :P :D :D :D /Users/ukohlmeyer/projects/gemfire/open/geode-core/src/main/java/org/apache/geode/security/GeodePermission.java:49: warning - @return tag has no arguments. /Users/ukohlmeyer/projects/gemfire

Re: Review Request 49729: Used static instance of logger while logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49729/#review141092 --- Ship it! Ship It! - Udo Kohlmeyer On July 6, 2016, 9:39 p.m

Re: Review Request 49666: GEODE-1613 CI failure: ConnectionPoolDUnitTest.test021ClientGetOfInvalidServerEntry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49666/#review141044 --- Ship it! Ship It! - Udo Kohlmeyer On July 5, 2016, 11:21

Docker testing support for Geode

Hi there, Whilst thinking about how to improve our testing capability (the provisioning of machines and VMs), I was pointed at this project. https://github.com/palantir/docker-compose-rule I wonder if this is something that we can look at. Maybe some extension of this, could help with our mul

Re: update website for WAN, CQ and native client

+1, to me "Multi-site" is too rigid. People might forget that this is a inter-cluster comms channel. Which would allow them to have many clusters running in the same DC, sharing data between them, satisfying the data requirements for different systems/applications. On 22/06/2016 4:54 AM, Gr

Re: Review Request 48556: Fixing spark connector build issue due to ConfigurationProperties name change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48556/#review137554 --- Ship it! Ship It! - Udo Kohlmeyer On June 10, 2016, 3:12

Re: Review Request 48665: GEODE-1542 shared/unordered tcp/ip connection times out, initiating suspicion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48665/#review137552 --- Ship it! Ship It! - Udo Kohlmeyer On June 13, 2016, 10:50

Re: Partitioned Region With Overflow Behavior Question

Hi there Avinash, Firstly I would change the critical-heap-percentage to something closer to 70 or 80. This setting is a "stop-the-world" percentage, where the amount of data inserted is greater than what can be evicted. Also I would make sure that the CMSOccupancyPercentage is 3-5% less than

GEODE-1377: DistributedSystemConfigProperties

Hi there Guys, As per a previous thread, I've moved all the javadoc from DistributedSystem to DistributedSystemConfigProperties. I have also now renamed DistributedSystemConfigProperties to ConfigurationProperties. Please make sure that for all new tests and development that you reference

Re: Eclipse and IntelliJ formatters

I really don't have a preference in regards to import formatting, as long as Eclipse and Intellij do the same thing. --Udo On 10/06/2016 3:54 am, Kirk Lund wrote: Sorry this is such a mess. Please vote on how you want it to work and then after everyone finishes voting, I'll update both to be

Re: Review Request 48239: GEODE-1498 CI Failure: DurableClientCommandsDUnitTest.testCloseDurableClients

> > (Updated June 3, 2016, 11:42 p.m.) > > > Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo > Kohlmeyer. > > > Repository: geode > > > Description > --- > > Use port 0 for cache server and return a ra

Re: build error with development branch...

Maybe try 1.8.0_92... I know it works On 3/06/2016 7:47 am, Dan Smith wrote: Hmm, does that -ea mean it's an early access build? I would recommend running with a later version of java 8. -Dan On Thu, Jun 2, 2016 at 2:41 PM, Anilkumar Gingade wrote: If gradle is using the java installed/set

Re: build error with development branch...

I think that you getting this because vm1.invokeAsync(... seems to need to return something but it does not. Maybe remove the 'AsynInvocation vm1Invoke =' part... As it serves no purpose here. --Udo On 3/06/2016 6:58 am, Anilkumar Gingade wrote: Hi Devs, Anyone seeing this issue: :geode-c

Re: Review Request 48176: Changed cache xml property for spark tests to use new DistributionConfig property

DistributedSystemConfigProperties. - Udo Kohlmeyer On June 2, 2016, 5:07 p.m., Jason Huynh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 48176: Changed cache xml property for spark tests to use new DistributionConfig property

To reply, visit: > https://reviews.apache.org/r/48176/ > --- > > (Updated June 2, 2016, 5:07 p.m.) > > > Review request for geode, William Markito, Udo Kohlmeyer, and Dan Smith. > > > Repository: geode > > &

Re: DistributionConfig and Geode system properties

s some javadocs describing to users what's contained in this interface. 3) DistributedSystem has a ton of javadocs describing each property and what it does. I wonder if those javadocs should move to the constants in this interface instead? -Dan On Wed, Jun 1, 2016 at 5:17 PM, Udo Kohlmeyer wrote

DistributionConfig and Geode system properties

Hi there, As per GEODE-1377 I've refactored DistributionConfig to extract all public system properties into a public DistributedSystemConfigProperties interface. With that refactor I've touched a significant amount of classed and I, in advan

Re: Review Request 47908: GEODE-1460 RemoveAll fails with NPE in com.gemstone.gemfire.internal.cache.tier.sockets.CacheClientNotifier.checkAndRemoveFromClientMsgsRegion()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47908/#review135740 --- Ship it! Ship It! - Udo Kohlmeyer On May 26, 2016, 8:34 p.m

Re: Review Request 48095: GEODE-1468 client/server messaging can create large objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48095/#review135739 --- Ship it! Ship It! - Udo Kohlmeyer On May 31, 2016, 10:15

Re: Review Request 47245: GEODE-1327 java.util.ConcurrentModificationException while updating log message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47245/#review134303 --- Ship it! Ship It! - Udo Kohlmeyer On May 11, 2016, 5:55 p.m

Re: Review Request 47501: GEODE-1387 CI Failure: LocatorLauncherRemoteFileIntegrationTest.testStatusUsingWorkingDirectory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47501/#review133818 --- Ship it! Ship It! - Udo Kohlmeyer On May 17, 2016, 11:49

Re: Review Request 47504: GEODE-1133 SeparateClassloaderTestRunner has to be re-implemented

it is genuinely not used anymore, I'm happy that we remove it. - Udo Kohlmeyer On May 18, 2016, 12:01 a.m., Jianxia Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 47323: GEODE-732 Unable to create PDXInstance from valid JSON using JSONFormatter

ch it. - Udo Kohlmeyer On May 12, 2016, 8:10 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 47195: GEODE-699 PartitionedRegionSingleHopDUnitTest.test_MetadataServiceCallAccuracy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47195/#review133006 --- Ship it! Ship It! - Udo Kohlmeyer On May 12, 2016, 10:45

Re: Review Request 47189: GEODE-1375 When using multicast a new member needs to receive the multicast message digest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47189/#review132729 --- Ship it! Ship It! - Udo Kohlmeyer On May 11, 2016, 5:05 p.m

Re: Unable to run single dunit

When I did this, I had to "wrap" the class with '*' The command is then. ./gradlew -DdistributedTest.single=*ListAndDescribeDiskStoreCommandsDUnitTest* On 5/05/2016 7:38 am, Kirk Lund wrote: This used to work quite well for me. Why am I not able to run a single dunit on the command-line now? I

Re: Review Request 46940: GEODE-1329 auto-reconnect attempts cease if kicked out during boot-up of the cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46940/#review131540 --- Ship it! Ship It! - Udo Kohlmeyer On May 3, 2016, 3:43 p.m

Re: Review Request 46801: GEDOE-1321 GMSHealthMonitor: java.lang.IllegalStateException: Timer already cancelled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46801/#review131370 --- Ship it! Ship It! - Udo Kohlmeyer On April 29, 2016, 4:47

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46896/#review131367 --- Ship it! Ship It! - Udo Kohlmeyer On May 2, 2016, 4:36 p.m

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

> On May 2, 2016, 7:29 p.m., Udo Kohlmeyer wrote: > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java, > > line 1703 > > <https://reviews.apache.org/r/46896/diff/1/?file=1368587#file1368587line1703> >

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

42) <https://reviews.apache.org/r/46896/#comment195285> I don't think we need to explicitly create a new HashSet for a getter. If this set needs to be "cloned" then make it the responsibility of the method invoking this function to do so. - Udo Kohlme

Re: [DISCUSS] What to do with the partial HDFS related code on develop?

+1 On 28/04/2016 7:16 am, Dan Smith wrote: This is done. The HDFS related changes are gone from develop and are now on their own feature branch - feature/GEODE-10. -Dan On Sat, Mar 19, 2016 at 2:05 AM, wrote: +1 a possible HDFS integration should also be an optional jar plugin package in th

Re: @since tags in our javadocs - old gemfire vs. geode versions

, Apr 25, 2016 at 6:36 PM, Udo Kohlmeyer wrote: I must be honest that I've never been a supporter of the @since tag. Imo, release notes and features should be the paper trail that we provide. Also, how would we handle a scenario where a class is denoted with @since 6.5.x and all internals of

  1   2   >