Re: Review Request 53814: GEODE-2100 Add new version of query client server messages

> On Nov. 16, 2016, 6:06 p.m., Dan Smith wrote: > > What is the JUnit4DistributedTestCase change for? > > Jason Huynh wrote: > If a previous test failed with suspect strings in > tearDownDistributedTestCase, the postTearDown would not get called for the > unit tes

Re: Review Request 53814: GEODE-2100 Add new version of query client server messages

? - Dan Smith On Nov. 16, 2016, 5:22 p.m., Jason Huynh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53814/ > --

Re: Review Request 53745: when a sender was stopped before becoming a primary, the wait thread should be closed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53745/#review155874 --- Ship it! Ship It! - Dan Smith On Nov. 15, 2016, 1:33 a.m

Re: Review Request 53745: when a sender was stopped before becoming a primary, the wait thread should be closed

nternal/cache/wan/GatewaySenderAdvisor.java (line 494) <https://reviews.apache.org/r/53745/#comment225951> I think these checks probably belong in the while statement, above. Otherwise if the notify happens before this thread gets into the wait it will wait forever. - Dan Smith On Nov. 14, 2016, 10

Re: GMSJoinLeaveJUnitTest format is broken?

o run whenever you try to push something: incubator-geode> echo "./gradlew build" > .git/hooks/pre-push -Dan On Mon, Nov 14, 2016 at 10:36 AM, Dan Smith wrote: > Everyone should always run ./gradlew > > On Mon, Nov 14, 2016 at 10:35 AM, Bruce Schuchardt > wrote: &g

Re: GMSJoinLeaveJUnitTest format is broken?

Everyone should always run ./gradlew On Mon, Nov 14, 2016 at 10:35 AM, Bruce Schuchardt wrote: > This is fixed now. I will not apologize for breaking the build though. I > formatted the code that I checked in with the provided formatter > configuration for Idea and that should pass the spotles

Re: Review Request 53566: GEODE-2078: Fix manifest classpath

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53566/#review155360 --- Ship it! Ship It! - Dan Smith On Nov. 8, 2016, 4:23 a.m

Re: Gfsh Parsing

+1 for simplifying the parsing and using spring shell. -Dan On Fri, Nov 4, 2016 at 1:42 PM, Real Wes wrote: > That would be a really good implementation since it would keep production > code from relying on the formatting of the GFSH return message. If you did > —output=json, then the call to

Re: Review Request 53401: GEODE-1932: Protected use of global variables

/geode/internal/cache/execute/ClientServerFunctionExecutionDUnitTest.java (line 666) <https://reviews.apache.org/r/53401/#comment224260> Couldn't this just be assertEquals? - Dan Smith On Nov. 2, 2016, 8:14 p.m., nabaru

Review Request 53399: Removing some string comparisons in the AttributesDescriptor

/src/main/java/org/apache/geode/cache/query/internal/AttributeDescriptor.java a11bea0752e8ed8184f0173f81be08b001cb6e19 Diff: https://reviews.apache.org/r/53399/diff/ Testing --- Thanks, Dan Smith

Review Request 53398: GEODE-1985: Updating the SAFE_QUERY_TIME after updating indexes

ache/geode/internal/cache/LocalRegion.java 360c6a9f444b41a99bec1a896e660bd506d793ff Diff: https://reviews.apache.org/r/53398/diff/ Testing --- Thanks, Dan Smith

jmh benchmarks

Hi all, I'd like to add some support for running benchmarks with jmh to geode. Is this something we're interested in having? JMH is a framework for easily writing microbenchmarks. It's probably not that useful for large scale multiple member benchmarks, but it can help us benchmark and optimize sm

Review Request 53395: Adding a geode-benchmark project with support for running jmh benchmarks

--- Thanks, Dan Smith

Re: Backwards compatibility for 1.1

in the > > > > spawned > > > > > VM. > > > > > > > > > > > > I have one test that sets up a server using the current version > and > > > > then > > > > > spawns a client unit test running under an older version. Th

Backwards compatibility for 1.1

Hi, We made a lot of changes in 1.0 that broke compatibility with old versions of gemfire for various reasons (package renaming, changing membership system). I just wanted to confirm that starting with 1.1, we're planning on maintaining client/server, peer-to-peer, WAN and disk backwards compatibi

Re: Review Request 53345: Adding new PDX , order by and Index Query tests to the open side

query/dunit/PDXQueryTestBase.java (line 343) <https://reviews.apache.org/r/53345/#comment224023> Get rid of these log statements. - Dan Smith On Nov. 1, 2016, 6:22 p.m., nabarun nag wrote: > > --- > This is an automatically generat

Re: Review Request 53243: GEODE-2044 Add to docs tc Server 3.2 for HTTP Session Mgmt module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53243/#review154186 --- Ship it! Ship It! - Dan Smith On Oct. 27, 2016, 10:38 p.m

Re: Review Request 53214: GEODE-2040 Add to docs Tomcat 8.0 and 8.5 for HTTP Session Mgmt module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53214/#review153966 --- Ship it! Ship It! - Dan Smith On Oct. 26, 2016, 11:44 p.m

Re: CI failures due to JMX client heartbeat thread

Just looking at a couple of these bugs, these are fatal level errors. Do you know what is causing them or what affect this might have? [fatal 2016/09/29 12:12:03.891 PDT tid=0x18d] (tid=397 msgId=39) No longer connected to cc6-co6.gemstone.com[27162]. -Dan On Wed, Oct 26, 2016 at 4:50 PM, Bruce

Re: GEODE-2036 and documentation practices and procedures

1) +1 2) +1 3) > I don’t see much value in creating an uber-JIRA for tracking minor doc changes. Why not skip it entirely? I agree with Anthony on this one, there's not much value in having some catch all JIRA for unrelated changes. -Dan On Tue, Oct 25, 2016 at 7:08 PM, Anthony Baker wrote: >

Re: [DISCUSS] Graduation

+1 -Dan On Tue, Oct 25, 2016 at 5:43 PM, Joey McAllister wrote: > +1 > > On Tue, Oct 25, 2016 at 5:42 PM Anthony Baker wrote: > > > +1 > > > > > On Oct 25, 2016, at 5:25 PM, Roman Shaposhnik wrote: > > > > > > Unless somebody objects strongly to my #2 and #3 proposals I'm going > > > to kick

Re: 2.0 release in JIRA

And it's gone. -Dan On Tue, Oct 25, 2016 at 10:54 AM, Darrel Schneider wrote: > +1 > > On Tue, Oct 25, 2016 at 10:28 AM, Swapnil Bawaskar > wrote: > > > +1 > > > > On Tuesday, October 25, 2016, Anthony Baker wrote: > > > > > +1

2.0 release in JIRA

It looks like we already have both a 1.1 and a 2.0 version in JIRA. Do we need that 2.0 version yet? The only things I see assigned to it seem to be assigned to it by mistake. Is it ok to delete that version until we're actually working on 2.0? -Dan

Re: Closing the release in JIRA

I marked it as closed. -Dan On Tue, Oct 25, 2016 at 1:08 AM, Swapnil Bawaskar wrote: > Hi, > After passing the vote on general@incubator, I closed all the issues in > JIRA that were in RESOLVED state. However, I do not seem to have permission > to close the release label in JIRA >

Re: more spotless problems on Windows

I think we have a fix for the spotless line ending issue on windows; Bruce will check it in shortly: diff --git a/build.gradle b/build.gradle index a734e05..6e82433 100755 --- a/build.gradle +++ b/build.gradle @@ -88,6 +88,7 @@ subprojects { apply plugin: "com.diffplug.gradle.spotless" spot

Re: Coding practices/standards

lew clean build' again and failed expectedly > >>>>>>>>>>> - Ran './gradlew spotlessApply', task was successful > >>>>>>>>>>> - Ran './gradlew clean build' and succeeded > >>>>>>>>

Re: Review Request 53026: GEODE-502: Startup timeout increased to 2min in DUnitLauncher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53026/#review153706 --- Ship it! Ship It! - Dan Smith On Oct. 24, 2016, 4:33 p.m

Re: Coding practices/standards

gt;>>>>>>>>> Great addition! As long as others are good with the formatter, > >>> then I > >>>>>>> am > >>>>>>>>>> good. > >>>>>>>>>> > >>>>

Re: Updating Swagger

Looks great to me!  Original message From: Kevin Duling Date: 10/20/16 12:22 PM (GMT-08:00) To: dev@geode.incubator.apache.org Subject: Re: Updating Swagger I've updated the page to appear as follows.  Any feedback is welcome. https://drive.google.com/file/d/0B-lWOyam73g

Re: jvsd

Hi Dor, jvsd hasn't yet been merged to develop, so for now you still have to check out the feature/GEODE-78 branch and build it from source. Here are some instructions: https://github.com/apache/incubator-geode/blob/feature/GEODE-78/geode-jvsd/README.md 0-Dan On Wed, Oct 19, 2016 at 1:43 AM, D

Re: Review Request 53001: GEODE-1927: more protection from seeing com.gemstone.gemfire packaged objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53001/#review153187 --- Ship it! Ship It! - Dan Smith On Oct. 18, 2016, 10:05 p.m

Re: Review Request 52793: GEODE-1353: Added listeners to slow down the receiver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52793/#review153175 --- Ship it! Ship It! - Dan Smith On Oct. 12, 2016, 5:52 p.m

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

Along these lines, should we distributing the docs with the binary release? Or maybe just providing a link to them? The README.md shipped with 1.0.RC2 points to http://geode.docs.pivotal.io/ . What about geode-examples? Should that be part of the binary release? -Dan On Mon, Oct 17, 2016 at 2:21

Review Request 52963: GEODE-388: Deprecating DynamicRegionFactory

--- Marking DynamicRegionFactory as deprecated. Diffs - geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java 3cfa73b840785cab94d4ca54aac1338304a20f30 Diff: https://reviews.apache.org/r/52963/diff/ Testing --- Thanks, Dan Smith

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

+1 - I was going to ask about this on the release thread. Let's put them up on geode.apache.org! -Dan On Mon, Oct 17, 2016 at 11:33 AM, Swapnil Bawaskar wrote: > +1, It would be great to have this by the time we put the vote out on > general@incubator > > On Mon, Oct 17, 2016 at 10:59 AM, Joey

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

+1 Checked * signatures * maven repo with simple sample app * command line test through gfsh * built the source Checked it with this thing: https://github.com/upthewaterspout/geode-release-check On Mon, Oct 17, 2016 at 11:55 AM, William Markito wrote: > +1 > > Checked SHA, signatures,

Review Request 52903: Adding a docker container to build and view the geode docs

/view-docs.sh PRE-CREATION Diff: https://reviews.apache.org/r/52903/diff/ Testing --- Adding some scripts that can build and view the docs using a docker container. Thanks, Dan Smith

Re: Coding practices/standards

ound look better. > > > On Oct 13, 2016, at 10:11 AM, Dan Smith wrote: > > > > +1 for adding this to ./gradlew build > > > > But I think we might want to fix up the formatter a bit before > reformatting > > the code. I tried running spotlessApply, an

Re: GEODE-1466: geode.properties

-1 for including any of this in the 1.0 release. Let's get that release out the door! -Dan On Thu, Oct 13, 2016 at 2:26 PM, Udo Kohlmeyer wrote: > If such a change is to be introduced.. maybe we call it `SYSTEM_PREFIX` or > something more generic that we could use within the Geode. > > Then we

Re: Build failed in Jenkins: Geode-nightly #621

Yet one more reason to run ./gradlew build *before* pushing changes to develop You can automate this by adding a pre-push trigger to your git repo. This will only do the push if the build succeeds: echo "./gradlew build" > .git/hooks/pre-push chmod u+x .git/hooks/pre-push You can do git push --n

Re: Coding practices/standards

>> ukohlme...@pivotal.io > >>>> > >>>>>> wrote: > >>>>>> > >>>>>>> +1 - adding checkstyle to precheckin. > >>>>>>> > >>>>>>> If the developer uses the provided templates

Review Request 52805: GEODE-1981: Wrapping user ResultCollector in synchronized wrapper

/SynchronizedResultCollector.java PRE-CREATION Diff: https://reviews.apache.org/r/52805/diff/ Testing --- Ran the affected test 500 times with this fix. It failed 11 times without it, passed with the fix. Thanks, Dan Smith

Re: Review Request 52796: GEODE-1981: Synchronizing the ResultCollector when adding results

p the result collector in a synchronized result collector, to avoid places where we might be accessing this thing without synchronization. - Dan Smith On Oct. 12, 2016, 6:12 p.m., Dan Smith wrote: > > --- > This is an automatical

Re: Coding practices/standards

ass import" to correct that problem. I couldn't see > how > > > to get Gradle to do it. > > > > > > > > > > > > Le 10/12/2016 à 10:28 AM, Anthony Baker a écrit : > > > >> Source code with a consistent look

Review Request 52796: GEODE-1981: Synchronizing the ResultCollector when adding results

it passed every time. Running precheckin on these changes. Thanks, Dan Smith

Re: Review Request 52789: GEODE-1978: Slowing down the receivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52789/#review152352 --- Ship it! Ship It! - Dan Smith On Oct. 12, 2016, 5:21 p.m

Re: Coding practices/standards

+1 This might be a good time to reformat the code since I don't think there are too many long lived feature branches outstanding. -Dan On Wed, Oct 12, 2016 at 10:00 AM, Jared Stewart wrote: > I would like to advocate for adding a Checkstyle sourceforge.net/> or Spotless <

Review Request 52759: GEODE-1991: Removing sleeps from HARegionQueueJUnitTest

https://reviews.apache.org/r/52759/diff/ Testing --- Thanks, Dan Smith

Re: Review Request 52750: GEODE-1985: Check for index expression reevalaution using a time window

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52750/#review152219 --- On Oct. 11, 2016, 9:53 p.m., Dan Smith wrote: > > --

Deprecate DynamicRegionFactory

I'd like to reopen the discussion about deprecating DynamicRegionFactory. This is some old crufty code I don't think we want anyone to use. I see we had a ticket to deprecated it (GEODE-388), but we chose not to do it because we don't have an alternative API to create regions from the client (GEODE

Review Request 52750: GEODE-1985: Check for index expression reevalaution using a time window

/diff/ Testing --- Thanks, Dan Smith

Re: Review Request 52575: GEODE-1962: increment notQueuedConflated stat is peeked object is unresolvable from off heap

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52575/#review152160 --- Ship it! Ship It! - Dan Smith On Oct. 5, 2016, 9:28 p.m

Re: First Apache Geode 1.0.0-incubating (GA) release...

Switched to the dev list to discuss what to do with the nightly builds. On Mon, Oct 10, 2016 at 5:13 PM, Anthony Baker wrote: > The ‘uploadArchives’ task publishes the maven artifacts into the snapshot > repo. The Geode-Nightly jenkins job publishes the develop branch, currently > version 1.1.

Re: Review Request 52700: Add more tests to flaky category based on recent CI failures

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52700/#review152067 --- Ship it! Ship It! - Dan Smith On Oct. 10, 2016, 6:54 p.m

Re: Review Request 52699: while accessor is a diskstore for now, there's race that vm_0 only hosted 1 primary bucket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52699/#review152026 --- Ship it! Ship It! - Dan Smith On Oct. 10, 2016, 6:03 p.m

Re: Review Request 52698: GEODE-1972: Move Geode Hibernate module to a feature branch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52698/#review152014 --- Ship it! Ship It! - Dan Smith On Oct. 10, 2016, 5:36 p.m

Re: Review Request 52619: GEODE-1967 Old key are not removed from the removedKeyValuesEntries after it was removed from Compact Range Indexes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52619/#review151843 --- Ship it! Ship It! - Dan Smith On Oct. 7, 2016, 5:48 p.m

Re: Hibernate module and Geode 1.0 ?

+1 for moving it to a feature branch. -Dan On Wed, Oct 5, 2016 at 2:40 PM, Jason Huynh wrote: > Bumping to see if we have come to a decision on whether we want to move > this to a feature branch and get rid of it for 1.0 or post 1.0, especially > now that the 1.0 release branch has been cut > >

Re: Assert usage in geode-core

/apache/geode/management/internal/web/http/ClientHttpRequest.java On Wed, Oct 5, 2016 at 4:56 PM, Anthony Baker wrote: > Dan did some work on this: > > commit 71eb6bfbc429e7cc226671c99f682ec4fb31115d > Author: Dan Smith > Date: Fri Sep 23 16:40:15 2016 -0700 > > GEODE-1934:

Re: Limiting scope for Geode 1.0

For the docs, do we plan on delaying the release until the docs are part of the source distribution, or until they can actually be hosted on geode.apache.org? From what I understand the docs build requires a ruby webserver to host the site, so there might some effort to try to get the docs actually

Re: Podling Report Reminder - October 2016

> > Anthony > >> On Oct 3, 2016, at 4:08 PM, Dan Smith wrote: >> >> Thanks Anthony and Swap! Updated draft: >> >> >> Geode >> >> Geode is a data management platform that provides real-time, consistent >> ac

Re: Review Request 52518: GEODE-1963: Add lucene xsd to website

these xsd files checked in. Long term I think we need to keep only one version of the xsds checked in and bundle them in both the source and the website. - Dan Smith On Oct. 4, 2016, 4:37 p.m., Jason Huynh wrote: > > --- &

Re: Podling Report Reminder - October 2016

Thanks Anthony and Swap! Updated draft: Geode Geode is a data management platform that provides real-time, consistent access to data-intensive applications throughout widely distributed cloud architectures. Geode has been incubating since 2015-04-27. Three most important is

Re: Podling Report Reminder - October 2016

Thanks John! Updated draft below. Geode Geode is a data management platform that provides real-time, consistent access to data-intensive applications throughout widely distributed cloud architectures. Geode has been incubating since 2015-04-27. Three most important issues t

Re: Podling Report Reminder - October 2016

pherd/Mentor notes: On Mon, Oct 3, 2016 at 9:39 AM, Dan Smith wrote: > I can do this for this quarter. > > -Dan > > On Sun, Oct 2, 2016 at 6:13 AM, wrote: > >> Dear podling, >> >> This email was sent by an automated system on behalf of the Apache >>

Re: Review Request 52468: Add FlakyTest category to tests with open bugs

same tests in a couple of places. Do we really need multiple tickets for the same test, or would it make sense to just close one of the tickets as a duplicate? - Dan Smith On Oct. 2, 2016, 12:07 a.m., Anthony Baker wrote: > > ---

Re: Geode docs: location of donated source files

Sorry, yes, I meant a new geode-docs subdirectory. -Dan On Sat, Oct 1, 2016 at 5:12 PM, Anthony Baker wrote: > Did you mean a new top-level dir (e.g. geode-docs) or a subdir of > geode-core? Since the docs could cover multiple components I’m not sure it > makes sense to put them under geode-co

Re: Podling Report Reminder - October 2016

I can do this for this quarter. -Dan On Sun, Oct 2, 2016 at 6:13 AM, wrote: > Dear podling, > > This email was sent by an automated system on behalf of the Apache > Incubator PMC. It is an initial reminder to give you plenty of time to > prepare your quarterly board report. > > The board meetin

Re: Geode docs: location of donated source files

Actually, it looks like the staging/docs-grant1 branch has *only* the docs files, not anything else. If you are seeing directories like geode-core in your local checkout of the branch, it's probably because you had build artifacts in those directories and git left the directory around when you swit

Re: [ANNOUNCE] Donation of Geode documentation

This is great! Is this something we want to include in 1.0? -Dan On Thu, Sep 29, 2016 at 8:54 PM, Jared Stewart wrote: > Thanks for the good news! > > On Sep 29, 2016 8:52 PM, "Kirk Lund" wrote: > > > Great news! > > > > On Thursday, September 29, 2016, Anthony Baker > wrote: > > > > > I am

Review Request 52410: GEODE-1949: Adding geode-rebalancer to the binary distribution

Description --- GEODE-1949: Adding geode-rebalancer to the binary distribution Diffs - geode-assembly/build.gradle c46c74af11798ed42cb69d6480069a69704a5932 Diff: https://reviews.apache.org/r/52410/diff/ Testing --- Thanks, Dan Smith

Re: Build failed in Jenkins: Geode-nightly #607

Looks like the build was broken by this commit. I checked in a fix: GEODE-1927: add support for old GemFire remote sites (WAN) -Dan On Thu, Sep 29, 2016 at 9:11 AM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See > > Chan

Re: Previous versions dtds

+1 for dropping the dtd up to 6.6. -1 for dropping 7.0/8.0, 8.1 xsd. I think we should keep those for another release or two to make it easier for people upgrading. Is anyone actually using createTypesFromXml? If not, I would suggest deprecating it. -Dan On Thu, Sep 29, 2016 at 2:33 PM, Jacob Ba

GEODE-1949 - Adding auto-balancer and spring-expression to geode-dependencies.jar

Hi, The geode-rebalancer jar is not currently shipped with the geode binary. I think we should include as part of the binary distribution, and also include it in geode-dependencies.jar so that it is on the classpath for the server. This won't require us to include any new dependencies in the lib

Review Request 52398: GEODE-1949: Remove the dependency on quartz from the rebalancer

/AutoBalancer.java 98c5237df68b31b46b67c4cdc6be4564990f6ae7 Diff: https://reviews.apache.org/r/52398/diff/ Testing --- Thanks, Dan Smith

Re: Review Request 52356: GEODE-1944: Index with method invocation in regionPath can throw exception when tombstones clean up during gii

/geode/cache/query/internal/index/HashIndex.java (line 1490) <https://reviews.apache.org/r/52356/#comment218811> Doesn't seem like it should catch an exception and ignore it here. - Dan Smith On Sept. 28, 2016, 4:41 p.m., Jason

Re: Review Request 52172: GEODE-1927: add support for old GemFire remote sites (WAN)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52172/#review150748 --- Ship it! Ship It! - Dan Smith On Sept. 28, 2016, 4:08 p.m

Re: Review Request 52267: GEODE-1937: Making precheckin depend on running examples

geode-examples/replicated/scripts/stopAll.sh 2a2c39b48ec469d8347529d3d471d49b34f29855 Diff: https://reviews.apache.org/r/52267/diff/ Testing --- Thanks, Dan Smith

Review Request 52267: GEODE-1937: Making precheckin depend on running examples

/startAll.sh f4ce413a27dd1ad136b364dfcfbe35a52c554ee9 geode-examples/replicated/scripts/stopAll.sh 2a2c39b48ec469d8347529d3d471d49b34f29855 Diff: https://reviews.apache.org/r/52267/diff/ Testing --- Thanks, Dan Smith

Re: Build failed in Jenkins: Geode-spark-connector #78

; >> at org.apache.geode.cache.client.ClientCacheFactory.create(Clie > >> ntCacheFactory.java:189) > >> at HelloWorld.main(HelloWorld.java:25) > >> Caused by: java.lang.ClassNotFoundException: > >> org.springframework.util.StringUtils > >>

Re: Region Put errors out in Local Multi Server environment.

t 5:02 PM, Goutam Tadi wrote: > > > >> Thanks a lot Dan :-). > >> > >> Yeah, that was intentional. > >> Your solution solves my problem. > >> > >> Thanks, > >> Goutam Tadi. > >> > >> On Fri, Sep 23, 2016 at 4:58 PM

Review Request 52229: GEODE-1934: Removing spring-core dependencies from geode-core

47f032e594abf090d68f5bb4d4a41b4442244875 geode-core/src/main/java/org/apache/geode/pdx/internal/PdxInstanceImpl.java 10a11d267754531bcd5bf116fa598fc0b3d5aad1 Diff: https://reviews.apache.org/r/52229/diff/ Testing --- Thanks, Dan Smith

Re: Review Request 52176: GEODE-1926: Modification of peedAhead() function check if heapCopy is successful before adding the key to peekedIds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52176/#review150271 --- Ship it! Ship It! - Dan Smith On Sept. 23, 2016, 9:58 p.m

Re: Hibernate module and Geode 1.0 ?

Geode provides an optional L2 cache for hibernate: http://geode.docs.pivotal.io/docs/tools_modules/hibernate_cache/setting_up_the_module.html Looking at the code, it looks like the geode-modules-hibernate is pulling in hibernate-core as a compile dependency, but it's not being distributed as part

Re: Region Put errors out in Local Multi Server environment.

Hi Goutam, It looks like you configured your two servers to have different regions. Was that intentional? What's happening is that the client is connecting to only one of the servers, which has one of your regions but not the other. Generally, when you configure gemfire servers, you should config

Re: Build failed in Jenkins: Geode-spark-connector #78

I created GEODE-1934 for this. It looks like the problem is actually that our dependencies for geode-core are messed up. spring-core is marked optional, but we're using it in critical places like this SSLConfigurationFactory. In my opinion we shouldn't depend on spring-core at all unless we're act

Re: Review Request 52176: GEODE-1926: Modification of peedAhead() function check if heapCopy is successful before adding the key to peekedIds

> On Sept. 22, 2016, 11:02 p.m., Dan Smith wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java, > > line 796 > > <https://reviews.apache.org/r/52176/diff/1/?file=1508581#file1508581line796> > > > &g

Re: Review Request 52176: GEODE-1926: Modification of peedAhead() function check if heapCopy is successful before adding the key to peekedIds

> On Sept. 22, 2016, 11:02 p.m., Dan Smith wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java, > > line 796 > > <https://reviews.apache.org/r/52176/diff/1/?file=1508581#file1508581line796> > > > &g

Re: Review Request 52179: There's race condition that the AckReader thread got the read lock and waitng for ack, but the stopSender() kicks in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52179/#review150105 --- Ship it! Ship It! - Dan Smith On Sept. 23, 2016, midnight

Re: Review Request 52176: GEODE-1926: Modification of peedAhead() function check if heapCopy is successful before adding the key to peekedIds

/cache/wan/serial/SerialGatewaySenderQueue.java (line 796) <https://reviews.apache.org/r/52176/#comment217931> Minor nit - can't you just write this code like this? Long currentKey = getCurrentKey(); if(currentKey == null) { Seems less confusing that way. - Da

Re: Review Request 52172: GEODE-1927: add support for old GemFire remote sites (WAN)

> On Sept. 22, 2016, 9:07 p.m., Dan Smith wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java, > > line 171 > > <https://reviews.apache.org/r/52172/diff/1/?file=1508461#file1508461line171> > > > > What i

Re: Review Request 52172: GEODE-1927: add support for old GemFire remote sites (WAN)

g/r/52172/#comment217884> What is this for? geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java (line 188) <https://reviews.apache.org/r/52172/#comment217883> What is this for? - Dan Smith On Sept. 22, 2016, 7:31 p.m., Bruc

Review Request 52126: GEODE-1915: Prevent deadlock registering instantiators with gateways

7 geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderOperationsDUnitTest.java 2e796e71ef4811212a320240b98f35d9639b7e4e Diff: https://reviews.apache.org/r/52126/diff/ Testing --- Thanks, Dan Smith

Re: Error loading cluster config serialized prior to repackage

I like your idea of having registered DataSwizzlers. Would registering a DataSerializer for these classes work? It would be nice to just use the extension mechanism that's already there. -Dan On Tue, Sep 20, 2016 at 1:29 PM, Bruce Schuchardt wrote: > The repackage broke those two methods. The

Re: jvsd

I don't think we should try to include jVSD in 1.0.0 at this point, because it introduces dependencies that might make the 1.0.0 release more complicated such as the MultiAxisChartFX dependency. But I think the should try to get it to develop sooner rather than later to make it easier for people to

Re: Review Request 52076: GEODE-1511: Remove test dependencies from pom file

stick with the default behavior of the gradle plugin? - Dan Smith On Sept. 20, 2016, 3:49 a.m., Anthony Baker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 51741: [GEODE-1817] Prepare for 'release quality' publishing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51741/#review148517 --- Ship it! Ship It! - Dan Smith On Sept. 11, 2016, 3:15 a.m

Review Request 51776: GEODE-1881: Support null map keys in CompactMapRangeIndex

/query/internal/index/CompactRangeIndexJUnitTest.java f01f925d8fe8b9bca245f94257fdce144ff00ca0 Diff: https://reviews.apache.org/r/51776/diff/ Testing --- Thanks, Dan Smith

Re: M3 is out - New release manager for 1.0 ?

+1 for getting package renaming in 1.0. It would also be nice if we could get some more examples in 1.0! -Dan On Fri, Sep 9, 2016 at 2:27 PM, Anthony Baker wrote: > Thanks for starting this thread. There are a few recent conversations on > this topic [1][2]. > > My thought is that we should b

Re: Gfsh Command enhancement - show missing-disk-stores

I think it should be a single command because the user is trying to diagnose the same problem - what persistent data is missing that is preventing system recovery? I'm not sure what the best name of the command is. -Dan On Fri, Sep 9, 2016 at 1:40 PM, Kenneth Howe wrote: > GEODE-1128

  1   2   3   4   5   6   7   8   >