Review Request 39747: tombstone GC did not finished at the same time on different member

2015-10-28 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39747/ --- Review request for geode and Dan Smith. Bugs: GEODE-371 https://issues.apac

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #109 was SUCCESSFUL (with 1214 tests). Change made by John Blum .

2015-10-28 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #109 was successful. --- Scheduled with changes by John Blum . 1218 tests in total. https://build.spring.io/brows

Re: [internal] Staged Geode website refresh - feedback puhlease

2015-10-28 Thread Dave Barnes
Greg, My comments: - Clean lines, useful links, it's been my go-to Geode start page since you published it. - I agree with Anthony w/r/t content Layout issues: - All the useful links are way at the bottom, have to scroll to get there. Better if they could be on the initial screen view. - Perhaps o

[GitHub] incubator-geode pull request: adding RHEL/CENTOS init scripts for ...

2015-10-28 Thread zhansen-pivotal
Github user zhansen-pivotal commented on the pull request: https://github.com/apache/incubator-geode/pull/27#issuecomment-152034286 Thank you for the comments!! Changes were made via you're recommendations with more to come. As far as being part of an rpm build I fully

[GitHub] incubator-geode pull request: adding RHEL/CENTOS init scripts for ...

2015-10-28 Thread zhansen-pivotal
GitHub user zhansen-pivotal reopened a pull request: https://github.com/apache/incubator-geode/pull/27 adding RHEL/CENTOS init scripts for locator and server Standardizing start and stop procedure for locators and servers out of the box. You can merge this pull request into a Git

[GitHub] incubator-geode pull request: adding RHEL/CENTOS init scripts for ...

2015-10-28 Thread zhansen-pivotal
Github user zhansen-pivotal closed the pull request at: https://github.com/apache/incubator-geode/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

Re: Review Request 39738: GEODE-77: moving failure-detection port information into the membership view

2015-10-28 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39738/ --- (Updated Oct. 28, 2015, 10:20 p.m.) Review request for geode and Jianxia Chen.

Review Request 39738: GEODE-77: moving failure-detection port information into the membership view

2015-10-28 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39738/ --- Review request for geode and Jianxia Chen. Repository: geode Description

[GitHub] incubator-geode pull request: adding RHEL/CENTOS init scripts for ...

2015-10-28 Thread zhansen-pivotal
GitHub user zhansen-pivotal opened a pull request: https://github.com/apache/incubator-geode/pull/27 adding RHEL/CENTOS init scripts for locator and server Standardizing start and stop procedure for locators and servers out of the box. You can merge this pull request into a Git re

Re: Review Request 39726: GEODE-504 - Removing MaxPermSize parameter

2015-10-28 Thread Mark Bretl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39726/#review104333 --- Ship it! Ship It! - Mark Bretl On Oct. 28, 2015, 6:19 p.m., Wil

[GitHub] incubator-geode pull request: Fixes GEODE-485.

2015-10-28 Thread sboorlagadda
Github user sboorlagadda commented on the pull request: https://github.com/apache/incubator-geode/pull/26#issuecomment-151962659 Thanks Dan. The branch is cleaned up reverting the cherry-picks. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] incubator-geode pull request: Fixes GEODE-485.

2015-10-28 Thread upthewaterspout
Github user upthewaterspout commented on the pull request: https://github.com/apache/incubator-geode/pull/26#issuecomment-151952966 The changes in your last commit look good. But something is odd with this PR, you have some commits from develop that have been cherry picked onto your b

[GitHub] incubator-geode pull request: Fixes GEODE-485.

2015-10-28 Thread sboorlagadda
GitHub user sboorlagadda opened a pull request: https://github.com/apache/incubator-geode/pull/26 Fixes GEODE-485. Logging at debug level on a SocketException while closing the connection to avoid any suspect strings written to logs. You can merge this pull request into a Git repo

Re: Review Request 39726: GEODE-504 - Removing MaxPermSize parameter

2015-10-28 Thread William Markito
> On Oct. 28, 2015, 6:30 p.m., Ashvin A wrote: > > build.gradle, line 385 > > > > > > Do we need to replace PermSize limit with Metaspace limit? I am not > > sure if limiting Metaspace is a good idea or not. I thin

Re: Review Request 39726: GEODE-504 - Removing MaxPermSize parameter

2015-10-28 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39726/#review104318 --- Ship it! Ship It! - Dan Smith On Oct. 28, 2015, 6:19 p.m., Will

Re: Review Request 39726: GEODE-504 - Removing MaxPermSize parameter

2015-10-28 Thread Ashvin A
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39726/#review104319 --- build.gradle (line 385)

Review Request 39726: GEODE-504 - Removing MaxPermSize parameter

2015-10-28 Thread William Markito
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39726/ --- Review request for geode, Darrel Schneider and Mark Bretl. Bugs: GEODE-504

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests

2015-10-28 Thread Nitin Lamba
> On Oct. 28, 2015, 4:12 p.m., Tushar Khairnar wrote: > > One thing Dan observed is that eclipse files (.classpath, .project) are > > checked in git but they should not be can you add gitignore entries for > > them and remove them from git tracking Sure, will delete those from repo and add to

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests

2015-10-28 Thread Tushar Khairnar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39445/#review104301 --- One thing Dan observed is that eclipse files (.classpath, .project)

Re: Review Request 39722: GEODE-77: improvements in handling loss of coordinator

2015-10-28 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39722/ --- (Updated Oct. 28, 2015, 2:50 p.m.) Review request for geode, anilkumar gingade,

Review Request 39722: GEODE-77: improvements in handling loss of coordinator

2015-10-28 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39722/ --- Review request for geode, anilkumar gingade, Jason Huynh, Jianxia Chen, and Lynn

Re: MaxPermSize option

2015-10-28 Thread Mark Bretl
William has already filed GEODE-504 for removing the MaxPermSize option. --Mark On Wednesday, October 28, 2015, Nitin Lamba wrote: > Now that Geode has moved to Java 8, it may be a good time to remove this > option from gradle build. I see a ton of warnings in Jenkins. > > Thanks, > -Nitin > >

Re: MaxPermSize option

2015-10-28 Thread Nitin Lamba
Now that Geode has moved to Java 8, it may be a good time to remove this option from gradle build. I see a ton of warnings in Jenkins. Thanks, -Nitin From: Dan Smith Sent: Wednesday, September 16, 2015 4:38 AM To: dev@geode.incubator.apache.org Subject:

Build failed in Jenkins: Geode-nightly #260

2015-10-28 Thread Apache Jenkins Server
See Changes: [mbretl] GEODE-487: Remove integrationTest and distributedTest from build task. -- [...truncated 899 lines...] Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256