Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-10-09 Thread pengcheng Liu
Hi,Benchao, In TVFs, the time attributes is just passed through from parent rels, and the TVFs just add two additional window attributes(i.e. window_start & window_end). Also, I think the time columns can be not only a time attribute with type of `TimeIndicatorType` but also a regular c

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-10-10 Thread Pengcheng Liu
nd I > think > > that’s a strong reason why we need the new TVFs syntax. > > With the new syntax, users should understand which time column to > > use and how to generate it when doing interval join and etc. > > > > Best, > > Pengcheng > > > >

Re: [VOTE] FLIP-145: Support SQL windowing table-valued function

2020-10-10 Thread Pengcheng Liu
+1, Thanks Jark for driving this. Jark Wu 于2020年10月10日周六 下午6:50写道: > +1 > > On Sat, 10 Oct 2020 at 18:41, Benchao Li wrote: > > > +1 > > > > Jark Wu 于2020年10月10日周六 下午6:06写道: > > > > > Hi all, > > > > > > I would like to start the vote for FLIP-145 [1], which is discussed and > > > reached cons

Re: [VOTE] FLIP-148: Introduce Sort-Merge Based Blocking Shuffle to Flink

2020-10-26 Thread Pengcheng Liu
+1 Jingsong Li 于2020年10月26日周一 下午12:00写道: > +1 > > Best, > Jingsong > > On Mon, Oct 26, 2020 at 11:52 AM Zhijiang > wrote: > > > Thanks for driving this improvement, Yingjie! > > > > +1 (binding) > > > > Best, > > Zhijiang > > > > > > -

Re: [ANNOUNCE] New Apache Flink Committer - Congxian Qiu

2020-11-02 Thread Pengcheng Liu
Congratulations Congxian! Matthias Pohl 于2020年11月2日周一 下午3:57写道: > Yup, congratulations Congxian! > > On Mon, Nov 2, 2020 at 8:46 AM Danny Chan wrote: > > > Congrats, Doctor Qiu! Well deserved! > > > > Congxian Qiu 于2020年10月31日周六 下午9:45写道: > > > > > Thanks all for the support. It's a great hono

Re: [VOTE] FLIP-145: Support SQL windowing table-valued function (2nd)

2020-11-10 Thread Pengcheng Liu
+1 (binding) Jark Wu 于2020年11月11日周三 上午10:13写道: > +1 (binding) > > On Tue, 10 Nov 2020 at 14:59, Jark Wu wrote: > > > Hi all, > > > > There is new feedback on the FLIP-145. So I would like to start a new > vote > > for FLIP-145 [1], > > which has been discussed and reached consensus in the discu