Re: [VOTE] FLIP-304: Pluggable Failure Enrichers

2023-04-21 Thread Panagiotis Garefalakis
gt;> > > > > >>>> +1 (binding) > > > > >>>> > > > > >>>> Best, > > > > >>>> Piotrek > > > > >>>> > > > > >>>> śr., 19 kwi 2023 o 13:49 Piotr Nowojski < &

[RESULT][VOTE] FLIP-304: Pluggable Failure Enrichers

2023-04-21 Thread Panagiotis Garefalakis
Happy to announce that FLIP-304 has been approved unanimously! Voting included 8 votes, out of which 6 were binding -- and no disapproving votes. * Piotr Nowojski (binding) * David Morávek (binding) * Hong Teoh * Roman Khachatryan (binding) * Anton Kalashnikov (binding) * Zhu Zhu (binding) * Weiji

Re: [ANNOUNCE] New Apache Flink PMC Member - Leonard Xu

2023-04-21 Thread Panagiotis Garefalakis
Congrats Leonard! On Fri, Apr 21, 2023 at 11:19 AM Ahmed Hamdy wrote: > Congratulations Leonard. > Best Regards > Ahmed > > On Fri, 21 Apr 2023 at 17:23, Samrat Deb wrote: > > > congratulations > > > > On Fri, 21 Apr 2023 at 9:44 PM, David Morávek wrote: > > > > > Congratulations, Leonard, wel

Re: [DISCUSS] Preventing Mockito usage for the new code with Checkstyle

2023-04-26 Thread Panagiotis Garefalakis
Thanks for bringing this up! +1 for the proposal @Jing Ge -- we don't necessarily need to completely migrate to Junit5 (even though it would be ideal). We could introduce the checkstyle rule and add suppressions for the existing problematic paths (as we do today for other rules e.g., AvoidStarImp

Re: [DISCUSS] Preventing Mockito usage for the new code with Checkstyle

2023-04-30 Thread Panagiotis Garefalakis
ration(extra guideline is required), even if regex has been used? Or we > just leave them as they are and clean them up in one shot after every > junit4 has been migrated to junit5. > > Best regards, > Jing > > On Wed, Apr 26, 2023 at 9:02 AM Panagiotis Garefalakis > wrot

Re: [DISCUSSION] Improved USER/SYSTEM exception wrapping in Flink code base

2023-06-05 Thread Panagiotis Garefalakis
Thanks for bringing this up Hong! Classifying exceptions was also the main driving factor behind pluggable failure enrichers . However, we could do a much better job maintaining a hierarchy of System and User exceptions thus making the classificat

Re: [DISCUSS] FLIP-294: Support Customized Job Meta Data Listener

2023-06-06 Thread Panagiotis Garefalakis
Hey Shammon, Thanks for the FLIP and the discussion! Pretty useful stuff -- also looking forward to the lineage feature! Just my 2 cents: if we want to enable users to perform heavy async operations, should we pass an ioExecutor to the listeners? Also, would it make sense to provide a default imp

Re: [DISCUSSION] Improved USER/SYSTEM exception wrapping in Flink code base

2023-06-11 Thread Panagiotis Garefalakis
rrent exception type for job management. We could address > this by wrapping the existing exception rather than replacing. > > @Panagiotis > I agree with all your points. This proposal is in synergy with Pluggable > Failure Enrichers. > > Regards, > Hong > > > On 6 Ju

[DISCUSS] FLIP-304: Pluggable failure handling for Apache Flink

2023-03-17 Thread Panagiotis Garefalakis
Hi everyone, This FLIP [1] proposes a pluggable interface for failure handling allowing users to implement custom failure logic using the plugin framework. Motivated by existing proposals [2] and tickets [3], this enables use-cases like: assigning particular types to failures (e.g., User or System

Re: [DISCUSS] FLIP-304: Pluggable failure handling for Apache Flink

2023-03-19 Thread Panagiotis Garefalakis
ows > > > > 1. How about adding more job information in FailureListenerContext? For > > example, job vertext, subtask, taskmanager location. And then user can do > > more statistics according to different dimensions. > > > > 2. Users may want to save results in

Re: [DISCUSS] FLIP-304: Pluggable failure handling for Apache Flink

2023-03-22 Thread Panagiotis Garefalakis
; > >>>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>>> Hi,Panagiotis > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>

Re: [ANNOUNCE] Apache Flink 1.17.0 released

2023-03-24 Thread Panagiotis Garefalakis
Congrats all! Well done! Cheers, Panagiotis On Fri, Mar 24, 2023 at 2:46 AM Qingsheng Ren wrote: > I'd like to say thank you to all contributors of Flink 1.17. Your support > and great work together make this giant step forward! > > Also like Matthias mentioned, feel free to leave us any sugges

Re: [DISCUSS] FLIP-304: Pluggable failure handling for Apache Flink

2023-04-09 Thread Panagiotis Garefalakis
Therefore, the > implementation/the > > > user > > > > > can decide depending on the use case whether it's necessary to have > > > > > separate namespaces for the key/value pairs or not. On the Flink > side, > > > we > > > > > would ju

Re: [DISCUSS] FLIP-304: Pluggable failure handling for Apache Flink

2023-04-12 Thread Panagiotis Garefalakis
, which accepts > > the names of enrichers to use, may be better. It allows the users to > > deploy and use the plugins in a more flexible way. The default value > > of the config can be none, which means failure enrichment will be > > disabled by default. > > A referenc

[VOTE] FLIP-304: Pluggable Failure Enrichers

2023-04-17 Thread Panagiotis Garefalakis
Hello everyone, I want to start the vote for FLIP-304: Pluggable Failure Enrichers [1] -- discussed as part of [2]. FLIP-304 introduces a pluggable interface allowing users to add custom logic and enrich failures with custom metadata labels. The vote will last for at least 72 hours (Thursday, 2

[jira] [Created] (FLINK-31888) Introduce interfaces and utils for loading and executing enrichers

2023-04-23 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-31888: -- Summary: Introduce interfaces and utils for loading and executing enrichers Key: FLINK-31888 URL: https://issues.apache.org/jira/browse/FLINK-31888

[jira] [Created] (FLINK-31889) Add documentation for implementing/loading enrichers

2023-04-23 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-31889: -- Summary: Add documentation for implementing/loading enrichers Key: FLINK-31889 URL: https://issues.apache.org/jira/browse/FLINK-31889 Project

[jira] [Created] (FLINK-31890) JobMaster per-task failure labeling

2023-04-23 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-31890: -- Summary: JobMaster per-task failure labeling Key: FLINK-31890 URL: https://issues.apache.org/jira/browse/FLINK-31890 Project: Flink

[jira] [Created] (FLINK-31891) JobMaster TM disconnect failure labeling

2023-04-23 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-31891: -- Summary: JobMaster TM disconnect failure labeling Key: FLINK-31891 URL: https://issues.apache.org/jira/browse/FLINK-31891 Project: Flink

[jira] [Created] (FLINK-31892) DefaultScheduler global failure handling

2023-04-23 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-31892: -- Summary: DefaultScheduler global failure handling Key: FLINK-31892 URL: https://issues.apache.org/jira/browse/FLINK-31892 Project: Flink

[jira] [Created] (FLINK-31893) AdaptiveScheduler global failure handling

2023-04-23 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-31893: -- Summary: AdaptiveScheduler global failure handling Key: FLINK-31893 URL: https://issues.apache.org/jira/browse/FLINK-31893 Project: Flink

[jira] [Created] (FLINK-31894) ExceptionHistory and REST API failure label integration

2023-04-23 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-31894: -- Summary: ExceptionHistory and REST API failure label integration Key: FLINK-31894 URL: https://issues.apache.org/jira/browse/FLINK-31894 Project

[jira] [Created] (FLINK-31895) End-to-end integration tests for failure labels

2023-04-23 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-31895: -- Summary: End-to-end integration tests for failure labels Key: FLINK-31895 URL: https://issues.apache.org/jira/browse/FLINK-31895 Project: Flink

[jira] [Created] (FLINK-31896) Extend web interface to support failure labels

2023-04-23 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-31896: -- Summary: Extend web interface to support failure labels Key: FLINK-31896 URL: https://issues.apache.org/jira/browse/FLINK-31896 Project: Flink

[jira] [Created] (FLINK-31993) Introduce JobMaster FailureEnricher configuration

2023-05-03 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-31993: -- Summary: Introduce JobMaster FailureEnricher configuration Key: FLINK-31993 URL: https://issues.apache.org/jira/browse/FLINK-31993 Project: Flink

[jira] [Created] (FLINK-32114) Extend FailureEnricherContext with task specific fields

2023-05-16 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-32114: -- Summary: Extend FailureEnricherContext with task specific fields Key: FLINK-32114 URL: https://issues.apache.org/jira/browse/FLINK-32114 Project

[jira] [Created] (FLINK-32123) Fix E2E kafka download timeout

2023-05-17 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-32123: -- Summary: Fix E2E kafka download timeout Key: FLINK-32123 URL: https://issues.apache.org/jira/browse/FLINK-32123 Project: Flink Issue

[jira] [Created] (FLINK-32198) Enforce single maxExceptions query parameter

2023-05-25 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-32198: -- Summary: Enforce single maxExceptions query parameter Key: FLINK-32198 URL: https://issues.apache.org/jira/browse/FLINK-32198 Project: Flink

[jira] [Created] (FLINK-33051) GlobalFailureHandler interface should be retired in favor of LabeledGlobalFailureHandler

2023-09-06 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-33051: -- Summary: GlobalFailureHandler interface should be retired in favor of LabeledGlobalFailureHandler Key: FLINK-33051 URL: https://issues.apache.org/jira/browse

[jira] [Created] (FLINK-33061) Translate failure-enricher documentation

2023-09-07 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-33061: -- Summary: Translate failure-enricher documentation Key: FLINK-33061 URL: https://issues.apache.org/jira/browse/FLINK-33061 Project: Flink

[jira] [Created] (FLINK-33086) Protect failure enrichment against unhandled exceptions

2023-09-13 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-33086: -- Summary: Protect failure enrichment against unhandled exceptions Key: FLINK-33086 URL: https://issues.apache.org/jira/browse/FLINK-33086 Project

[jira] [Created] (FLINK-33121) Failed precondition in JobExceptionsHandler due to concurrent global failures

2023-09-19 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-33121: -- Summary: Failed precondition in JobExceptionsHandler due to concurrent global failures Key: FLINK-33121 URL: https://issues.apache.org/jira/browse/FLINK-33121

[jira] [Created] (FLINK-31508) FLIP-304: Pluggable failure handling for Apache Flink

2023-03-17 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-31508: -- Summary: FLIP-304: Pluggable failure handling for Apache Flink Key: FLINK-31508 URL: https://issues.apache.org/jira/browse/FLINK-31508 Project

[jira] [Created] (FLINK-34922) Exception History should support multiple Global failures

2024-03-22 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-34922: -- Summary: Exception History should support multiple Global failures Key: FLINK-34922 URL: https://issues.apache.org/jira/browse/FLINK-34922 Project

[jira] [Created] (FLINK-36388) Truncate failure labels on web interface

2024-09-26 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-36388: -- Summary: Truncate failure labels on web interface Key: FLINK-36388 URL: https://issues.apache.org/jira/browse/FLINK-36388 Project: Flink