Re: Closing (automatically?) inactive pull requests

2018-05-14 Thread Kenneth Knowles
+dev@beam / hi dev@flink / I saw this and forwarded on to dev@beam for consideration. There was general agreement that it was interesting so I thought I'd loop them together. I tried to wait until both threads had enough support that combining them wouldn't confuse things. Beam would also be inter

Re: [DISCUSS] GitBox

2018-05-16 Thread Kenneth Knowles
Actually, GitHub has a feature so you do not require picture-perfect commits: https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/ If the owner of the PR checks the box, it will give committers write access to their branch (on their fork). A nice bonus is

Re: [DISCUSS] GitBox

2018-05-16 Thread Kenneth Knowles
. Kenn On Wed, May 16, 2018 at 11:19 AM Chesnay Schepler wrote: > This however has to be enabled by the contributor, separately for each PR. > We'll see how often we get the opportunity to use it. > > On 16.05.2018 17:43, Kenneth Knowles wrote: > > Actually, GitHub has

Re: [DISCUSS] GitBox

2018-05-16 Thread Kenneth Knowles
Rong Rong, see my reply. It can be enabled by default. I think it may be already. Kenn On Wed, May 16, 2018 at 4:24 PM Rong Rong wrote: > +1 > > One question regarding "This however has to be enabled by the contributor, > separately for each PR." > can it be by default enable when creating PR?

Re: [DISCUSS] FLIP-17 Side Inputs

2017-03-10 Thread Kenneth Knowles
Hi all, I thought I would briefly join this thread to mention some side input lessons from Apache Beam. My knowledge of Flink is not deep enough, technically or philosophically, to make any specific recommendations. And I might just be repeating things that the docs and threads cover, but I hope i

Re: Towards a spec for robust streaming SQL, Part 1

2017-04-21 Thread Kenneth Knowles
There's something to be said about having different triggering depending on which side of a join data comes from, perhaps? (delightful doc, as usual) Kenn On Fri, Apr 21, 2017 at 1:33 PM, Tyler Akidau wrote: > Thanks for reading, Luke. The simple answer is that CoGBK is basically > flatten + G