Flink Table & SQL doesn't work in very simple example

2016-06-21 Thread Jark Wu
-field-reference-expression-e#comment63160086_37838816 <http://stackoverflow.com/questions/37835408/org-apache-flink-api-table-tableexception-alias-on-field-reference-expression-e#comment63160086_37838816> - Jark Wu

Re: [Discuss] Why different job's tasks can run in the single process.

2016-06-30 Thread Jark Wu
As standalone mode has the disadvantage that the TaskManager JVM can’t isolate different jobs. Does we have any plan to improve this ? - Jark Wu > 在 2016年6月30日,下午4:19,Kevin Jacobs 写道: > > In my opinion the streaming process can be perfectly simulated on a single > node. You

Re: [DISCUSS] Putting Flink user names / logos on the homepage

2016-07-04 Thread Jark Wu
It’s a great idea! I would be happy if I can help something. In addition, maybe we can move the full “Powered By” wiki page to the website to reduce external link. - Jark Wu > 在 2016年7月4日,下午11:15,Stephan Ewen mailto:se...@apache.org>> > 写道: > > We have the "Powered

Re: Assigning an issue to self on JIRA

2016-08-14 Thread Jark Wu
Committers to add your JIRA account to the Flink Project, then you can do it. Welcome to Apache Flink Community :) - Jark Wu > 在 2016年8月15日,上午6:19,Sunny T 写道: > > Hi Ivan, > > Thanks for looking into it. > > I have not yet submitted the Apache Contributor License. Perha

[DISCUSS] Some thoughts about unify Stream SQL and Batch SQL grammer

2016-08-16 Thread Jark Wu
regate with/without window, and stream-to-stream JOIN, and so on. 4. Window also can work in batch job. Just my thoughts :) What do you think about this ? [1] https://calcite.apache.org/docs/stream.html - Jark Wu

Re: [DISCUSS] FLIP-9: Trigger DSL

2016-08-16 Thread Jark Wu
(lateFiringTrigger)) Is it legal? Will the earlyFiringTrigger and lateFiringTrigger both work ? - Jark Wu > 在 2016年8月17日,上午12:24,Kostas Kloudas 写道: > > Hi Aljoscha, > > Thanks for the feedback! > > It is a nice feature to have. The reason it is not included in the FLIP >

Re: [DISCUSS] FLIP-9: Trigger DSL

2016-08-17 Thread Jark Wu
) .accumulating() [1] https://docs.google.com/document/d/1Xp-YBf87vLTduYSivgqWVEMjYUmkA-hyb4muX3KRl08/edit#heading=h.e40hqtu6za6u <https://docs.google.com/document/d/1Xp-YBf87vLTduYSivgqWVEMjYUmkA-hyb4muX3KRl08/edit#heading=h.e40hqtu6za6u> - Jark Wu > 在 2016年8月17日,下午6:12,Aljoscha Krettek 写道

Re: [DISCUSS] Move Redis and Flume connectors to Apache Bahir and redirect contributions there

2016-08-17 Thread Jark Wu
Good start point. +1 - Jark Wu > 在 2016年8月17日,下午11:24,Robert Metzger 写道: > > Hi, > > following the discussions in [1], the community decided to offer > contributors to submit streaming connectors the Flink community can not > maintain to Apache Bahir (there is still t

Re: [DISCUSS] Some thoughts about unify Stream SQL and Batch SQL grammer

2016-08-23 Thread Jark Wu
]. Hope that can help for the upcoming Flink SQL design. +1 for creating FLIP [1] https://docs.google.com/document/d/15iVc1781dxYWm3loVQlESYvMAxEzbbuVFPZWBYuY1Ek - Jark Wu > 在 2016年8月23日,下午3:47,Fabian Hueske 写道: > > Hi, > > I did a bit of prototyping yesterday to check

Re: [DISCUSS] Some thoughts about unify Stream SQL and Batch SQL grammer

2016-08-23 Thread Jark Wu
Hi Fabian, You are right, the main thing we need to change for removing STREAM keyword is the table registration. If you would like, I can do a prototype. Hi Timo, I’m glad to contribute our work back to Flink. I will look into it and create JIRAs next days. - Jark Wu > 在 2016年8月24日,上

Re: [DISCUSS] Some thoughts about unify Stream SQL and Batch SQL grammer

2016-08-28 Thread Jark Wu
Hi Fabian, Timo, I have created a prototype for removing STREAM keyword and using batch sql parser for stream jobs. This is the working brach: https://github.com/wuchong/flink/tree/remove-stream <https://github.com/wuchong/flink/tree/remove-stream> Looking forward to your feedback.

Re: [DISCUSS] Some thoughts about unify Stream SQL and Batch SQL grammer

2016-08-29 Thread Jark Wu
Hi Timo, Yes, you are right. The STREAM keyword is invalid now. If there is a STREAM keyword in the query, the parser will throw "can’t convert table xxx to stream" exception. Because we register the table as a regular table not streamable. - Jark Wu > 在 2016年8月29日,下午8:13,Tim

Re: [DISCUSS] Some thoughts about unify Stream SQL and Batch SQL grammer

2016-08-29 Thread Jark Wu
and stream, we will determine batch or stream by the type of table environment. I think the TableSourceITCase.testCsvTableSource in batch and stream package can explain it. Am I right ? - Jark Wu > 在 2016年8月29日,下午8:59,Timo Walther 写道: > > At first glance, I thought we are l

Re: [DISCUSS] FLIP-11: Table API Stream Aggregations

2016-09-06 Thread Jark Wu
// has allowLateness() method def on(time: systemtime.type): TumblingProcessingTimeWindow= new TumblingProcessingTimeWindow(alias, ‘systemtime, size) // hasn’t allowLateness() method } object rowtime object systemtime What do you think about this? - Jark Wu > 在 2016年9月6日

Re: [DISCUSS] FLIP-11: Table API Stream Aggregations

2016-09-07 Thread Jark Wu
Hi Fabian, Thanks for sharing your ideas. They all make sense to me. Regarding to reassigning timestamp, I do not have an use case. I come up with this because DataStream has a TimestampAssigner :) +1 for this FLIP. - Jark Wu > 在 2016年9月7日,下午2:59,Fabian Hueske 写道: > > Hi, &g

Re: [DISCUSS] FLIP-11: Table API Stream Aggregations

2016-09-17 Thread Jark Wu
Hi all, It seems that there’s no objections to the window design. So could we open subtasks to start working on it now ? - Jark Wu > 在 2016年9月7日,下午4:29,Jark Wu 写道: > > Hi Fabian, > > Thanks for sharing your ideas. > > They all make sense to me. Regarding to reassi

Re: Add MapState for keyed streams

2016-10-19 Thread Jark Wu
Hi Xiaogang, I think maybe return Set> is better than Iterator>. Because users can use foreach on Set but not Iterator, and can use iterator access via set.iterator(). Maybe Map.entrySet() is a more familiar way to users. - Jark Wu > 在 2016年10月19日,下午5:18,SHI Xiaogang 写道: &g

Re: Add MapState for keyed streams

2016-10-19 Thread Jark Wu
That makes sense! Maybe we can make MapState implement Iterable interface, so that we can use foreach directly on MapState. - Jark Wu > 在 2016年10月19日,下午5:48,SHI Xiaogang 写道: > > Hi Jark > > If the state is very big, it may occupy a lot of memory if we return > Set>.

Re: [HEADS UP] Introducing ConfigOptions

2016-10-27 Thread Jark Wu
+1 The automatic configuration page generating sounds really cool. - Jark Wu > 在 2016年10月28日,上午12:23,Stephan Ewen 写道: > > I think adding descriptions to the options and auto-generating the config > docs is a very good followup. > > How about we do that after we migrated al

Re: DataStream#explain

2016-10-27 Thread Jark Wu
Hi Anton, I think we can ignore the id, do not print operator’s id in the table explain. IMO, the id information is not necessary. - Jark Wu > 在 2016年10月27日,下午8:16,Anton Solovev 写道: > > How can I execute several tests of table explain separately? > While StreamExecutionEnvir

Re: [DISCUSS] FLIP-11: Table API Stream Aggregations

2016-10-28 Thread Jark Wu
dea of having separate ".window()" and ".rowWindow()" > clauses. +1 > I would prefer to not have a "partitionBy" statement. As far as I know, the partitionBy is playing the same role with groupBy in Table API. So maybe groupBy is enough, there is no need to i

Re: [DISCUSS] Schedule and Scope for Flink 1.2

2016-10-28 Thread Jark Wu
cussed for a long time and a pull request has been on github. The 2) would be a large change, but I hope it could be included in 1.2 release, otherwise it will be more difficult to fix it. - Jark Wu > 在 2016年10月26日,下午8:09,Till Rohrmann 写道: > > +1 for the features to include. > &g

Re: [FLINK-4704 ] Move Table API to org.apache.flink.table

2016-12-05 Thread Jark Wu
+1 I would like to move these classes into `org.apache.flink.table.api` , and move Java `BatchTableEnvironment.scala` into `org.apache.flink.table.api.java`, and Scala `BatchTableEnvironment.scala` into `org.apache.flink.table.api.scala`. - Jark Wu > 在 2016年12月4日,上午3:18,Anton Mushin

Re: [jira] [Created] (FLINK-5368) Let Kafka consumer show something when it fails to read one topic out of topic list

2016-12-21 Thread Jark Wu
Hi Sednoh, It seems that the Travis error has nothing to do with the code you changed. - Jark Wu > 在 2016年12月21日,下午7:32,Hung Chang 写道: > > Hi Flink developers, > > Travis CI shows error when I send PR > https://github.com/apache/flink/pull/3036, but I don't find

Re: Datastream splitter - Confusing behaviour

2017-01-03 Thread Jark Wu
3” is printed. Hope this helps you. - Jark Wu > 在 2017年1月3日,下午7:26,madhairsilence <mailto:harish.kum...@tcs.com>> 写道: > > fromElements

Re: [DISCUSS] Development of SQL OVER / Table API Row Windows for streaming tables

2017-01-23 Thread Jark Wu
les ? Q4: The implementaion of SlideRows still need a custom operator that collects records in a priority queue ordered by the "rowtime", which is similar to the design we discussed in FLINK-4697, right? +1 not support for OVER ROW for event time at this point. Regards, Jark > 在 2

Re: TestBaseUtils refactoring

2017-01-25 Thread Jark Wu
Hi Anton, Thanks for bringing up this discussion. I think TestBaseUtils is a util class not a base class to extend. All the methods in TestBaseUtils are static, that means we can use any method directly without extend it. Thanks, Jark > 在 2017年1月26日,上午7:46,Anton Solovev 写道: > > H

Re: [DISCUSS] Development of SQL OVER / Table API Row Windows for streaming tables

2017-01-25 Thread Jark Wu
l aggregations. Regards, Jark > 在 2017年1月26日,上午11:42,Shaoxuan Wang 写道: > > Yes Fabian, > I will complete my design with more thorough thoughts. BTW, I think the > incremental aggregate (the key point I suggested is to eliminate state per > each window) I proposed should work fo

Re: [ANNOUNCE] Welcome Jark Wu and Kostas Kloudas as committers

2017-02-07 Thread Jark Wu
Thank you very much everyone! Hoping to help out the community as much as I can! - Jark > 在 2017年2月8日,上午11:04,艾广 写道: > > Congratulations, Jark and Kostas! > > 2017-02-08 10:53 GMT+08:00 Shaoxuan Wang : > >> Congratulations, Jark and Kostas! >> Let's pu

Re: [ANNOUNCE] Welcome Stefan Richter as a new committer

2017-02-11 Thread Jark Wu
Congrats, and thank you for your great work! - Jark Wu > 在 2017年2月11日,上午8:16,Stavros Kontopoulos 写道: > > Congrats! > > On Fri, Feb 10, 2017 at 9:11 PM, Matthias J. Sax wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA512 >> >> Congra

Re: [DISCUSS] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-01 Thread Jark Wu
` which is more straightforward than `fromInsertStream` for batch users and most streaming users. Besides, if we want to have a corresponding thing in the sink side, maybe we can have `toDataStream` and deprecate `toAppendStream`. Best, Jark On Wed, 2 Sep 2020 at 11:55, Jingsong Li wrote: &g

Re: [DISCUSS] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-02 Thread Jark Wu
lidate, and make it possible to use the existing API. What do you think? 3. "name-based setters should always be based on fieldNames" +1 to have constant fieldName->index mapping. It will be more straightforward and avoid confusing. We can still introduce the dynamic field index mapping i

Re: [DISCUSS] FLIP-107: Reading table columns from different parts of source records

2020-09-07 Thread Jark Wu
would be great if we can list the metadata keys (and readable/writable) we want to expose in the first version. I think they are also important public APIs, like connector options? Best, Jark On Mon, 7 Sep 2020 at 18:28, Timo Walther wrote: > Hi Leonard, > > thanks for your feedb

Re: [DISCUSS] FLIP-107: Reading table columns from different parts of source records

2020-09-07 Thread Jark Wu
ykey'] AS BIGINT) And we will push down only one "headers" metadata, right? Best, Jark On Mon, 7 Sep 2020 at 19:55, Jark Wu wrote: > Thanks Timo, > > I think this FLIP is already in great shape! > > I have following questions: > > 1. `Map listReadableMetada

Re: Merge SupportsComputedColumnPushDown and SupportsWatermarkPushDown

2020-09-07 Thread Jark Wu
Thanks to Shengkai for summarizing the problems on the FLIP-95 interfaces and solutions. I think the new proposal, i.e. only pushing the "WatermarkStrategy" is much cleaner and easier to develop than before. So I'm +1 to the proposal. Best, Jark On Sat, 5 Sep 2020 at 13:44, Sheng

Re: [DISCUSS] FLIP-107: Reading table columns from different parts of source records

2020-09-07 Thread Jark Wu
down` interfaces [1]. 3. "list the metadata keys" LGTM. Maybe we can expand the properties in the "source", e.g. allow "source.ts_ms" metadata, this is the most commonly used one. Best, Jark [1]: http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Merge-Supports

Re: [DISCUSS] FLIP-107: Reading table columns from different parts of source records

2020-09-08 Thread Jark Wu
eInfo. Besides, FlinkKafkaConsumer also calls DeserializationSchema.getProducedType as the produced type of the source function [1]. Best, Jark [1]: https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaCons

Re: Merge SupportsComputedColumnPushDown and SupportsWatermarkPushDown

2020-09-08 Thread Jark Wu
If yes, then the name of "SupportsComputedColumnPushDown" might be not correct. 4. regarding reading metadata, according to FLIP-107, we don't use the existing SupportsComputedColumnPushDown, but a new interface. Therefore, I don't find a strong use case that needs this interface so far. Best, Jark

Re: [DISCUSS] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-08 Thread Jark Wu
also keep the method `createTemporaryView(path, DataStream)`. I don't have a strong opinion on deprecating fromDataStream(datastream, exprs), but slightly prefer to keep them. Best, Jark On Wed, 9 Sep 2020 at 14:34, Danny Chan wrote: > Thanks for the summary Timo ~ > > I want to clarify a

Re: [DISCUSS] FLIP-107: Reading table columns from different parts of source records

2020-09-09 Thread Jark Wu
, 'value.format' = 'avro', 'timestamp.field' = 'ts'-- define the mapping of Kafka timestamp ); INSERT INTO kafka_table SELECT id, name, col1, col2, rowtime FROM another_table; I think this can solve all the problems without introducing any new

Re: [DISCUSS] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-09 Thread Jark Wu
I prefer to have separate APIs for them as changelog stream requires Row type. It would make the API more straightforward and reduce the confusion. Best, Jark On Wed, 9 Sep 2020 at 16:21, Timo Walther wrote: > I had this in the inital design, but Jark had concerns at least for

Re: [DISCUSS] FLIP-107: Reading table columns from different parts of source records

2020-09-09 Thread Jark Wu
yword for query-sink schema problem. Personally, I think we can use a shorter keyword "METADATA" for "SYSTEM_METADATA". Because "SYSTEM_METADATA" sounds like a system function and confuse users this looks like a computed column. Best, Jark On Wed, 9 Sep 2020 at

Re: [DISCUSS] FLIP-107: Reading table columns from different parts of source records

2020-09-09 Thread Jark Wu
are also prefixed with "fieldName TYPE", so "timestamp INT METADATA" is persisted is very straightforward. 2. From the collected user question [1], we can see that "timestamp" is the most common use case. "timestamp" is a read-write metadata. Persisted by default doe

Re: [DISCUSS] FLIP-107: Reading table columns from different parts of source records

2020-09-10 Thread Jark Wu
may not work... I don't have other objections. But maybe we should wait for the opinion from @Kurt for the new syntax. Best, Jark On Thu, 10 Sep 2020 at 16:21, Danny Chan wrote: > Thanks for driving this Timo, +1 for voting ~ > > Best, > Danny Chan > 在 2020年9月10日 +0800 PM3

Re: [ANNOUNCE] New Apache Flink Committer - Yun Tang

2020-09-15 Thread Jark Wu
Congratulations Yun! On Wed, 16 Sep 2020 at 10:40, Rui Li wrote: > Congratulations Yun! > > On Wed, Sep 16, 2020 at 10:20 AM Paul Lam wrote: > > > Congrats, Yun! Well deserved! > > > > Best, > > Paul Lam > > > > > 2020年9月15日 19:14,Yang Wang 写道: > > > > > > Congratulations, Yun! > > > > > > Bes

[ANNOUNCE] New Apache Flink Committer - Godfrey He

2020-09-15 Thread Jark Wu
ratulating Godfrey for becoming a Flink committer! Cheers, Jark Wu

Re: [VOTE] FLIP-107: Handling of metadata in SQL connectors

2020-09-16 Thread Jark Wu
+1 (binding) Best, Jark On Tue, 15 Sep 2020 at 10:32, Leonard Xu wrote: > +1(non-binding) > > Leonard > > > 在 2020年9月12日,21:46,Danny Chan 写道: > > > > +1, non-binding ~ > > > > Konstantin Knauf 于2020年9月11日 周五上午2:04写道: > > > >> +1 (bin

Re: [DISCUSS] FLIP-107: Reading table columns from different parts of source records

2020-09-16 Thread Jark Wu
Thanks Timo, The updates to `Schema` and LIKE clause looks good to me. Best, Jark On Tue, 15 Sep 2020 at 10:30, Leonard Xu wrote: > Hi, Timo > > Thanks for your explanation, it makes sense to me. > > Best, > Leonard > > > >> Hi, Timo > >> Thanks for

Re: [DISCUSS] What is the correct site version?

2020-09-17 Thread Jark Wu
Yes. We should update the "version" in docs/_config.yml in release-1.11 branch. Best, Jark On Fri, 18 Sep 2020 at 14:00, Chesnay Schepler wrote: > > Do we need to change this site version after releasing minor/bugfix > > versions? > > yes. > > > On 9/18/20

Re: [DISCUSS] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-18 Thread Jark Wu
ve a handy constructor for named Row, we may not need to distinguish the named-only or positionAndNamed mode. This can avoid (fast-fail) the potential problem when setting an invalid field. We can also come up with a new class for the field names which will construct the Map and be shared among all R

Re: Re: [DISCUSS] Support source/sink parallelism config in Flink sql

2020-09-20 Thread Jark Wu
SupportsStatisticsReport We can continue the discussion there. Best, Jark [1]: http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Introduce-SupportsParallelismReport-and-SupportsStatisticsReport-for-Hive-and-Filesystem-td43531.html On Sun, 20 Sep 2020 at 23:14, 刘大龙 wrote: > &

Re: Timed out patterns handling using MATCH_RECOGNIZE

2020-09-20 Thread Jark Wu
standard doesn't define the timeout syntax for MATCH RECOGNIZE. So we have to extend the standard and this is usually not trivial. So I think it would be better to have a joint discussion with the Calcite and Flink community together. What do you think? Best, Jark On Fri, 18 Sep 2020 at 22:48,

Re: Automatically get udf's resource files from hdfs when running a job that uses hive-udf

2020-09-21 Thread Jark Wu
55 [1]. Best, Jark [1]: https://issues.apache.org/jira/browse/FLINK-14055 On Tue, 22 Sep 2020 at 09:58, Husky Zeng <568793...@qq.com> wrote: > > http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Is-there-a-way-to-avoid-submit-hive-udf-s-resources-when-we-submit-a

Re: [DISCUSS] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-22 Thread Jark Wu
Hi Timo, Sorry for the late reply. I think it would be great if we can make `withNamesAndPositions` internal visible. This reduces the complexity of the public API. It's hard to come up with a perfect solution. So let's move on this FLIP. I don't have other concerns. Best, Jark

Re: [DISCUSS] Move Hive document to "Table & SQL Connectors" from "Table API & SQL"

2020-09-23 Thread Jark Wu
+1 to move it there. On Thu, 24 Sep 2020 at 12:16, Jingsong Li wrote: > Hi devs and users: > > After the 1.11 release, I heard some voices recently: How can't Hive's > documents be found in the "Table & SQL Connectors". > > Actually, Hive's documents are in the "Table API & SQL". Since the "Tabl

Re: [VOTE] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-24 Thread Jark Wu
+1 (binding) Best, Jark On Thu, 24 Sep 2020 at 16:22, Jingsong Li wrote: > +1 (binding) > > Best, > Jingsong > > On Thu, Sep 24, 2020 at 4:18 PM Kurt Young wrote: > > > +1 (binding) > > > > Best, > > Kurt > > > > > > On Thu

[DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-09-25 Thread Jark Wu
TABLE( TUMBLE(TABLE Bid, DESCRIPTOR(bidtime), INTERVAL '10' MINUTES)) GROUP BY window_start, window_end; I'm looking forward to your feedback. Best, Jark

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-09-26 Thread Jark Wu
is possible to migrate traditional batch SQL jobs to Flink SQL by changing a few lines. Regarding the SESSION window, this is on purpose to keep it out of the FLIP, because we want to keep the FLIP small to catch up 1.12 and SESSION TVF is rarely useful (e.g. session window join?). Best, Jark

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-09-30 Thread Jark Wu
Hi Pengcheng, Yes, the window TVF is part of the FLIP. Welcome to contribute and join the discussion. Regarding the SESSION window aggregation, users can use the existing grouped session window function. Best, Jark On Sun, 27 Sep 2020 at 21:24, liupengcheng wrote: > Hi Jark, >

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-09-30 Thread Jark Wu
performance to make it powerful and useful. Best, Jark On Thu, 1 Oct 2020 at 14:28, Jark Wu wrote: > Hi Pengcheng, > > Yes, the window TVF is part of the FLIP. Welcome to contribute and join > the discussion. > Regarding the SESSION window aggregation, users can use the existing &g

Re: flink 连hbase 报错 java.lang.NoSuchMethodError: org.apache.hadoop.yarn.api.protocolrecords.AllocateRequest.newInstance

2020-10-08 Thread Jark Wu
ssing development, please send questions to the user mailing list. Especially, please send Chinese user questions to user...@flink.apache.org. Best, Jark On Thu, 8 Oct 2020 at 17:11, 张立志 wrote: > java.lang.NoSuchMethodError: > org.apache.hadoop.yarn.api.protocolrecords.AllocateRequest.

Re: autoCommit for postgres jdbc streaming in Table/SQL API

2020-10-08 Thread Jark Wu
K-19539 [1] Best, Jark [1]: https://issues.apache.org/jira/browse/FLINK-19539 On Fri, 9 Oct 2020 at 01:29, Dylan Forciea wrote: > I’ve updated the unit tests and documentation, and I was running the azure > test pipeline as described in the instructions. However, it appears that >

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-10-09 Thread Jark Wu
Hi all, I know we have a lot of discussion and development on going right now but it would be great if we can get FLIP-145 into a votable state. If there are no objections, I would like to start voting in the next days. Best, Jark On Thu, 1 Oct 2020 at 14:29, Jark Wu wrote: > Hi every

Re: [DISCUSS] Add Translation Specification for Stateful Functions

2020-10-09 Thread Jark Wu
Thanks for driving the discussion Congxian! I'm +1 for adding translation specifications for stateful functions. What about merging the proposed translation specifications into the existing document [1]? It seems the new specifications only add some terminology translation for the glossary. Most

Re: autoCommit for postgres jdbc streaming in Table/SQL API

2020-10-09 Thread Jark Wu
Thanks for the explanation. I will review the pull request. Let's move the discussion to the PR. Best, Jark On Fri, 9 Oct 2020 at 21:06, Dylan Forciea wrote: > Jark, > > > > Thank you! I had actually mistyped the JIRA issue; autoCommit needs to be > set to false for

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-10-09 Thread Jark Wu
t the end, so I think the expand rule can be applied and support this feature naturally. Therefore, IMO, we don't need to include this feature in this FLIP to avoid the FLIP being too large. This can be a follow-up issue (maybe just add tests and docs) after the FLIP. Best, Jark On Fri, 9

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-10-09 Thread Jark Wu
e why it can't be expressed by nested window join and why users have to use interval join here. Maybe we can wait for more inputs from users when the window TVF is released and we can elaborate it again. Best, Jark On Sat, 10 Oct 2020 at 12:01, 刘 芃成 wrote: > Hi, Benchao, >I thi

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-10-10 Thread Jark Wu
Hi Danny, Thanks for the hint about named params syntax, I added examples with named params in the FLIP. Best, Jark On Sat, 10 Oct 2020 at 15:03, Pengcheng Liu wrote: > Hi, Jark, > >I've got some different opinions there, I think it's a very common use > case to use

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-10-10 Thread Jark Wu
such ability. Polymorphic table functions are table functions which just append additional columns and convert N rows into M rows, it can't touch meta information. Best, Jark On Sat, 10 Oct 2020 at 15:41, Jark Wu wrote: > Hi Danny, > > Thanks for the hint about named params syntax, I ad

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-10-10 Thread Jark Wu
ive" as the base name, but use the verb form "cumulate" because other window function names are also verbs, e.g. tumble, hop. I hope this can address your concern. Best, Jark [1]: https://docs.snowflake.com/en/sql-reference/functions-analytic.html#cumulative-window-frame-examples [2

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-10-10 Thread Jark Wu
Hi everyone, Thanks everyone for this healthy discussion. I think we have addressed all the concerns. I would continue with a voting. If you have any new objections, feel free to let me know. Best, Jark On Sat, 10 Oct 2020 at 17:54, Jark Wu wrote: > Hi Jingsong, > > That's a go

[VOTE] FLIP-145: Support SQL windowing table-valued function

2020-10-10 Thread Jark Wu
Hi all, I would like to start the vote for FLIP-145 [1], which is discussed and reached consensus in the discussion thread [2]. The vote will be open until 13th Oct. (72h), unless there is an objection or not enough votes. Best, Jark [1]: https://cwiki.apache.org/confluence/display/FLINK/FLIP

Re: [VOTE] FLIP-145: Support SQL windowing table-valued function

2020-10-10 Thread Jark Wu
+1 On Sat, 10 Oct 2020 at 18:41, Benchao Li wrote: > +1 > > Jark Wu 于2020年10月10日周六 下午6:06写道: > > > Hi all, > > > > I would like to start the vote for FLIP-145 [1], which is discussed and > > reached consensus in the discussion thread [2]. > > >

Re: [VOTE] Add Translation Specification for Stateful Functions

2020-10-12 Thread Jark Wu
+1 On Mon, 12 Oct 2020 at 17:14, Yu Li wrote: > +1 > > Best Regards, > Yu > > > On Mon, 12 Oct 2020 at 14:41, Congxian Qiu wrote: > > > I would like to start a voting thread for adding translation > specification > > for Stateful Functions, which we’ve reached consensus in [1]. > > > > > > This

Re: [VOTE] FLIP-145: Support SQL windowing table-valued function

2020-10-12 Thread Jark Wu
Hi all, The voting time for FLIP-145 has passed. I'm closing the vote now. There were 6 +1 votes, 3 of which are binding: - Benchao (binding) - Jark (binding) - Pengcheng Liu - Dalong Liu (刘大龙) - Hailong Wang - Jingsong (binding) There were no disapproving votes. Thus, FLIP-145 has

Re: [VOTE] FLIP-145: Support SQL windowing table-valued function

2020-10-13 Thread Jark Wu
ifications. Best, Jark On Tue, 13 Oct 2020 at 16:56, Timo Walther wrote: > Hi Jark, > > as far as I can see it is too early to close the voting process. The > official end time is in roughly 1 hour. > > Also, usually we exclude weekends from the voting period as you can see >

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-10-13 Thread Jark Wu
rd SQL doesn’t allow functions in the FROM clause. I think it’s because tables and functions are in different namespaces (and therefore there could be a table and a function with the same name). So you need to use the TABLE keyword to indicate that you are using a function as a tab

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-10-13 Thread Jark Wu
skip_col(scott.emp, COLUMNS(comm, hiredate, mgr)) Best, Jark [1]: https://modern-sql.com/blog/2018-11/whats-new-in-oracle-database-18c#ptf [2]: https://docs.oracle.com/en/database/oracle/oracle-database/18/sqlrf/Oracle-Support-for-Optional-Features-of-SQLFoundation2011.html#GUID-3BA98AEC-FAAD-4

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-10-13 Thread Jark Wu
pN function - re-assign watermarks? - re-partition data, similar feature to Hive DISTRIBUTED BY syntax. - ... Best, Jark [1]: https://issues.apache.org/jira/browse/CALCITE-3780?focusedCommentId=17123472&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17123472 O

Re: [DISCUSS] Support KeyedSortedMapState in DataStream API

2020-10-14 Thread Jark Wu
flink-table/src/main/java/org/apache/flink/table/typeutils/ordered Best, Jark On Thu, 15 Oct 2020 at 06:46, Sean Z wrote: > Thanks for the reply! Look forward to learning more about this prototype. > Is there any way that we could track this TemporalState like Jira issue? or > shou

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-10-15 Thread Jark Wu
SERT INTO items_5min SELECT item_id, seller_id, window_start, window_end, SUM(price) as sales, COUNT(DISTINCT user_id) as item_buyer_cnt FROM tumbled_view GROUP BY item_id, seller_id, window_start, window_end; Best, Jark [1]: https://cwiki.apache.org/confluence/display/FLINK/FLIP-145%3A+Support+SQ

Re: [VOTE] FLIP-146: Improve new TableSource and TableSink interfaces

2020-10-15 Thread Jark Wu
+1 On Fri, 16 Oct 2020 at 10:27, admin <17626017...@163.com> wrote: > +1 > > > 2020年10月16日 上午10:05,Danny Chan 写道: > > > > +1, nice job ! > > > > Best, > > Danny Chan > > 在 2020年10月15日 +0800 PM8:08,Jingsong Li ,写道: > >> Hi all, > >> > >> I would like to start the vote for FLIP-146 [1], which is d

Re: [DISCUSS] FLIP-149: Introduce the KTable Connector

2020-10-19 Thread Jark Wu
ure what's the default behavior of KSQL. But I guess it also stores the keys in value from this example docs (see the "users_original" table) [1]. Best, Jark [1]: https://docs.confluent.io/current/ksqldb/tutorials/basics-local.html#create-a-stream-and-table On Mon, 19 Oct 2020 a

Re: [DISCUSS] FLIP-149: Introduce the KTable Connector

2020-10-19 Thread Jark Wu
ream and KSQL users. We have seen several questions in the mailing list asking how to model a KTable and how to join a KTable in Flink SQL. Best, Jark On Mon, 19 Oct 2020 at 19:53, Jark Wu wrote: > Hi Jingsong, > > As the FLIP describes, "KTable connector produces a changelog strea

Re: [DISCUSS] FLIP-149: Introduce the KTable Connector

2020-10-21 Thread Jark Wu
al "kafka" connector. It would be more handy to use and less fallible if separating them into two connectors. In the implementation layer, we can reuse code as much as possible. Therefore, I'm still +1 to have a new connector. The "kafka-compacted" name sounds good to me

Re: [DISCUSS] FLIP-149: Introduce the KTable Connector

2020-10-22 Thread Jark Wu
e production perspective, log compaction should always be enabled if it is used in this purpose. Calling it "kafka-compacted" can even remind users to enable log compaction. I don't agree to introduce "model = table/stream" option, or "connector=kafka-table", bec

Re: [DISCUSS] FLIP-149: Introduce the KTable Connector

2020-10-22 Thread Jark Wu
lidation changes to the new > requirements. I personally find it more intuitive than a seperate > connector, my fear is users won't understand its the same physical kafka > sink under the hood and it will lead to other confusion like does it offer > the same persistence guarantees? I t

Re: [DISCUSS] FLIP-149: Introduce the KTable Connector

2020-10-22 Thread Jark Wu
y systems and matches the behavior of how we handle the kafka messages. What do you think? Best, Jark [1]: https://materialize.io/docs/sql/create-source/text-kafka/#upsert-on-a-kafka-topic On Thu, 22 Oct 2020 at 22:53, Kurt Young wrote: > Good validation messages can't solve the br

Re: [DISCUSS] FLIP-149: Introduce the KTable Connector

2020-10-22 Thread Jark Wu
inology in user mailing lists [3][4]. Many other systems support "UPSERT" statement natively, such as impala [5], SAP [6], Phoenix [7], Oracle NoSQL [8], etc.. Therefore, I think we don't need to be afraid of introducing "upsert" terminology, it is widely accepted

Re: [VOTE] NEW FLIP-102: Add More Metrics to TaskManager

2020-10-22 Thread Jark Wu
+1 Thanks for the work. Best, Jark On Fri, 23 Oct 2020 at 10:13, Xintong Song wrote: > Thanks Yadong, Mattias and Lining for reviving this FLIP. > > I've seen so many users confused by the current webui page of task manager > metrics. This FLIP should definitely help th

Re: [DISCUSS] FLIP-149: Introduce the KTable Connector

2020-10-23 Thread Jark Wu
Thanks Shengkai! +1 to start voting. Best, Jark On Fri, 23 Oct 2020 at 15:02, Shengkai Fang wrote: > Add one more message, I have already updated the FLIP[1]. > > [1] > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-149%3A+Introduce+the+upsert-kafka+Connector >

Re: [VOTE]FLIP-149: Introduce the upsert-kafka connector

2020-10-23 Thread Jark Wu
+1 On Fri, 23 Oct 2020 at 15:25, Shengkai Fang wrote: > Hi, all, > > I would like to start the vote for FLIP-149[1], which is discussed and > reached a consensus in the discussion thread[2]. The vote will be open > until 16:00(UTC+8) 28th Oct. (72h, exclude weekends), unless there is an > object

Re: [ANNOUNCE] New Apache Flink Committer - Congxian Qiu

2020-10-28 Thread Jark Wu
Congrats Congxian! Best, Jark On Thu, 29 Oct 2020 at 14:28, Yu Li wrote: > Hi all, > > On behalf of the PMC, I’m very happy to announce Congxian Qiu as a new > Flink committer. > > Congxian has been an active contributor for more than two years, with 226 > contributions

Re: Could someone please take a look at mr PR, thanks

2020-11-02 Thread Jark Wu
Sorry for the late reviewing. The community is busy preparing for 1.12 release. I guess this is the reason that this PR was missed to review. I will help to review this PR later. Thanks for the contribution! Best, Jark On Tue, 3 Nov 2020 at 10:36, JiaTao Tao wrote: > Here I fix a potent

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-11-08 Thread Jark Wu
tems don't support nested rows well. Therefore, we still insist on using three fields. I would like to start a new VOTE for the updated FLIP-145 if there are no objections. Best, Jark [1]: https://lists.apache.org/x/thread.html/ra98db08e280ddd9adeef62f456f61aedfdf7756e215cb4d66e2a52c9@%

[VOTE] FLIP-145: Support SQL windowing table-valued function (2nd)

2020-11-09 Thread Jark Wu
, Jark [1]: https://cwiki.apache.org/confluence/display/FLINK/FLIP-145%3A+Support+SQL+windowing+table-valued+function [2]: http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-145-Support-SQL-windowing-table-valued-function-td45269.html

Re: [VOTE] FLIP-145: Support SQL windowing table-valued function (2nd)

2020-11-10 Thread Jark Wu
+1 (binding) On Tue, 10 Nov 2020 at 14:59, Jark Wu wrote: > Hi all, > > There is new feedback on the FLIP-145. So I would like to start a new vote > for FLIP-145 [1], > which has been discussed and reached consensus in the discussion thread > [2]. > > The vote will be

Re: Re: Re: [VOTE] FLIP-145: Support SQL windowing table-valued function (2nd)

2020-11-16 Thread Jark Wu
Hi all, The voting time for FLIP-145 has passed. I'm closing the vote now. There were 8 +1 votes, 4 of which are binding: - Pengcheng Liu - Jark Wu (binding) - Timo (binding) - Dalong Liu - Hailong Wang - Jingsong Li (binding) - Danny Chen - Benchao Li (binding) There were no disapproving

Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-18 Thread Jark Wu
+1 to use the Java-based testing framework and +1 for using docker images in the future. IIUC, the Java-based testing framework refers to the `flink-end-to-end-tests-common` module. The java-based framework helped us a lot when debugging the unstable e2e tests. Best, Jark On Wed, 18 Nov 2020 at

Re: [REMINDER] Build docs before merging

2020-11-18 Thread Jark Wu
+1 for this. Would be better to run the `check_links.sh` for broken links. Btw, could we add the docs build and check into PR CI. I think it would be better to guarantee this in the process. Best, Jark On Wed, 18 Nov 2020 at 18:08, Till Rohrmann wrote: > Hi everyone, > > I noticed in

<    1   2   3   4   5   6   7   8   9   10   >