Re: [VOTE] Release flink-connector-dynamodb v3.0.0, release candidate #0

2022-11-29 Thread Hamdy, Ahmed
+1 (non-binding) On 29/11/2022, 08:27, "Teoh, Hong" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. +1 (non-binding) * Hashes and Signatures look good

[DISCUSS] FLIP-284: Making AsyncSinkWriter Flush triggers adjustable

2023-01-03 Thread Hamdy, Ahmed
Hi all I want to initiate discussion around FLIP-284[1]. The purpose of the FLIP is making AsyncSinkWriter[2] buffer controls adjustable as this was discovered to be sink dependant during the implementation for DDB sink[3]. Currently the async sink buffer control logic can be classified into buff

Re: [DISCUSS] Check and add sql-connector uber jar e2e tests

2023-01-09 Thread Hamdy, Ahmed
Hi Weijie I personally agree with the proposal, it guarantees keeping high standards across our repos. Speaking from AWS connectors side, we have maintained e2e tests for Kinesis and Firehose sql connectors, DDB to follow. Happy to coordinate regarding any new conventions or suggestions. On 0

Re: [ANNOUNCE] New Apache Flink PMC Member - Danny Cranmer

2022-11-01 Thread Hamdy, Ahmed
Congratulations, Danny! Best, Ahmed On 01/11/2022, 09:51, "Yuxin Tan" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. Congrats, Danny! Best, Yuxin