Re: No SchemaValidator When switch to blink table planner.

2019-07-16 Thread Danny Chan
How do you use the Kafka connector, through the TableEnvironment#sqlUpdate (the DDL), or through the TableEnvironment#connect() (the table api) ? Best, Danny Chan 在 2019年7月16日 +0800 PM4:41,kaka chen ,写道: > Hi All, > > We are trying to switch to blink table planner in Kafka's

Re: flink-python failed on Travis

2019-07-16 Thread Danny Chan
I have the same issue ~~ Best, Danny Chan 在 2019年7月17日 +0800 AM11:21,Haibo Sun ,写道: > Hi, folks > > > I noticed that all of the Travis tests reported the following failure. Is > anyone working on this issue? > > > ___

Re:Re: [ANNOUNCE] Jiangjie (Becket) Qin has been added as a committer to the Flink project

2019-07-18 Thread Danny Chan
> Congratulations! Best, Danny Chan 在 2019年7月18日 +0800 PM6:29,Haibo Sun ,写道: > Congratulations Becket!Best, > Haibo > 在 2019-07-18 17:51:06,"Hequn Cheng" 写道: > > Congratulations Becket! > > > > Best, Hequn > > > > On Thu, Jul 18, 2019 at

[DISCUSS] Support computed column for Flink SQL

2019-07-23 Thread Danny Chan
mM [3] https://docs.google.com/document/d/110TseRtTCphxETPY7uhiHpu-dph3NEesh3mYKtJ7QOY/edit?usp=sharing Best, Danny Chan

Re: [ANNOUNCE] Kete Young is now part of the Flink PMC

2019-07-23 Thread Danny Chan
Congratulations Kurt, Well deserved. Best, Danny Chan 在 2019年7月23日 +0800 PM5:24,dev@flink.apache.org,写道: > > Congratulations Kurt, Well deserved.

Re: [ANNOUNCE] Zhijiang Wang has been added as a committer to the Flink project

2019-07-23 Thread Danny Chan
Congratulations Zhijiang! Best, Danny Chan 在 2019年7月22日 +0800 PM10:12,dev@flink.apache.org,写道: > > Congratulations Zhijiang!

Re: contributor permission application

2019-07-23 Thread Danny Chan
Hi, zhang yue There is no need to apply permission for JIRA issues now, you can left your message under the JIRA issues you are interested in, the committers would assign it to you if they saw your message. Best, Danny Chan 在 2019年7月23日 +0800 PM6:06,zhang yue ,写道: > No one responded to me,W

Re: flink 1.9 DDL nested json derived

2019-08-16 Thread Danny Chan
/FlinkDDLDataTypeTest.java#L165 Best, Danny Chan 在 2019年8月15日 +0800 PM2:12,Shengnan YU ,写道: > > Hi guys > I am trying the DDL feature in branch 1.9-releasae. I am stucked in creating > a table from kafka with nested json format. Is it possibe to specify a "Row" > type of col

Re: Flink SQL - Support Computed Columns in DDL?

2019-09-03 Thread Danny Chan
Yeah, we are planning to implement this feature in release-1.10, wait for our good news ! Best, Danny Chan 在 2019年9月3日 +0800 PM6:19,Qi Luo ,写道: > Hi folks, > > Computed columns in Flink SQL DDL is currently disabled in both old planner > and Blink planner (throws "Computed colum

Re: [DISCUSS] FLIP-57 - Rework FunctionCatalog

2019-09-03 Thread Danny Chan
/9a4eab5240d96379431d14a1ac33bfebaf6fbb28 Best, Danny Chan 在 2019年8月28日 +0800 AM2:50,Bowen Li ,写道: > Hi folks, > > I'd like to kick off a discussion on reworking Flink's FunctionCatalog. > It's critically helpful to improve function usability in SQL. > > h

Re: [DISCUSS] FLIP-54: Evolve ConfigOption and Configuration

2019-09-03 Thread Danny Chan
> with the new SQL DDL based on properties as well as more connectors and formats coming up, unified configuration becomes more important I Cann’t agree more, do you think we can unify the config options key format here for all the DDL properties ? Best, Danny Chan 在 2019年8月16日 +0800 PM10

Re: [DISCUSS] FLIP-57 - Rework FunctionCatalog

2019-09-03 Thread Danny Chan
The way you proposed are basically the same as what Calcite does, I think we are in the same line. Best, Danny Chan 在 2019年9月3日 +0800 PM7:57,Timo Walther ,写道: > This sounds exactly as the module approach I mentioned, no? > > Regards, > Timo > > On 03.09.19 13:42, Danny Chan

Re: [DISCUSS] Support JSON functions in Flink SQL

2019-09-04 Thread Danny Chan
represent a JSON object in Flink maybe a key point we need to resolve. In Calcite, we use ANY type to represent as the JSON, but I don’t think it is the right way to go, maybe we can have a discussion here. Best, Danny Chan 在 2019年9月4日 +0800 PM8:34,Xu Forward ,写道: > Hi everybody, > > I'

Re: [DISCUSS] FLIP-66: Support time attribute in SQL DDL

2019-09-05 Thread Danny Chan
Thanks Jark for bring up this topic, this is definitely an import feature for the SQL, especially the DDL users. I would spend some time to review this design doc, really thanks. Best, Danny Chan 在 2019年9月6日 +0800 AM11:19,Jark Wu ,写道: > Hi everyone, > > I would like to start discuss

[DISCUSS] FLIP-70 - Support Computed Column for Flink SQL

2019-09-16 Thread Danny Chan
Any suggestions are appreciated, thanks. [1] https://docs.microsoft.com/en-us/sql/relational-databases/tables/specify-computed-columns-in-a-table?view=sql-server-2016 [2] https://dev.mysql.com/doc/refman/5.7/en/create-table-generated-columns.html [3] https://oracle-base.com/articles/11g/virtual-columns-11gr1 Best, Danny Chan

Re: [DISCUSS] Drop connectors for Elasticsearch 2.x and 5.x

2020-02-10 Thread Danny Chan
5.x seems to have a lot of users, is the 6.x completely compatible with 5.x ~ Best, Danny Chan 在 2020年2月10日 +0800 PM9:45,Dawid Wysakowicz ,写道: > Hi all, > > As described in this https://issues.apache.org/jira/browse/FLINK-11720 > ticket our elasticsearch 5.x connector does not work ou

Re: [DISCUSS] FLIP-107: Reading table columns from different parts of source records

2020-03-03 Thread Danny Chan
.htm#VLDBG1270 Best, Danny Chan 在 2020年3月2日 +0800 PM6:16,Dawid Wysakowicz ,写道: > Hi Jark, > Ad. 2 I added a section to discuss relation to FLIP-63 > Ad. 3 Yes, I also tried to somewhat keep hierarchy of properties. Therefore > you have the key.format.type. > I also considered exactly

[DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-09 Thread Danny Chan
', k2='v2') *+/ I am looking forward to your comments. You can access the FLIP here: https://cwiki.apache.org/confluence/display/FLINK/FLIP-113%3A+SQL+and+Planner+Hints Best, Danny Chan

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-09 Thread Danny Chan
Note: we only plan to support table hints in Flink release 1.11, so please focus mainly on the table hints part and just ignore the planner hints, sorry for that mistake ~ Best, Danny Chan 在 2020年3月9日 +0800 PM4:36,Danny Chan ,写道: > Hi, fellows ~ > > I would like to propose the support

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-09 Thread Danny Chan
Jinsong: I have removed the query hints part and change the title. [1]  https://docs.microsoft.com/en-us/sql/t-sql/queries/hints-transact-sql-query?view=sql-server-ver15 Best, Danny Chan 在 2020年3月9日 +0800 PM5:46,Timo Walther ,写道: > Hi Danny, > > thanks for the proposal. I agree with Jark an

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-10 Thread Danny Chan
string literal, which means that it’s compatible with our DDL syntax. We support simple identifier because many other hints do not have the component complex keys like the table properties, and we want to unify the parse block. Best, Danny Chan 在 2020年3月10日 +0800 PM3:19,wenlong.lwl ,写道: > Hi Da

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-10 Thread Danny Chan
prune, we can do that if we have an offset column, but most of the case we do not define that, so there is actually no conflict or overlap. Best, Danny Chan 在 2020年3月10日 +0800 PM4:28,Timo Walther ,写道: > Hi Danny, > > shouldn't FLIP-110[1] solve most of the problems we have around

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-10 Thread Danny Chan
Map that cannot > overwrite existing properties? I think this would be a different story... > > Regards, > Timo > > > On 10.03.20 10:34, Danny Chan wrote: > > Thanks Timo ~ > > > > Personally I would say that offset > 0 and start offset = 10 does not > have

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-10 Thread Danny Chan
ence it in the query, I’m confused for that, can you elaborate a little ? Best, Danny Chan 在 2020年3月11日 +0800 PM12:52,Bowen Li ,写道: > Thanks Danny for kicking off the effort > > The root cause of too much manual work is Flink DDL has mixed 3 types of > params together and doesn'

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-11 Thread Danny Chan
the hint syntax without changing the SQL parser, and makes clear that we are at liberty to ignore hints entirely. Julian [1] https://www.amazon.com/s?k=9781565924017  <https://www.amazon.com/s?k=9781565924017> Best, Danny Chan 在 2020年3月11日 +0800 PM4:03,Timo Walther ,写道: > Hi Danny,

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-11 Thread Danny Chan
eta like index column, and it is very convenient to specify table properties. Or shall we not call  /*+ PROPERTIES(offset=123) */ table hint, we can call it table dynamic parameters. Best, Danny Chan 在 2020年3月11日 +0800 PM9:20,Aljoscha Krettek ,写道: > Hi, > > I don't understand this

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-12 Thread Danny Chan
amic property into > > query would have better user experience. > > > > Both 2 & 3 can make this happen. The cons of #2 is breaking SQL > compliant, > > and for #3, it only breaks some > > unwritten rules, but we can have an explanation on that. And I really >

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-17 Thread Danny Chan
factories in order to merge these properties (and the logic are almost the same), what do you think about this? [1]  https://docs.databricks.com/spark/latest/spark-sql/language-manual/create-table.html Best, Danny Chan 在 2020年3月17日 +0800 PM10:10,Timo Walther ,写道: > Hi Danny, > > thanks for

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-17 Thread Danny Chan
Yes, I think we should move the `supportedHintOptions` from TableFactory to TableSourceFactory, and we also need to add the interface to TableSinkFactory though because sink target table may also have hints attached. Best, Danny Chan 在 2020年3月18日 +0800 AM11:08,Kurt Young ,写道: > Have

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-18 Thread Danny Chan
/CsvTableSourceFactoryBase.java#L92 Best, Danny Chan 在 2020年3月18日 +0800 PM9:10,Timo Walther ,写道: > Hi everyone, > > +1 to Kurt's suggestion. Let's just have it in source and sink factories > for now. We can still move this method up in the future. Currently, I > don

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-25 Thread Danny Chan
ps://cwiki.apache.org/confluence/display/FLINK/FLIP-113%3A+Supports+Dynamic+Table+Options+for+Flink+SQL Best, Danny Chan Jark Wu 于2020年3月18日周三 下午10:38写道: > Hi everyone, > > Sorry, but I'm not sure about the `supportedHintOptions`. I'm afraid it > doesn't solve

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-26 Thread Danny Chan
to ` > *OptimizerConfigOptions*` > > Best, > Kurt > > > On Thu, Mar 26, 2020 at 4:40 PM Timo Walther wrote: > > > Thanks for the update Danny. +1 for this proposal. > > > > Regards, > > Timo > > > > On 26.03.20 04:51, Danny Chan wrote: >

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-26 Thread Danny Chan
ic-table-options.enabled" should belong to ` > > *OptimizerConfigOptions*` > > > > Best, > > Kurt > > > > > > On Thu, Mar 26, 2020 at 4:40 PM Timo Walther wrote: > > > > > Thanks for the update Danny. +1 for this proposal. > > > &

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-26 Thread Danny Chan
to > use a whitelist and force people to think about what should be exposed > as a hint. By default, no option should be exposed. It is better to be > conservative here. > > Regards, > Timo > > > On 26.03.20 10:31, Danny Chan wrote: > > Thanks Kurt for the s

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-26 Thread Danny Chan
Sorry, i meant white-list ~ Danny Chan 于2020年3月27日周五 下午12:40写道: > Thanks everyone for the feedback ~ > > - For the global config option belongs to `ExecutionConfigOptions` or > `OptimizerConfigOptions`, i have to strong objections, switch > to `OptimizerConfigOptions` is okey t

[VOTE] FLIP-113: Supports Dynamic Table Options for Flink SQL

2020-03-30 Thread Danny Chan
Hi all, I would like to start the vote for FLIP-113 [1], which is discussed and reached a consensus in the discussion thread [2]. The vote will be open until April 2nd (72h), unless there is an objection or not enough votes. Thanks, Danny Chan [1] https://cwiki.apache.org/confluence/display

Re: [DISCUSS] FLIP-122: New Connector Property Keys for New Factory

2020-03-30 Thread Danny Chan
, such as “some-key-prefix” = “k1=v1, k2=v2 ..." • Should the ConfigOption support the wildcard ? (If we plan to support the current multi-line style) Best, Danny Chan 在 2020年3月31日 +0800 AM12:37,Jark Wu ,写道: > Hi all, > > Thanks for the feedbacks. > > It seems that we have a c

Re: [VOTE] FLIP-110: Support LIKE clause in CREATE TABLE

2020-03-31 Thread Danny Chan
+1 for this feature, although the WITH syntax breaks the SQL standard, but it’s compatible with our CREATE TABLE syntax, seems well from my side. Best, Danny Chan 在 2020年3月31日 +0800 PM5:46,Dawid Wysakowicz ,写道: > Hi, > > Just wanted to notify the voters that after a comment from J

Re: [ANNOUNCE] New Committers and PMC member

2020-04-01 Thread Danny Chan
Congratulations! Best, Danny Chan 在 2020年4月1日 +0800 PM7:36,dev@flink.apache.org,写道: > > Congratulations!

Re: [VOTE] FLIP-113: Supports Dynamic Table Options for Flink SQL

2020-04-01 Thread Danny Chan
Thanks, the vote cancels, I would fire a new one if we make agreement in the discussion. Best, Danny Chan 在 2020年4月1日 +0800 AM10:38,Jingsong Li ,写道: > Hi Danny, > > If I haven't missed anything, I don't know how to support the dynamic > options of format. > Co

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-04-01 Thread Danny Chan
ure for keys, and it does not support wildcard yet. Best, Danny Chan 在 2020年4月1日 +0800 PM9:12,Dawid Wysakowicz ,写道: > Hi, > Few comments from my side: > 1. Regarding the motivation: > I think the example with changing the update-mode is not a good one. In the > long term this should be

Re: [DISCUSS] Change default planner to blink planner in 1.11

2020-04-01 Thread Danny Chan
+1 to use blink-planner as the default. It’s really awful to upgrade Calcite for both planners each time. I believe user would also want a default planner that is more powerful. Best, Danny Chan 在 2020年4月1日 +0800 PM10:26,Leonard Xu ,写道: > +1 to make the Blink planner be the planner in 1

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-04-05 Thread Danny Chan
ame expressiveness, use blacklist makes the code not too verbose to enumerate all the duplicate keys with #supportedKeys .(Not very strong reason, but i think as a connector developer, it makes sense) Best, Danny Chan 在 2020年4月3日 +0800 PM11:28,Timo Walther ,写道: > Hi everyone, > >

Re: [ANNOUNCE] New Flink committer: Seth Wiesman

2020-04-07 Thread Danny Chan
Congratulations ~ Best, Danny Chan 在 2020年4月7日 +0800 PM2:56,Congxian Qiu ,写道: > Congratulations, Seth! > > Best, > Congxian > > > Kurt Young 于2020年4月7日周二 下午2:53写道: > > > Congratulations, Seth! > > > > Best, > > Kurt > > >

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-04-07 Thread Danny Chan
trongly against hints that change query semantics, but if > we > > > > disable this by default I would be (reluctantly) OK with the feature. > > > > Companies that create deployments or set up the SQL environment for > > > > users can enable the feature if they want. >

Re: [DISCUSS] FLIP-71 - E2E View support in Flink SQL

2020-04-07 Thread Danny Chan
+1 for the proposal, a small concern for drop view statement: dropViewStatement:   DROP VIEW name [ IF EXISTS ] I think the drop statement should be DROP VIEW [ IF EXISTS ] name Best, Danny Chan 在 2020年4月8日 +0800 AM11:54,Kurt Young ,写道: > This FLIP seems to be quite straightforward, +1 f

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-04-08 Thread Danny Chan
`table.dynamic-table-options.enabled` seems fine to me, I would make a new `TableConfigOptions` class and put the config option there ~ What do you think about the new class to put ? Best, Danny Chan 在 2020年4月8日 +0800 PM5:33,dev@flink.apache.org,写道: > > `table.dynamic-table-options.enabled`

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-04-08 Thread Danny Chan
t; On Wed, 8 Apr 2020 at 18:59, Danny Chan wrote: > > > `table.dynamic-table-options.enabled` seems fine to me, I would make a > new > > `TableConfigOptions` class and put the config option there ~ > > > > What do you think about the new class to put ? > >

Re: [VOTE] FLIP-71: E2E View support in Flink SQL

2020-04-09 Thread Danny Chan
+1 from my side. Best, Danny Chan 在 2020年4月9日 +0800 PM9:23,Timo Walther ,写道: > +1 (binding) > > Thanks for your efforts. > > Regards, > Timo > > > On 09.04.20 14:46, Zhenghua Gao wrote: > > Hi all, > > > > I'd like to start the vote for FLIP-

[VOTE] FLIP-113: Supports Dynamic Table Options for Flink SQL

2020-04-09 Thread Danny Chan
Hi all, I would like to start the vote for FLIP-113 [1], which is discussed and reached a consensus in the discussion thread [2]. The vote will be open until April 13nd (72h), unless there is an objection or not enough votes. Best, Danny Chan [1] https://cwiki.apache.org/confluence/display

[RESULT][VOTE] FLIP-113: Support dynamic table options for Flink SQL

2020-04-12 Thread Danny Chan
hanks everyone for joining the discussion and giving feedback! Best, Danny Chan

Re: [ANNOUNCE] New Apache Flink PMC Member - Hequn Chen

2020-04-17 Thread Danny Chan
Congratulations, Hequn, and thanks for your work for community ~ Best, Danny Chan 在 2020年4月17日 +0800 PM2:44,Becket Qin ,写道: > Hi all, > > I am glad to announce that Hequn Chen has joined the Flink PMC. > > Hequn has contributed to Flink for years. He has worked on several > co

Re: [DISCUSS] Exact feature freeze date

2020-04-23 Thread Danny Chan
+1 for extending the feature freeze until May 15th. Best, Danny Chan 在 2020年4月24日 +0800 AM9:51,Yangze Guo ,写道: > +1 > > Best, > Yangze Guo > > On Fri, Apr 24, 2020 at 9:49 AM Dian Fu wrote: > > > > +1 > > > > Regards, > > Dian > > > > &

Confluence permission for FLIP creation

2019-09-23 Thread Danny Chan
t would be nice if any of you can help on this. Best, Danny Chan

Re: [VOTE] FLIP-66: Support Time Attribute in SQL DDL (#2)

2019-09-26 Thread Danny Chan
+1, thanks for the effort, Jack ! Best, Danny Chan 在 2019年9月26日 +0800 AM11:52,Jark Wu ,写道: > Hi all, > > I would like to start the vote for FLIP-66 [1], which is discussed and > reached a consensus in the discussion thread[2]. > > The vote will be open for at least 72 hours. I&

Re: Confluence permission for FLIP creation

2019-09-28 Thread Danny Chan
Thanks so much jincheng, I have got the permission. Best, Danny Chan 在 2019年9月25日 +0800 AM9:33,jincheng sun ,写道: > I have given you edit permission, could you please re-login and check it. :) > > Danny Chan 于2019年9月24日周二 上午11:31写道: > > > Hi all, > > > > As commun

Re: [DISCUSS] FLIP-70 - Support Computed Column for Flink SQL

2019-10-25 Thread Danny Chan
were no comments in this thread so far, so I would assume there are no objections :) Best, Danny Chan 在 2019年10月24日 +0800 PM5:11,Kurt Young ,写道: > +1 to move to a future section. By deleting it I mean remove from > the content describing the current processing procedure. > > Best, >

[VOTE] FLIP-70: Flink SQL Computed Column Design

2019-10-27 Thread Danny Chan
https://cwiki.apache.org/confluence/display/FLINK/FLIP-70%3A+Flink+SQL+Computed+Column+Design [2]  http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-70-Support-Computed-Column-for-Flink-SQL-td33126.html Best, Danny Chan

Re: [ANNOUNCE] Becket Qin joins the Flink PMC

2019-10-29 Thread Danny Chan
Congratulations :) Best, Danny Chan 在 2019年10月29日 +0800 PM4:14,dev@flink.apache.org,写道: > > Congratulations :)

Re: [DISCUSS] Move flink-orc to flink-formats from flink-connectors

2019-10-29 Thread Danny Chan
+1 to move to flink-format. Best, Danny Chan 在 2019年10月29日 +0800 AM11:10,dev@flink.apache.org,写道: > > +1 to move to flink-format.

[RESULT][VOTE] FLIP-70: Flink SQL Computed Column Design

2019-10-31 Thread Danny Chan
nding) There were no disapproving votes. Thus, FLIP-70 has been accepted. Thanks everyone for joining the discussion and giving feedback! Best, Danny Chan

Re: [VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-08 Thread Danny Chan
+1(non-binding), nice job, Terry ~ Best, Danny Chan 在 2019年11月5日 +0800 PM10:32,dev@flink.apache.org,写道: > > +1 to the long missing feature in Flink SQL.

Re: [VOTE] FLIP-59: Enable execution configuration from Configuration object

2019-11-08 Thread Danny Chan
Thanks for driving on this, David. +1(non-binding) from my side, we really need this feature ! Best, Danny Chan 在 2019年11月7日 +0800 PM5:04,Dawid Wysakowicz ,写道: > Hello, > > please vote for FLIP-59 > <https://cwiki.apache.org/confluence/display/FLINK/FLIP-59%3A+Enable+executio

Re: [ANNOUNCE] Jark Wu is now part of the Flink PMC

2019-11-10 Thread Danny Chan
Congrats Jark! Well deserved ! Best, Danny Chan 在 2019年11月11日 +0800 AM9:59,dev@flink.apache.org,写道: > > Congrats Jark!

Re: [DISCUSS] Releasing Flink 1.8.3

2019-11-10 Thread Danny Chan
Thanks Hequn to be in change of the release ! Best, Danny Chan 在 2019年11月9日 +0800 PM3:59,Hequn Cheng ,写道: > Hi Jincheng, > > Thanks for kicking this discussion off! > > +1 to the 1.8.3 release as it would be nice to have these important fixes > and also two > months have

Re: FLIP 87: Primary key constraints in Table API

2019-11-24 Thread Danny Chan
Thanks for the work, Dawid, a big + 1 ! Best, Danny Chan 在 2019年11月22日 +0800 PM8:51,Dawid Wysakowicz ,写道: > Hi everyone, > > I would like to start a vote on FLIP-87. > > Please vote for the following design document: > > https://cwiki.apache.org/confluence/display/FLINK/F

Re: [VOTE] Release 1.8.3, release candidate #3

2019-12-09 Thread Danny Chan
Hi Hequn, +1 (non-binding) - verified checksums and hashes - built from local with MacOS 10.14 and JDK8 - do some check in the SQL-CLI - run some tests in IDE Best, Danny Chan 在 2019年12月5日 +0800 PM9:39,Hequn Cheng ,写道: > Hi everyone, > > Please review and vote on the release candida

Re: [ANNOUNCE] Feature freeze for Apache Flink 1.10.0 release

2019-12-10 Thread Danny Chan
Hi Yu & Gary, Thanks for your nice job ~ Best, Danny Chan 在 2019年11月19日 +0800 PM11:44,dev@flink.apache.org,写道: > > Hi Yu & Gary, > > Thanks a lot for your work and looking forward to the 1.10 release. :)

Re: [DISCUSS] Overwrite and partition inserting support in 1.10

2019-12-11 Thread Danny Chan
is resolved. Best, Danny Chan 在 2019年12月11日 +0800 PM5:29,Jingsong Li ,写道: > Hi Dev, > > After cutting out the branch of 1.10, I tried the following functions of > SQL-CLI and found that it does not support: > - insert overwrite > - PARTITION (partcol1=val1, partcol2=val2 ...) &g

Re: [ANNOUNCE] Zhu Zhu becomes a Flink committer

2019-12-15 Thread Danny Chan
Congrats Zhu Zhu! Best, Danny Chan 在 2019年12月14日 +0800 AM12:51,dev@flink.apache.org,写道: > > Congrats Zhu Zhu and welcome on board!

Re: [DISCUSS] have separate Flink distributions with built-in Hive dependencies

2019-12-15 Thread Danny Chan
flink-hive-version-uber.jar to use as a lib of SQL-CLI or other use cases. [1] https://spark.apache.org/downloads.html [2] https://www.elastic.co/guide/en/elasticsearch/hadoop/current/hive.html Best, Danny Chan 在 2019年12月14日 +0800 AM3:03,dev@flink.apache.org,写道: > > https://ci.apache.org/pro

Re: [DISCUSS] Correct the terminology of "Time-windowed Join" to "Interval Join" in Table API & SQL

2019-12-22 Thread Danny Chan
" ? [1] https://github.com/apache/flink/blob/cce1cef50d993aba5060ea5ac597174525ae895e/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java#L449 Best, Danny Chan 在 2019年12月23日 +0800 AM11:42,Jark Wu ,写道: > Hi everyone, > > Currently, in the Table A

Re: What is the suggested way to validate SQL?

2019-12-30 Thread Danny Chan
rcion But this would comes for Flink version 1.11 ~ Best, Danny Chan 在 2019年12月27日 +0800 PM5:44,dev@flink.apache.org,写道: > > "INSERT INTO > sinkTable SELECT f1,f2 FROM sourceTable"

Re: [ANNOUNCE] Progress of Apache Flink 1.10 #3

2020-01-02 Thread Danny Chan
Thanks for the great work ~ Best, Danny Chan 在 2020年1月2日 +0800 PM8:48,Yu Li ,写道: > Hi community, > > It has been three weeks since we cut the release-1.10 branch and kicked off > the release testing phase [1]. Thanks to all the efforts of the community, > 46 blocker and 11 cri

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

2020-01-07 Thread Danny Chan
Thanks Forward ~ I would help to view code from the Calcite side. Best, Danny Chan 在 2020年1月7日 +0800 PM2:01,Forward Xu ,写道: > Thanks Jark for checking the doc. hi,Timo, please help to check to see if > there is anything else to add. > > Best, > Forward > > Jark Wu

Re: [DISCUSS] FLIP-92: JDBC catalog and Postgres catalog

2020-01-09 Thread Danny Chan
fference-between-schema-database-in-mysql Best, Danny Chan 在 2020年1月10日 +0800 AM10:34,Jark Wu ,写道: > Thanks Bowen for the reply, > > A user-facing JDBCCatalog and 'catalog.type' = 'jdbc' sounds good to me. > > I have some other minor comments when I went through th

Re: [VOTE] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

2020-01-09 Thread Danny Chan
Thanks Forward ~ +1 from my side and would review your Calcite PR this weekend :) Overall it looks good, and I believe we can merge it soon ~ Best, Danny Chan 在 2020年1月10日 +0800 AM11:04,Jark Wu ,写道: > Thanks Forward for driving this, > > The design doc looks very good to me. > +1

Re: [VOTE] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

2020-01-14 Thread Danny Chan
+1 (non-binding) Best, Danny Chan 在 2019年12月31日 +0800 PM5:09,Forward Xu ,写道: > Hi all, > > I'd like to start the vote of FLIP-90 [1] since that we have reached an > agreement on the design in the discussion thread [2]. > > This vote will be open for at least 72 hours. Unles

Re: [ANNOUNCE] Yu Li became a Flink committer

2020-02-03 Thread Danny Chan
Congratulations Yu! Best, Danny Chan 在 2020年2月4日 +0800 AM1:46,dev@flink.apache.org,写道: > > Congratulations Yu!

Re: [VOTE] FLIP-27 - Refactor Source Interface

2020-02-03 Thread Danny Chan
+1 (non-binding), thanks for the great work ! Best, Danny Chan 在 2020年2月4日 +0800 AM11:20,dev@flink.apache.org,写道: > > +1 (non-binding), thanks for driving. > FLIP-27 is the basis of a lot of follow-up work.

Re: [DISCUSS] Remove registration of TableSource/TableSink in Table Env and ConnectTableDescriptor

2020-02-05 Thread Danny Chan
cannot be specified though properties, removing them force us to re-think the TableFactory/properties interface. Best, Danny Chan 在 2020年2月5日 +0800 PM3:58,Dawid Wysakowicz ,写道: > Hi Kurt, > > I fully agree with the proposal. Yes it was an omission that we did not > deprecate the Tabl

Re: [ANNOUNCE] Jincheng Sun is now part of the Flink PMC

2019-06-26 Thread Danny Chan
Congratulations Jincheng! Best, Danny Chan 在 2019年6月24日 +0800 PM11:09,dev@flink.apache.org,写道: > > Congratulations Jincheng!

Re: [DISCUSS] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-01 Thread Danny Chan
the DataStream API explicitly. In the SQL world, no projection function outputs type of time-attribute, we better still put the time-attributes in the scope of the table metadata. Best, Danny Chan 在 2020年8月19日 +0800 PM4:22,Timo Walther ,写道: > Hi everyone, > > I would like to propose a FLI

Re: [DISCUSS] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-02 Thread Danny Chan
thing from the API level, although I would not vote  `fromDataStream(DataStream, Expression…)` it is still better than `fromInsertStream(DataStream).select()`. Best, Danny Chan 在 2020年9月2日 +0800 PM4:19,Timo Walther ,写道: > Hi everyone > > thanks for your feedback. It's a lot of conte

Re: [DISCUSS] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-03 Thread Danny Chan
rnned internal row, if people did want a POJO there, how about we bind the DataType to the existing schema, like this toDataStream(table, schema.bindTo(DataType)) Best, Danny Chan 在 2020年9月3日 +0800 PM3:18,dev@flink.apache.org,写道: > > It is a more conservative approach to introduce that in a &

Re: [DISCUSS] FLIP-107: Reading table columns from different parts of source records

2020-09-07 Thread Danny Chan
cal value can be any java object. [1] https://oracle-base.com/articles/11g/virtual-columns-11gr1 [2] https://dev.mysql.com/doc/refman/5.7/en/create-table-generated-columns.html Best, Danny Chan 在 2020年9月4日 +0800 PM4:48,Timo Walther ,写道: > Hi everyone, > > I completely reworked FLIP-107. It

Re: [DISCUSS] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-08 Thread Danny Chan
What is the behavior if fromInsertStream() accepts a changelog stream ? "This means potentially duplicate definition of fields and their data types etc” I agree, because table already has an underlying schema there. Best, Danny Chan 在 2020年9月3日 +0800 PM8:12,Timo Walther ,写道: > Hi Danny,

Re: [DISCUSS] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-08 Thread Danny Chan
Thanks for the summary Timo ~ I want to clarify a little bit, what is the conclusion about the fromChangelogStream and toChangelogStream, should we use this name or we use fromDataStream with an optional ChangelogMode flag ? Best, Danny Chan 在 2020年9月8日 +0800 PM8:22,Timo Walther ,写道: >

Re: [DISCUSS] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-09 Thread Danny Chan
ChangelogMode is INSERT. Best, Danny Chan 在 2020年9月9日 +0800 PM2:53,dev@flink.apache.org,写道: > > But I think the planner needs to > know whether the input is insert-only or not.

Re: [DISCUSS] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-09 Thread Danny Chan
declare the ChangelogMode explicitly, and there are some confusions: • Should DataStream of Row type always use #fromChangelogStream ? • Does fromChangelogStream works for only INSERT ChangelogMode ? Best, Danny Chan 在 2020年9月9日 +0800 PM4:21,Timo Walther ,写道: > I had this in the inital design,

Re: [DISCUSS] FLIP-107: Reading table columns from different parts of source records

2020-09-09 Thread Danny Chan
> > and > > >>>>>>>> source.ts_ms have different semantics. I updated the FLIP and > > expose > > >>>> the > > >>>>>>>> most commonly used properties separately. So frequently used > > >>>> properties > > >>>>&g

Re: [DISCUSS] FLIP-107: Reading table columns from different parts of source records

2020-09-09 Thread Danny Chan
> > > Hi everyone, > > > > If we want to use "offset INT SYSTEM_METADATA("offset")", then I think we > > must further discuss about "PERSISED" or "VIRTUAL" keyword for query-sink > > schema problem. > > Personally, I think

Re: [DISCUSS] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-09 Thread Danny Chan
we can then continue to a > vote. > > Regards, > Timo > > > On 09.09.20 10:50, Danny Chan wrote: > > I think it would bring in much confusion by a different API name just > because the DataStream generic type is different. > > If there are ChangelogMode that only works

Re: [DISCUSS] FLIP-107: Reading table columns from different parts of source records

2020-09-10 Thread Danny Chan
Thanks for driving this Timo, +1 for voting ~ Best, Danny Chan 在 2020年9月10日 +0800 PM3:47,Timo Walther ,写道: > Thanks everyone for this healthy discussion. I updated the FLIP with the > outcome. I think the result is very powerful but also very easy to > declare. Thanks for all the cont

Re: [DISCUSS] FLIP-136: Improve interoperability between DataStream and Table API

2020-09-10 Thread Danny Chan
Thanks for driving this Timo, +1 for voting ~ Best, Danny Chan 在 2020年9月10日 +0800 PM3:54,Timo Walther ,写道: > Thanks everyone for this healthy discussion. I updated the FLIP with the > outcome. I think the result is one of the last core API refactoring and > users will be happy

Re: [VOTE] FLIP-107: Handling of metadata in SQL connectors

2020-09-12 Thread Danny Chan
+1, non-binding ~ Konstantin Knauf 于2020年9月11日 周五上午2:04写道: > +1 (binding) > > > > On Thu, Sep 10, 2020 at 4:29 PM Dawid Wysakowicz > > wrote: > > > > > +1 (binding) > > > > > > On 10/09/2020 14:03, Aljoscha Krettek wrote: > > > > +1 (binding) > > > > > > > > Aljoscha > > > > > > > > On 10.09.20

Re: [ANNOUNCE] New Apache Flink Committer - Niels Basjes

2020-09-14 Thread Danny Chan
Congratulations! 💐 Best, Danny Chan 在 2020年9月15日 +0800 AM9:31,dev@flink.apache.org,写道: > > Congratulations! 💐

Re: Re: [ANNOUNCE] New Apache Flink Committer - Godfrey He

2020-09-22 Thread Danny Chan
Congrats Godfrey! Well deserved! Best, Danny Chan 在 2020年9月21日 +0800 AM10:16,dev@flink.apache.org,写道: > > Congrats Godfrey! Well deserved!

Re: [ANNOUNCE] New PMC member: Zhu Zhu

2020-10-08 Thread Danny Chan
Congrats, Zhu Zhu ~ Best, Danny Chan 在 2020年10月9日 +0800 PM1:05,dev@flink.apache.org,写道: > > Congrats, Zhu Zhu

Re: [DISCUSS] FLIP-145: Support SQL windowing table-valued function

2020-10-09 Thread Danny Chan
suggest the window TVF as a normal UDTF, it can be chained with any kind of other non-windowed operators, we may need some time to give clear semantics for them (especially it is good if there are real use cases), as a start, let us focus the windowed operations first. I'm also +1 for

  1   2   >