Re: [DISCUSSION] FLIP-449: Reorganization of flink-connector-jdbc

Morning João, Recently we had a case where the JDBC drivers authentication was different than username&password authentication. For it to work, certain hacks required, there interface would have been helpful. But I agree maybe the interface module separation is not required at the moment.

Re: [VOTE] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

+1 (binding) Thanks for updating to a new version! Best, Stefan > On 6. May 2024, at 08:36, Hangxiang Yu wrote: > > +1（binding） > > On Mon, May 6, 2024 at 12:25 PM Yuan Mei > wrote: > >> +1（binding） >> >> Best >> Yuan >> >> On Mon, May 6, 2024 at 11:28 AM R

Re: Question around Flink's AdaptiveBatchScheduler

Hi, Thanks for the reminder. I will review it soon during my free time. Venkatakrishnan Sowrirajan 于2024年5月4日周六 10:10写道： > Jinrui and Xia > > Gentle ping for reviews. > > On Mon, Apr 29, 2024, 8:28 PM Venkatakrishnan Sowrirajan > > wrote: > > > Hi Xia and Jinrui, > > > > Filed https://github.co

Re: [DISCUSS] FLIP-451: Refactor Async sink API

Hey Ahmed, Thanks for the FLIP! +1 (non-binding) Additionally the current interface for passing fatal exceptions and retrying records relies on java consumers which makes it harder to understand. Could you please add more here why it is harder? Would the `completeExceptionally` method be r

Re: [VOTE] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

Thanks for your efforts! +1 (non-binding) Best, Muhammet On 2024-05-06 02:53, yue ma wrote: Hi everyone, Thanks for all the feedback, I'd like to start a vote on the FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0 [1]. The discussion thread is here [2]. The vote will be open for at least 7

[jira] [Created] (FLINK-35292) Set dummy savepoint path during last-state upgrade

Gyula Fora created FLINK-35292: -- Summary: Set dummy savepoint path during last-state upgrade Key: FLINK-35292 URL: https://issues.apache.org/jira/browse/FLINK-35292 Project: Flink Issue Type: Im

[jira] [Created] (FLINK-35293) FLIP-445: Support dynamic parallelism inference for HiveSource

xingbe created FLINK-35293: -- Summary: FLIP-445: Support dynamic parallelism inference for HiveSource Key: FLINK-35293 URL: https://issues.apache.org/jira/browse/FLINK-35293 Project: Flink Issue Typ

Re: [VOTE] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

+1 (binding) Best Yun Tang From: Muhammet Orazov Sent: Monday, May 6, 2024 15:50 To: dev@flink.apache.org Cc: yue ma Subject: Re: [VOTE] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0 Thanks for your efforts! +1 (non-binding) Best, Muhammet On 2024-05-06 02

Re: [VOTE] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

+1 (binding) This will be a good addition. G On Mon, May 6, 2024 at 4:54 AM yue ma wrote: > Hi everyone, > > Thanks for all the feedback, I'd like to start a vote on the FLIP-447: > Upgrade FRocksDB from 6.20.3 to 8.10.0 [1]. The discussion thread is here > [2]. > > The vote will be open for

[jira] [Created] (FLINK-35294) Use source config to check if the filter should be applied in timestamp starting mode

Xiao Huang created FLINK-35294: -- Summary: Use source config to check if the filter should be applied in timestamp starting mode Key: FLINK-35294 URL: https://issues.apache.org/jira/browse/FLINK-35294 Pro

Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

+1 from my side, thanks Martijn for the effort. Best, Leonard > 2024年5月4日 下午7:41，Ahmed Hamdy 写道： > > Hi Martijn > Thanks for the proposal +1 from me. > Should this change take place in 1.20, what are the planned release steps > for connectors that only offer a deprecated interface in this case

[jira] [Created] (FLINK-35295) Improve jdbc connection pool initialization failure message

Xiao Huang created FLINK-35295: -- Summary: Improve jdbc connection pool initialization failure message Key: FLINK-35295 URL: https://issues.apache.org/jira/browse/FLINK-35295 Project: Flink Issu

[jira] [Created] (FLINK-35296) Flink mysql-cdc connector stops reading data

Gang Yang created FLINK-35296: - Summary: Flink mysql-cdc connector stops reading data Key: FLINK-35296 URL: https://issues.apache.org/jira/browse/FLINK-35296 Project: Flink Issue Type: Bug

Re: [VOTE] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

+1 (non-binding) Best, Regards. Yuepeng Pan Replied Message | From | Rui Fan<1996fan...@gmail.com> | | Date | 05/06/2024 11:28 | | To | dev | | Subject | Re: [VOTE] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0 | +1 (binding) Best, Rui On Mon, May 6, 2024 at 11:01 AM Yanfei Lei w

Re: [VOTE] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

+1 (non-binding) Best, Zhongqiang Gong yue ma 于2024年5月6日周一 10:54写道： > Hi everyone, > > Thanks for all the feedback, I'd like to start a vote on the FLIP-447: > Upgrade FRocksDB from 6.20.3 to 8.10.0 [1]. The discussion thread is here > [2]. > > The vote will be open for at least 72 hours unless

Re: [DISCUSS] FLIP-443: Interruptible watermark processing

Hi Zakelly, Can you elaborate a bit more on what you have in mind? How marking mails as interruptible helps with something? If an incoming async state access response comes, it could just request to interrupt any currently ongoing computations, regardless the currently executed mail is or is not i

Re: [DISCUSS] FLIP-443: Interruptible watermark processing

Hi Piotr, I'm saying the scenario where things happen in the following order: 1. advance watermark and process timers. 2. the cp arrives and interrupts the timer processing, after this the continuation mail is in the mailbox queue. 3. `snapshotState` is called, where the async state access respons

[jira] [Created] (FLINK-35297) Add validation for option connect.timeout

Xiao Huang created FLINK-35297: -- Summary: Add validation for option connect.timeout Key: FLINK-35297 URL: https://issues.apache.org/jira/browse/FLINK-35297 Project: Flink Issue Type: Improvement

Re: [VOTE] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

+1 (binding) Regards, Roman On Mon, May 6, 2024 at 11:56 AM gongzhongqiang wrote: > +1 (non-binding) > > Best, > Zhongqiang Gong > > yue ma 于2024年5月6日周一 10:54写道： > > > Hi everyone, > > > > Thanks for all the feedback, I'd like to start a vote on the FLIP-447: > > Upgrade FRocksDB from 6.20.3

Re: [DISCUSS] FLIP-444: Native file copy support

Hi All! Thanks for your comments. Muhammet and Hong, about the config options. > Could you please also add the configuration property for this? An example showing how users would set this parameter would be helpful. > 1/ Configure the implementation of PathsCopyingFileSystem used > 2/ Configure

Re: [DISCUSS] FLIP-444: Native file copy support

Hi Piotrek, Thanks for your answers! Good question. The intention and use case behind `DuplicatingFileSystem` is > different. It marks if `FileSystem` can quickly copy/duplicate files > in the remote `FileSystem`. For example an equivalent of a hard link or > bumping a reference count in the remo

[jira] [Created] (FLINK-35298) Improve metric reporter logic

Xiao Huang created FLINK-35298: -- Summary: Improve metric reporter logic Key: FLINK-35298 URL: https://issues.apache.org/jira/browse/FLINK-35298 Project: Flink Issue Type: Improvement

Re: [VOTE] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

+1 (binding) Piotrek pon., 6 maj 2024 o 12:35 Roman Khachatryan napisał(a): > +1 (binding) > > Regards, > Roman > > > On Mon, May 6, 2024 at 11:56 AM gongzhongqiang > wrote: > > > +1 (non-binding) > > > > Best, > > Zhongqiang Gong > > > > yue ma 于2024年5月6日周一 10:54写道： > > > > > Hi everyone, >

Re:[DISCUSS] FLIP-448: Introduce Pluggable Workflow Scheduler Interface for Materialized Table

Hi, Ron. Thanks for driving this. After reading the entire flip, I have the following questions: 1. In the sequence diagram, it appears that there is a missing step for obtaining the refresh handler from the catalog during the suspend operation. 2. The term "cascade refresh" does not see

Re: [DISCUSS] FLIP-448: Introduce Pluggable Workflow Scheduler Interface for Materialized Table

Hi, Xuyang Thanks for joining this discussion > 1. In the sequence diagram, it appears that there is a missing step for obtaining the refresh handler from the catalog during the suspend operation. Good catch > 2. The term "cascade refresh" does not seem to be mentioned in FLIP-435. The workflow

Re: [DISCUSS] FLIP-451: Refactor Async sink API

Hi Muhammet, Thanks for the feedback. > Could you please add more here why it is harder? Would the > `completeExceptionally` > method be related to it? Maybe you can add usage example for it also. > this is mainly due to the current implementation of fatal exception failures which depends on base

[jira] [Created] (FLINK-35299) FlinkKinesisConsumer does not respect StreamInitialPosition for new Kinesis Stream when restoring from snapshot

Hong Liang Teoh created FLINK-35299: --- Summary: FlinkKinesisConsumer does not respect StreamInitialPosition for new Kinesis Stream when restoring from snapshot Key: FLINK-35299 URL: https://issues.apache.org/jira

Re: [DISCUSSION] FLIP-449: Reorganization of flink-connector-jdbc

Hi Muhammet, Have you had a chance to review the recently merged pull request [1]? We've introduced a new feature allowing users to include ad hoc configurations in the 'JdbcConnectionOptions' class. ``` new JdbcConnectionOptions.JdbcConnectionOptionsBuilder() .withUrl(F

Re: [DISCUSSION] FLIP-449: Reorganization of flink-connector-jdbc

Hi Jeyhun, > > I would also ask to include a sample usage and changes for end-users in the > > FLIP. We want to ensure a seamless transition for end-users, minimizing any disruptions in their current usage of the connector. To achieve this, we will uphold consistency by maintaining the same int

Re: [Discuss] FLIP-452: Allow Skipping Invocation of Function Calls While Constant-folding

Hi Alan, thanks for the update. From my side, the FLIP seems good for voting. Since it only touches a small API surface, I guess the proposal is not very controversial. Feel free to start a vote thread by tomorrow. If there are no objections? Thanks, Timo On 02.05.24 09:45, Muhammet Orazov

Re: [Discuss] FLIP-452: Allow Skipping Invocation of Function Calls While Constant-folding

Hi Muhammet, Timo The `isDeterministic()`[1] function is mentioned in the documentation, > I would suggest to add maybe a section for `supportsConstantFolding()`, > with short description and examples use cases (similar to the > motivation of the FLIP) where this could be useful in UDFs. > Thanks

Re: [Discuss] FLIP-452: Allow Skipping Invocation of Function Calls While Constant-folding

Thanks Alan for starting this flip! +1 for the new `supportsConstantFolding`. We do need to reserve the ability to not perform constant folding for certain cases. Best, Lincoln Lee Alan Sheinberg 于2024年5月7日周二 08:32写道： > Hi Muhammet, Timo > > The `isDeterministic()`[1] function is mentioned in

[jira] [Created] (FLINK-35300) Improve MySqlStreamingChangeEventSource to skip null events in event deserializer

Xiao Huang created FLINK-35300: -- Summary: Improve MySqlStreamingChangeEventSource to skip null events in event deserializer Key: FLINK-35300 URL: https://issues.apache.org/jira/browse/FLINK-35300 Project

[jira] [Created] (FLINK-35301) Fix deadlock when loading driver classes

Xiao Huang created FLINK-35301: -- Summary: Fix deadlock when loading driver classes Key: FLINK-35301 URL: https://issues.apache.org/jira/browse/FLINK-35301 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-35302) Flink REST server throws exception on unknown fields in RequestBody

Juntao Hu created FLINK-35302: - Summary: Flink REST server throws exception on unknown fields in RequestBody Key: FLINK-35302 URL: https://issues.apache.org/jira/browse/FLINK-35302 Project: Flink

Re: [VOTE] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

+1 (no-binding) Piotr Nowojski 于2024年5月6日周一 20:17写道： > +1 (binding) > > Piotrek > > pon., 6 maj 2024 o 12:35 Roman Khachatryan napisał(a): > > > +1 (binding) > > > > Regards, > > Roman > > > > > > On Mon, May 6, 2024 at 11:56 AM gongzhongqiang < > gongzhongqi...@apache.org> > > wrote: > > > > >

Re: [DISCUSS] FLIP-448: Introduce Pluggable Workflow Scheduler Interface for Materialized Table

> 4. It appears that in the section on `public interfaces`, within `WorkflowOperation`, `CreatePeriodicWorkflowOperation` should be changed to `CreateWorkflowOperation`, right? After discussing with Xuyang offline, we need to support periodic workflow and one-time workflow, they need different in

[DISCUSSION] FLIP-456: CompiledPlan support for Batch Execution Mode

Hi everyone, PTAL at the proposed FLIP-456: CompiledPlan support for Batch Execution Mode. It is pretty self-describing. Any thoughts are welcome! Thanks, Alexey [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-456%3A+CompiledPlan+support+for+Batch+Execution+Mode .