Re: [DISCUSS] FLIP 295: Support persistence of Catalog configuration and asynchronous registration

2023-06-04 Thread Feng Jin
Hi Samrat, Thanks for your advice. > 1. The createCatalog method does not mention any exceptions being thrown. CreateCatalog will throw CatalogException like registerCatalog. As CatalogException is a RuntimeException, there is no explicit declaration of throwing Exceptions in CatalogManager and

[jira] [Created] (FLINK-32249) A Java string should be used instead of a Calcite NlsString to construct the table and column comment attributes of CatalogTable

2023-06-04 Thread lincoln lee (Jira)
lincoln lee created FLINK-32249: --- Summary: A Java string should be used instead of a Calcite NlsString to construct the table and column comment attributes of CatalogTable Key: FLINK-32249 URL: https://issues.apache

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-04 Thread yuxia
Hi, Jane. Thanks for you input. I think we can add the auxiliary command show procedures in this FLIP. Following the syntax for show functions proposed in FLIP-297. The syntax will be SHOW PROCEDURES [ ( FROM | IN ) [catalog_name.]database_name ] [ [NOT] (LIKE | ILIKE) ]. I have updated to this

Re: [DISCUSS] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-06-04 Thread liu ron
Hi, Jark Thanks for your feedback, according to my initial assessment, the work effort is relatively large. Moreover, I will add a test result of all queries to the FLIP. Best, Ron Jark Wu 于2023年6月1日周四 20:45写道: > Hi Ron, > > Thanks a lot for the great proposal. The FLIP looks good to me in ge

Re: [DISCUSS] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-06-04 Thread Lincoln Lee
Hi Ron OFGC looks like an exciting optimization, looking forward to its completion in Flink! A small question, do we consider adding a benchmark for the operators to intuitively understand the improvement brought by each improvement? In addition, for the implementation plan, mentioned in the FLIP

Re: [DISCUSS] FLIP-313 Add support of User Defined AsyncTableFunction

2023-06-04 Thread Aitozi
Hi Jing, > what is the difference between the RPC call or query you mentioned and the lookup in a very general way I think the RPC call or query service is quite similar to the lookup join. But lookup join should work with `LookupTableSource`. Let's see how we can perform an async RPC call w

[jira] [Created] (FLINK-32250) Revert the Field name of BUFFER_TIMEOUT to improve compatibility

2023-06-04 Thread Rui Fan (Jira)
Rui Fan created FLINK-32250: --- Summary: Revert the Field name of BUFFER_TIMEOUT to improve compatibility Key: FLINK-32250 URL: https://issues.apache.org/jira/browse/FLINK-32250 Project: Flink Issue

Re: [DISCUSS] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-06-04 Thread Yun Tang
Hi Ron, I think this FLIP would help to improve the performance, looking forward to its completion in Flink! For the state compatibility session, it seems that the checkpoint compatibility would be broken just like [1] did. Could FLIP-190 [2] still be helpful in this case for SQL version upgra

Re: [DISCUSS] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-06-04 Thread Jingsong Li
> For the state compatibility session, it seems that the checkpoint > compatibility would be broken just like [1] did. Could FLIP-190 [2] still be > helpful in this case for SQL version upgrades? I guess this is only for batch processing. Streaming should be another story? Best, Jingsong On Mo

[jira] [Created] (FLINK-32251) flink jdbc catalog cannot add parameters to url

2023-06-04 Thread melin (Jira)
melin created FLINK-32251: - Summary: flink jdbc catalog cannot add parameters to url Key: FLINK-32251 URL: https://issues.apache.org/jira/browse/FLINK-32251 Project: Flink Issue Type: New Feature

Re: [DISCUSS] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-06-04 Thread Benchao Li
Thanks Ron for initiating this discussion, the OFGC sounds a cool optimization. I also agree with above comments about the benchmark result, it is important for performance improvements. And I thing Yun and Jingsong has raised a very interesting topic about the support for streaming. It's worth m