Re: [DISCUSS] Deprecate deserialize method in DeserializationSchema

2023-02-28 Thread Jingsong Li
- `T deserialize(byte[] message)` is widely used and it is a public api. It is very friendly for single record deserializers. - `void deserialize(byte[] message, Collector out)` supports multiple records. I think we can just keep them as they are. Best, Jingsong On Tue, Feb 28, 2023 at 3:08 PM

Re: [VOTE] Flink minor version support policy for old releases

2023-02-28 Thread Junrui Lee
Thanks Danny for driving it. +1 (non-binding) Best regards, Junrui yuxia 于2023年2月28日周二 14:04写道: > Thanks Danny for driving it. > > +1 (non-binding) > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Weihua Hu" > 收件人: "dev" > 发送时间: 星期二, 2023年 2 月 28日 下午 12:48:09 > 主题: Re: [VOTE] Flink min

[jira] [Created] (FLINK-31255) OperatorUtils#createWrappedOperatorConfig fails to wrap operator config

2023-02-28 Thread Zhipeng Zhang (Jira)
Zhipeng Zhang created FLINK-31255: - Summary: OperatorUtils#createWrappedOperatorConfig fails to wrap operator config Key: FLINK-31255 URL: https://issues.apache.org/jira/browse/FLINK-31255 Project: Fl

Re: [DISCUSS] FLIP-291: Externalized Declarative Resource Management

2023-02-28 Thread David Morávek
Hi Everyone, We had some more talks about the pre-allocation of resources with @Max, and here is the final state that we've converged to for now: The vital thing to note about the new API is that it's declarative, meaning we're declaring the desired state to which we want our job to converge; If,

Re: [VOTE] Flink minor version support policy for old releases

2023-02-28 Thread Samrat Deb
+1 (non binding) Thanks for driving it Bests, Samrat On Tue, 28 Feb 2023 at 1:36 PM, Junrui Lee wrote: > Thanks Danny for driving it. > > +1 (non-binding) > > Best regards, > Junrui > > yuxia 于2023年2月28日周二 14:04写道: > > > Thanks Danny for driving it. > > > > +1 (non-binding) > > > > Best regar

Re: [DISCUSS] Deprecate deserialize method in DeserializationSchema

2023-02-28 Thread Benchao Li
I share the same concerns with Jingsong and Hang, however, I'll raise a point why keeping both is also not a good idea. In FLINK-18590[1], we are introducing a feature that we'll deserialize JSON array into multiple records. This feature can only be used in `void deserialize(byte[] message, Collec

[jira] [Created] (FLINK-31256) FLIP-297: Improve Auxiliary Sql Statements

2023-02-28 Thread Ran Tao (Jira)
Ran Tao created FLINK-31256: --- Summary: FLIP-297: Improve Auxiliary Sql Statements Key: FLINK-31256 URL: https://issues.apache.org/jira/browse/FLINK-31256 Project: Flink Issue Type: Improvement

Re: [VOTE] Release 1.15.4, release candidate #1

2023-02-28 Thread Teoh, Hong
Thanks Danny for driving this +1 (non-binding) * Hashes and Signatures look good * All required files on dist.apache.org * Source archive builds using maven * Started packaged example WordCountSQLExample job * Web PR looks good. Cheers, Hong > On 24 Feb 2023, at 05:36, Weihua Hu wrote: >

[SUMMARY] Flink 1.17 Release Sync 2/28/2023

2023-02-28 Thread Qingsheng Ren
Hi devs and users, I'd like to share some highlights from Flink 1.17 release sync on 2/28/2023. Release testing: - All release testing tasks have finished in the last week. Big thanks to our contributors and volunteers for the effort on this! 1.17 Blockers: There are 2 blockers currently: FLINK-

Re: [DISCUSS] FLIP-297: Improve Auxiliary Sql Statements

2023-02-28 Thread Jark Wu
Hi Ran, Could you add descriptions about what’s the behavior and differences between the LIKE and ILIKE? Besides, I don’t see the SHOW CONNECTOR syntax and description and how it works in the FLIP. Is it intended to be included in this FLIP? Best, Jark > 2023年2月28日 10:58,Ran Tao 写道: > >

Re: [DISCUSS] Deprecate deserialize method in DeserializationSchema

2023-02-28 Thread Jing Ge
Hi, I have to agree with what Huang and Jingsong said. We should think more about it from the user's(developers who use the API) perspective. The first method T deserialize(byte[]) is convenient for users to deserialize a single event. Many formats are using it, i.e. Avro, csv, etc. There should a

Re: [DISCUSS] FLIP-297: Improve Auxiliary Sql Statements

2023-02-28 Thread Jark Wu
Besides, if we introduce the ILIKE, we should also add this feature for the previous SHOW with LIKE statements. They should be included in this FLIP. Best, Jark > 2023年2月28日 17:40,Jark Wu 写道: > > Hi Ran, > > Could you add descriptions about what’s the behavior and differences between > the L

Re: [DISCUSS] FLIP-297: Improve Auxiliary Sql Statements

2023-02-28 Thread Ran Tao
Hi, Jark. thanks. > About ILIKE I have updated the FLIP for ILIKE support (Including existing showTables & showColumns how to change). > About show connectors @Sergey, Currently I think we can load from the jar and check the services file to get the connector type. but is it necessary we may conti

Re: [DISCUSS] FLIP-297: Improve Auxiliary Sql Statements

2023-02-28 Thread Sergey Nuyanzin
>>Currently I think we can load from the jar and check the services file to >> get the connector type. but is it necessary we may continue to discuss. >>Hi, Sergey, WDYT? Another idea is FactoryUtil#discoverFactories and check if it implements DynamicTableSourceFactory or DynamicTableSinkFactory w

Re: [DISCUSS] FLIP-297: Improve Auxiliary Sql Statements

2023-02-28 Thread Ran Tao
thanks Sergey, sounds good. You can add in FLIP ticket[1]. [1] https://issues.apache.org/jira/browse/FLINK-31256 Best Regards, Ran Tao https://github.com/chucheng92 Sergey Nuyanzin 于2023年2月28日周二 19:44写道: > >>Currently I think we can load from the jar and check the services file to > >> get th

Re: [VOTE] Flink minor version support policy for old releases

2023-02-28 Thread Sergey Nuyanzin
+1 (non-binding) Thanks for driving this Danny. On Tue, Feb 28, 2023 at 9:41 AM Samrat Deb wrote: > +1 (non binding) > > Thanks for driving it > > Bests, > Samrat > > On Tue, 28 Feb 2023 at 1:36 PM, Junrui Lee wrote: > > > Thanks Danny for driving it. > > > > +1 (non-binding) > > > > Best rega

Re: [DISCUSS] FLIP-291: Externalized Declarative Resource Management

2023-02-28 Thread Maximilian Michels
Hi David, Thanks for the update! We consider using the new declarative resource API for autoscaling. Currently, we treat a scaling decision as a new deployment which means surrendering all resources to Kubernetes and subsequently reallocating them for the rescaled deployment. The declarative resou

[jira] [Created] (FLINK-31257) Fix errors in “CSV Formats" page

2023-02-28 Thread ZhengYi Weng (Jira)
ZhengYi Weng created FLINK-31257: Summary: Fix errors in “CSV Formats" page Key: FLINK-31257 URL: https://issues.apache.org/jira/browse/FLINK-31257 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-31258) can not get kerberos keytab in flink operator

2023-02-28 Thread Jun Zhang (Jira)
Jun Zhang created FLINK-31258: - Summary: can not get kerberos keytab in flink operator Key: FLINK-31258 URL: https://issues.apache.org/jira/browse/FLINK-31258 Project: Flink Issue Type: Bug

Re: [DISCUSS] FLIP-291: Externalized Declarative Resource Management

2023-02-28 Thread Roman Khachatryan
Hi, Thanks for the update, I think distinguishing the rescaling behaviour and the desired parallelism declaration is important. Having the ability to specify min parallelism might be useful in environments with multiple jobs: Scheduler will then have an option to stop the less suitable job. In ot

[jira] [Created] (FLINK-31259) Gateway supports initialization of catalog at startup

2023-02-28 Thread Shammon (Jira)
Shammon created FLINK-31259: --- Summary: Gateway supports initialization of catalog at startup Key: FLINK-31259 URL: https://issues.apache.org/jira/browse/FLINK-31259 Project: Flink Issue Type: Impro

Re: [DISCUSS] FLIP-291: Externalized Declarative Resource Management

2023-02-28 Thread David Morávek
> I suppose we could further remove the min because it would always be safer to scale down if resources are not available than not to run at all [1]. Apart from what @Roman has already mentioned, there are still cases where we're certain that there is no point in running the jobs with resources lo

[jira] [Created] (FLINK-31260) PushLocalHashAggIntoScanRule should also work with union RelNode

2023-02-28 Thread Aitozi (Jira)
Aitozi created FLINK-31260: -- Summary: PushLocalHashAggIntoScanRule should also work with union RelNode Key: FLINK-31260 URL: https://issues.apache.org/jira/browse/FLINK-31260 Project: Flink Issue T

[jira] [Created] (FLINK-31261) Make AdaptiveScheduler aware of the (local) state size

2023-02-28 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-31261: - Summary: Make AdaptiveScheduler aware of the (local) state size Key: FLINK-31261 URL: https://issues.apache.org/jira/browse/FLINK-31261 Project: Flink

Re: [DISCUSS] FLIP-298: Unifying the Implementation of SlotManager

2023-02-28 Thread Matthias Pohl
Hi Weihua, Thanks for your proposal. From a conceptual point: AFAIU, the DeclarativeSlotManager covers a subset (i.e. only evenly sized slots) of what the FineGrainedSlotManager should be able to achieve (variable slot size per task manager). Is this the right assumption/understanding? In this sens

Re: [DISCUSS] FLIP-291: Externalized Declarative Resource Management

2023-02-28 Thread Maximilian Michels
I agree that it is useful to have a configurable lower bound. Thanks for looking into it as part of a follow up! No objections from my side to move forward with the vote. -Max On Tue, Feb 28, 2023 at 1:36 PM David Morávek wrote: > > > I suppose we could further remove the min because it would a

[VOTE] FLIP-291: Externalized Declarative Resource Management

2023-02-28 Thread David Morávek
Hi Everyone, I want to start the vote on FLIP-291: Externalized Declarative Resource Management [1]. The FLIP was discussed in this thread [2]. The goal of the FLIP is to enable external declaration of the resource requirements of a running job. The vote will last for at least 72 hours (Friday,

Re: [DISCUSS] FLIP-291: Externalized Declarative Resource Management

2023-02-28 Thread John Roesler
Thanks for the answer, David! It sounds like there is a race condition, but it’s a known issue not specific to this FLIP, and the failure case isn’t too bad. I’m satisfied with that. Thanks, John On Thu, Feb 23, 2023, at 10:39, David Morávek wrote: > Hi Everyone, > > @John > > This is a problem

Re: [VOTE] FLIP-291: Externalized Declarative Resource Management

2023-02-28 Thread John Roesler
Thanks for the FLIP, David! I’m +1 (non-binding) -John On Tue, Feb 28, 2023, at 07:46, David Morávek wrote: > Hi Everyone, > > I want to start the vote on FLIP-291: Externalized Declarative Resource > Management [1]. The FLIP was discussed in this thread [2]. > > The goal of the FLIP is to enabl

Re: [VOTE] Release 1.15.4, release candidate #1

2023-02-28 Thread Matthias Pohl
Thanks Danny. +1 (non-binding) * Downloaded artifacts * Built Flink from sources * Verified SHA512 checksums GPG signatures * Compared checkout with provided sources * Verified pom file versions * Went over NOTICE file/pom files changes without finding anything suspicious * Deployed standalone se

Re: Contributing a Google Cloud Pub/Sub Lite source and sink?

2023-02-28 Thread Daniel Collins
Hello, Absent any comments, I was attempting to create a connector FLIP as described above, however it appears that I do not have permissions to edit confluence to do so. Can someone please add access for me? -Daniel On Mon, Feb 27, 2023 at 10:28 AM Daniel Collins wrote: > Hello Martijn, > > T

Re: [DISCUSS] FLIP-298: Unifying the Implementation of SlotManager

2023-02-28 Thread John Roesler
Thanks for the FLIP, Weihua! I’ve read the FLIP, and it sounds good to me. We need to avoid proliferating alternative implementations wherever possible. I have just a couple of comments: 1. I share Matthias’s concern about ensuring the behavior is really the same. One suggestion I’ve used for t

Re: [DISCUSS] FLIP-297: Improve Auxiliary Sql Statements

2023-02-28 Thread Timo Walther
Hi Ran Tao, Thanks for working on this FLIP. The FLIP is in a pretty good shape already and I don't have much to add. Will we also support ILIKE in queries? Or is this a pure DDL expressions? For consistency, we should support it in SELECT and Table API as well. I hope this is not too much e

Re: Contributing a Google Cloud Pub/Sub Lite source and sink?

2023-02-28 Thread Martijn Visser
Hi Daniel, If you can provide your Jira username, those permissions can be granted. Best regards, Martijn On Tue, Feb 28, 2023 at 3:13 PM Daniel Collins wrote: > Hello, > > Absent any comments, I was attempting to create a connector FLIP as > described above, however it appears that I do not

Re: Contributing a Google Cloud Pub/Sub Lite source and sink?

2023-02-28 Thread Daniel Collins
Thanks! My Jira username is `dpcollins-google`. -Daniel On Tue, Feb 28, 2023 at 10:19 AM Martijn Visser wrote: > Hi Daniel, > > If you can provide your Jira username, those permissions can be granted. > > Best regards, > > Martijn > > On Tue, Feb 28, 2023 at 3:13 PM Daniel Collins > > wrote: >

Re: [DISCUSS] FLIP-287: Extend Sink#InitContext to expose ExecutionConfig and JobID

2023-02-28 Thread João Boto
I have update the FLIP with the 2 options that we have discussed.. Option 1: Expose ExecutionConfig directly on InitContext this have a minimal impact as we only have to expose the new methods Option 2: Expose ReadableExecutionConfig on InitContext with this option we have more impact as we need

[jira] [Created] (FLINK-31262) Add sql connector fat jar test to SmokeKafkaITCase

2023-02-28 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-31262: -- Summary: Add sql connector fat jar test to SmokeKafkaITCase Key: FLINK-31262 URL: https://issues.apache.org/jira/browse/FLINK-31262 Project: Flink Issue Type: Su

Re: [VOTE] Release 1.15.4, release candidate #1

2023-02-28 Thread Jing Ge
Thanks Danny, +1 (non-binding) - GPG signatures looks good - checked dist and maven repo - maven clean install from source - checked version consistency in pom files - went through the web release notes and found one task is still open: FLINK-31133 [1] - download artifacts - started/stoppe

[jira] [Created] (FLINK-31263) Add smoke test for ElasticSearch connector

2023-02-28 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-31263: -- Summary: Add smoke test for ElasticSearch connector Key: FLINK-31263 URL: https://issues.apache.org/jira/browse/FLINK-31263 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-31264) Add smoke test for HBase connector

2023-02-28 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-31264: -- Summary: Add smoke test for HBase connector Key: FLINK-31264 URL: https://issues.apache.org/jira/browse/FLINK-31264 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-31265) Add smoke test for Pulsar connector

2023-02-28 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-31265: -- Summary: Add smoke test for Pulsar connector Key: FLINK-31265 URL: https://issues.apache.org/jira/browse/FLINK-31265 Project: Flink Issue Type: Sub-task

Re: [VOTE] Release 1.15.4, release candidate #1

2023-02-28 Thread Ahmed Hamdy
Thanks Danny, +1 (non-binding) - Verified hashes and signatures - Built Source archive using maven - Web PR looks good. - Started WordCount Example On Tue, 28 Feb 2023 at 16:37, Jing Ge wrote: > Thanks Danny, > > +1 (non-binding) > > - GPG signatures looks good > - checked dist and maven rep

Re: [VOTE] FLIP-291: Externalized Declarative Resource Management

2023-02-28 Thread Konstantin Knauf
+1 (binding) Am Di., 28. Feb. 2023 um 15:02 Uhr schrieb John Roesler : > Thanks for the FLIP, David! > > I’m +1 (non-binding) > > -John > > On Tue, Feb 28, 2023, at 07:46, David Morávek wrote: > > Hi Everyone, > > > > I want to start the vote on FLIP-291: Externalized Declarative Resource > > Man

[jira] [Created] (FLINK-31266) dashboard info error (received and send alway show 0 when having data)

2023-02-28 Thread linqichen (Jira)
linqichen created FLINK-31266: - Summary: dashboard info error (received and send alway show 0 when having data) Key: FLINK-31266 URL: https://issues.apache.org/jira/browse/FLINK-31266 Project: Flink

Re: [VOTE] FLIP-291: Externalized Declarative Resource Management

2023-02-28 Thread Zhanghao Chen
Thanks for driving this. +1 (non-binding) Best, Zhanghao Chen From: David Mor?vek Sent: Tuesday, February 28, 2023 21:46 To: dev Subject: [VOTE] FLIP-291: Externalized Declarative Resource Management Hi Everyone, I want to start the vote on FLIP-291: Externaliz

Re: [VOTE] FLIP-291: Externalized Declarative Resource Management

2023-02-28 Thread ConradJam
+1 (non-binding) Zhanghao Chen 于2023年3月1日周三 10:18写道: > Thanks for driving this. +1 (non-binding) > > Best, > Zhanghao Chen > > From: David Mor?vek > Sent: Tuesday, February 28, 2023 21:46 > To: dev > Subject: [VOTE] FLIP-291: Externalized Declarative Resource

Re: [VOTE] FLIP-291: Externalized Declarative Resource Management

2023-02-28 Thread feng xiangyu
+1 (non-binding) ConradJam 于2023年3月1日周三 10:37写道: > +1 (non-binding) > > Zhanghao Chen 于2023年3月1日周三 10:18写道: > > > Thanks for driving this. +1 (non-binding) > > > > Best, > > Zhanghao Chen > > > > From: David Mor?vek > > Sent: Tuesday, February 28, 2023 21:46

Re: [DISCUSS] FLIP-298: Unifying the Implementation of SlotManager

2023-02-28 Thread Shammon FY
Hi Thanks for starting this work weihua, I think unifying DeclarativeSlotManager and FineGrainedSlotManager is valuable. I agree with @Matthias and @John that we need a way to ensure that DeclarativeSlotManager's capabilities are fully covered by FineGrainedSlotManager 1. For their functional di

[jira] [Created] (FLINK-31267) Fine-Grained Resource Management supports table and sql levels

2023-02-28 Thread waywtdcc (Jira)
waywtdcc created FLINK-31267: Summary: Fine-Grained Resource Management supports table and sql levels Key: FLINK-31267 URL: https://issues.apache.org/jira/browse/FLINK-31267 Project: Flink Issue

[jira] [Created] (FLINK-31268) OperatorCoordinator.Context#metricGroup will return null when restore from a savepoint

2023-02-28 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-31268: - Summary: OperatorCoordinator.Context#metricGroup will return null when restore from a savepoint Key: FLINK-31268 URL: https://issues.apache.org/jira/browse/FLINK-31268 Proj

[jira] [Created] (FLINK-31269) Split hive connector to each module of each version

2023-02-28 Thread Shammon (Jira)
Shammon created FLINK-31269: --- Summary: Split hive connector to each module of each version Key: FLINK-31269 URL: https://issues.apache.org/jira/browse/FLINK-31269 Project: Flink Issue Type: Improve

[jira] [Created] (FLINK-31270) Fix flink jar name in docs for table store

2023-02-28 Thread Shammon (Jira)
Shammon created FLINK-31270: --- Summary: Fix flink jar name in docs for table store Key: FLINK-31270 URL: https://issues.apache.org/jira/browse/FLINK-31270 Project: Flink Issue Type: Bug Co

Re: [DISCUSS] FLIP-298: Unifying the Implementation of SlotManager

2023-02-28 Thread Xintong Song
Thanks Weihua for preparing this FLIP. +1 for the proposal. As one of the contributors of the fine-grained slot manager, I'd like to share some backgrounds here. - There used to be a defaut slot manager implementation, which is non-declarative and has been removed now. The two features, declarat

[jira] [Created] (FLINK-31271) Introduce system database for catalog in table store

2023-02-28 Thread Shammon (Jira)
Shammon created FLINK-31271: --- Summary: Introduce system database for catalog in table store Key: FLINK-31271 URL: https://issues.apache.org/jira/browse/FLINK-31271 Project: Flink Issue Type: Improv

Re: [VOTE] FLIP-291: Externalized Declarative Resource Management

2023-02-28 Thread Gyula Fóra
+1 (binding) Looking forward to this :) Gyula On Wed, 1 Mar 2023 at 04:02, feng xiangyu wrote: > +1 (non-binding) > > ConradJam 于2023年3月1日周三 10:37写道: > > > +1 (non-binding) > > > > Zhanghao Chen 于2023年3月1日周三 10:18写道: > > > > > Thanks for driving this. +1 (non-binding) > > > > > > Best, > >

[jira] [Created] (FLINK-31272) Duplicate operators appear in the StreamGraph for Python DataStream API jobs

2023-02-28 Thread Dian Fu (Jira)
Dian Fu created FLINK-31272: --- Summary: Duplicate operators appear in the StreamGraph for Python DataStream API jobs Key: FLINK-31272 URL: https://issues.apache.org/jira/browse/FLINK-31272 Project: Flink

[jira] [Created] (FLINK-31273) Left join with IS_NULL filter be wrongly pushed down and get wrong join results

2023-02-28 Thread Yunhong Zheng (Jira)
Yunhong Zheng created FLINK-31273: - Summary: Left join with IS_NULL filter be wrongly pushed down and get wrong join results Key: FLINK-31273 URL: https://issues.apache.org/jira/browse/FLINK-31273 Pro

[jira] [Created] (FLINK-31274) Python code examples in documentation are not complete

2023-02-28 Thread Ari Huttunen (Jira)
Ari Huttunen created FLINK-31274: Summary: Python code examples in documentation are not complete Key: FLINK-31274 URL: https://issues.apache.org/jira/browse/FLINK-31274 Project: Flink Issue

[jira] [Created] (FLINK-31275) Generate job id in planner

2023-02-28 Thread Shammon (Jira)
Shammon created FLINK-31275: --- Summary: Generate job id in planner Key: FLINK-31275 URL: https://issues.apache.org/jira/browse/FLINK-31275 Project: Flink Issue Type: Improvement Components