Re: [DISCUSS] Allow source readers extending SourceReaderBase to override numRecordsIn report logic

2023-01-07 Thread Dong Lin
Hi John, Not sure if I understand the difference between "deprecate that metric" and "deprecate the private counter mechanism". I think what we want is to update SourceReaderBase's implementation so that it no longer explicitly increments this metric. But we still need to expose this metric to use

Re: [DISCUSS] Allow source readers extending SourceReaderBase to override numRecordsIn report logic

2023-01-07 Thread John Roesler
Thanks, for the discussion, Dong. To answer your question: I was unclear if the desire was to deprecate the metric itself, to be replaced with some other metric, or whether we just wanted to deprecate the way the superclass manages it. It’s clear now that we want to keep the metric and only ch