Re: Re: [DISCUSS] FLIP-269: Properly Handling the Processing Timers on Job Termination

2022-11-15 Thread Yun Gao
Hi Dong, Very thanks for the discussion! > It appears that the issues mentioned in the motivation section > are all related to using Windows on the DataStream API, where > the user's code typically does not have anything to do with Timer. IMO it might not only bounded to the case of window operat

[jira] [Created] (FLINK-30028) A little fix with document about period in log.changelog-mode description.

2022-11-15 Thread Hang HOU (Jira)
Hang HOU created FLINK-30028: Summary: A little fix with document about period in log.changelog-mode description. Key: FLINK-30028 URL: https://issues.apache.org/jira/browse/FLINK-30028 Project: Flink

Re: [DISCUSS] FLIP-269: Properly Handling the Processing Timers on Job Termination

2022-11-15 Thread Dawid Wysakowicz
Hey all, Sorry for being rather late to the party. I'd like to chime in a few thoughts. I agree there are at least two aspects to the problem: 1) lower level handling (StreamOperator) 2) higher level APIs (WindowOperator, CEP, ProcessFunction, ...) First is how do we want to deal with it on

Re: [DISCUSS] FLIP-268: Rack Awareness for Kafka Sources

2022-11-15 Thread Dong Lin
Hi Jeremy, Thanks for creating the FLIP! I think this is a pretty useful feature for users to save operation costs. It would be great to have this feature in Flink. I have a couple of questions below: 1) Could you update the FLIP to specify the concrete signature of the setRackId(..) method prop

Re: [blog article] Howto migrate a real-life batch pipeline from the DataSet API to the DataStream API

2022-11-15 Thread Etienne Chauchot
Hi, Any feedback on the interest of the API benchmark article below ? Best Etienne Le 09/11/2022 à 12:18, Etienne Chauchot a écrit : Hi, And by the way, I was planing on writing another article to compare the performances of DataSet, DataStream and SQL APIs over TPCDS query3. I thought th

Re: [DISCUSS] Allow sharing (RocksDB) memory between slots

2022-11-15 Thread Khachatryan Roman
Thanks for your reply Xingong Song, Could you please elaborate on the following: > The proposed changes break several good properties that we designed for > managed memory. > 1. It's isolated across slots Just to clarify, any way to manage the memory efficiently while capping its usage will break

Re: Re: [DISCUSS] FLIP-269: Properly Handling the Processing Timers on Job Termination

2022-11-15 Thread Dong Lin
Thank you Yun for the detailed explanation! Since this FLIP can add quite some complexity to Flink, it will be really useful to understand the concrete case-case for the proposed changes so that we can identify the approach with minimum extra complexity. We can probably continue the discussion aft

[SUMMARY] Flink 1.17 Release Sync 11/15/2022

2022-11-15 Thread Leonard Xu
Hi devs and users, I’d like to share some highlights about the 1.17 release sync on 11/15/2022. - Release tracking page: - The community has collected some great features on the 1.17 page[1] - @committers Please continuously update the page in the coming week - JIRA account apply

[jira] [Created] (FLINK-30029) Notice/ShadeParser parse version/classifier separately

2022-11-15 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-30029: Summary: Notice/ShadeParser parse version/classifier separately Key: FLINK-30029 URL: https://issues.apache.org/jira/browse/FLINK-30029 Project: Flink

Env Vars in the Flink Web UI

2022-11-15 Thread Konstantin Knauf
Hi all, since Flink 1.17 [1] the Flink Web UI prints *all* environment variables of the Taskmanager or Jobmanagers hosts (Jobmanager -> Configuration -> Environment). Given that environment variables are often used to store sensitive information, I think, it is wrong and dangerous to print those i

Understanding the Internals of Watermark Generation | Actual Implementation

2022-11-15 Thread Tawfek Yasser Tawfek
Dear Flink Developers, Hope all is well, I'm trying to understand how flink in runtime generates and emits watermarks, I think that the TimestampsAndWatermarksOperator class is responsible for assigning timestamps and generating watermarks actually, based on the specified watermark strategy in t

[jira] [Created] (FLINK-30030) Unexpected behavior for overwrite in Hive dialect

2022-11-15 Thread luoyuxia (Jira)
luoyuxia created FLINK-30030: Summary: Unexpected behavior for overwrite in Hive dialect Key: FLINK-30030 URL: https://issues.apache.org/jira/browse/FLINK-30030 Project: Flink Issue Type: Bug

Re: [DISCUSS] FLIP-271: Autoscaling

2022-11-15 Thread Zheng Yu Chen
@Gyula Have a good news, now flip-256 now is finish and merge it . flip-271 discussion seems to have stopped and I wonder if there are any other comments. Can we get to the polls and start this exciting feature 😀 Maybe I can get involved in developing this feature Gyula Fóra 于2022年11月8日周二 18

Re: [jira] [Created] (FLINK-29856) Triggering savepoint does not trigger source operator checkpoint

2022-11-15 Thread Maximilian Michels
This sounds like a pretty serious issue. Has anybody looked into this already? -Max On Thu, Nov 3, 2022 at 3:51 AM Mason Chen (Jira) wrote: > Mason Chen created FLINK-29856: > -- > > Summary: Triggering savepoint does not trigger source > operator ch

Re: [DISCUSS] FLIP-271: Autoscaling

2022-11-15 Thread Maximilian Michels
+1 If there are no further comments, I'll start a vote thread in the next few days. -Max On Tue, Nov 15, 2022 at 2:06 PM Zheng Yu Chen wrote: > @Gyula Have a good news, now flip-256 now is finish and merge it . > flip-271 discussion seems to have stopped and I wonder if there are any > othe

Re: [DISCUSS] FLIP-271: Autoscaling

2022-11-15 Thread Gyula Fóra
I agree we should start the vote. On a separate (but related) small discussion we could also decide backporting https://issues.apache.org/jira/browse/FLINK-29501 for 1.16.1 so that the autoscaler could be more efficiently developed and tested and to make it 1.16 compatible. Cheers, Gyula On Tue,

Re: Env Vars in the Flink Web UI

2022-11-15 Thread Maximilian Michels
Hey Konstantin, I'd be in favor of not printing them at all, i.e. option (d). We have the configuration page which lists the effective config and already removes any known secrets. -Max On Tue, Nov 15, 2022 at 11:26 AM Konstantin Knauf wrote: > Hi all, > > since Flink 1.17 [1] the Flink Web UI

Re: Env Vars in the Flink Web UI

2022-11-15 Thread Gyula Fóra
Thanks for bringing this important issue to discussion Konstantin! I am in favor of not showing them by default with an optional configuration to enable it. Otherwise this poses a big security risk of exposing previously hidden information after upgrade. Gyula On Tue, Nov 15, 2022 at 2:15 PM Max

Re: [DISCUSS] FLIP-271: Autoscaling

2022-11-15 Thread Dong Lin
Hi Maximilian, It seems that the following comments from the previous discussions have not been addressed yet. Any chance we can have them addressed before starting the voting thread? Thanks, Dong On Mon, Nov 7, 2022 at 2:33 AM Gyula Fóra wrote: > Hi Dong! > > Let me try to answer the question

Re: Env Vars in the Flink Web UI

2022-11-15 Thread Konstantin Knauf
Hi everyone, important correction, this is since 1.16.0, not 1.17+. Best, Konstantin Am Di., 15. Nov. 2022 um 14:25 Uhr schrieb Gyula Fóra : > Thanks for bringing this important issue to discussion Konstantin! > > I am in favor of not showing them by default with an optional configuration > to

Re: Re: [DISCUSS] FLIP-269: Properly Handling the Processing Timers on Job Termination

2022-11-15 Thread Lincoln Lee
Hi all, Sorry for the late jump in this thread. I agree with dawid that we should discuss api changes from the perspective of proper endOfInput semantics, and I understand the motivation for this api change and that it should make sense for potential user scenarios. As a table/sql layer develope

[jira] [Created] (FLINK-30031) flink table store run abnormally when shade flink

2022-11-15 Thread zhenzhenhua (Jira)
zhenzhenhua created FLINK-30031: --- Summary: flink table store run abnormally when shade flink Key: FLINK-30031 URL: https://issues.apache.org/jira/browse/FLINK-30031 Project: Flink Issue Type: B

Re: [DISCUSS] FLIP-271: Autoscaling

2022-11-15 Thread Maximilian Michels
Of course! Let me know if your concerns are addressed. The wiki page has been updated. >It will be great to add this in the FLIP so that reviewers can understand how the source parallelisms are computed and how the algorithm works end-to-end. I've updated the FLIP page to add more details on how

[Vote] Remove FlinkKafkaConsumer and graduate related Source APIs

2022-11-15 Thread Jing Ge
Hi, As discussed on the mailing list[1]. I'd like to start a vote to remove FlinkKafkaConsumer and graduate related Source APIs. Since there are some ongoing developments which will change SinkV2 APIs, depending on how far it would go, I might start another vote to remove FlinkKafkaProducer befor

Re: [VOTE] Release 1.15.3, release candidate #1

2022-11-15 Thread Fabian Paul
Hi again, Unfortunately, in the initial email, the links are not correctly displayed, thus please use the information below for testing. Please review and vote on the release candidate #1 for the version 1.15.3, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please pr

Re: [DISCUSS] Release Flink 1.15.3

2022-11-15 Thread Fabian Paul
Hi all, The release vote for 1.15.3-rc1 is open [1]. Unfortunately, I am still missing some votes and would kindly ask for your help to make this release happen :) Best, Fabian [1] https://lists.apache.org/thread/73l524189mpyrjokzxwb5smt80582pw1 On Thu, Nov 10, 2022 at 7:28 PM Martijn Visser w

[jira] [Created] (FLINK-30032) IOException during MAX_WATERMARK emission causes message missing

2022-11-15 Thread Haoze Wu (Jira)
Haoze Wu created FLINK-30032: Summary: IOException during MAX_WATERMARK emission causes message missing Key: FLINK-30032 URL: https://issues.apache.org/jira/browse/FLINK-30032 Project: Flink Iss

Re: [DISCUSS] Release Flink 1.15.3

2022-11-15 Thread Martijn Visser
Hi Fabian, I'll try to have a look tomorrow. Cheers, Martijn On Tue, Nov 15, 2022 at 6:44 PM Fabian Paul wrote: > Hi all, > > The release vote for 1.15.3-rc1 is open [1]. Unfortunately, I am still > missing some votes > and would kindly ask for your help to make this release happen :) > > Best

Re: [DISCUSS] Release Flink 1.15.3

2022-11-15 Thread Danny Cranmer
Hey Fabian, I am out this week, I can take a look Monday if still required. Thanks, Danny On Tue, Nov 15, 2022 at 8:37 PM Martijn Visser wrote: > Hi Fabian, > > I'll try to have a look tomorrow. > > Cheers, Martijn > > On Tue, Nov 15, 2022 at 6:44 PM Fabian Paul wrote: > > > Hi all, > > > > T

[jira] [Created] (FLINK-30033) Add primary key data type validation

2022-11-15 Thread Shammon (Jira)
Shammon created FLINK-30033: --- Summary: Add primary key data type validation Key: FLINK-30033 URL: https://issues.apache.org/jira/browse/FLINK-30033 Project: Flink Issue Type: Improvement

Re: [DISCUSS] Allow sharing (RocksDB) memory between slots

2022-11-15 Thread Xintong Song
Concerning isolation, I think ideally we want everything to be isolated between jobs running in the same cluster (i.e., slots in the same TM). Unfortunately, this is impractical. - Heap / Off-heap memory are directly allocated / deallocated through JVM / OS. Flink does not have a good way to cap th

[jira] [Created] (FLINK-30034) class not found exception when using Hive 3.1.3 connector

2022-11-15 Thread luoyuxia (Jira)
luoyuxia created FLINK-30034: Summary: class not found exception when using Hive 3.1.3 connector Key: FLINK-30034 URL: https://issues.apache.org/jira/browse/FLINK-30034 Project: Flink Issue Type:

[jira] [Created] (FLINK-30035) ./bin/sql-client.sh won't import external jar into the session

2022-11-15 Thread Steven Zhen Wu (Jira)
Steven Zhen Wu created FLINK-30035: -- Summary: ./bin/sql-client.sh won't import external jar into the session Key: FLINK-30035 URL: https://issues.apache.org/jira/browse/FLINK-30035 Project: Flink

[jira] [Created] (FLINK-30036) Force delete pod when k8s node is not ready

2022-11-15 Thread Peng Yuan (Jira)
Peng Yuan created FLINK-30036: - Summary: Force delete pod when k8s node is not ready Key: FLINK-30036 URL: https://issues.apache.org/jira/browse/FLINK-30036 Project: Flink Issue Type: Improvemen

[jira] [Created] (FLINK-30037) Improve the efficiency of Flink ML Python CI

2022-11-15 Thread Yunfeng Zhou (Jira)
Yunfeng Zhou created FLINK-30037: Summary: Improve the efficiency of Flink ML Python CI Key: FLINK-30037 URL: https://issues.apache.org/jira/browse/FLINK-30037 Project: Flink Issue Type: Impr

[jira] [Created] (FLINK-30038) HiveE2E test is not stable

2022-11-15 Thread Shammon (Jira)
Shammon created FLINK-30038: --- Summary: HiveE2E test is not stable Key: FLINK-30038 URL: https://issues.apache.org/jira/browse/FLINK-30038 Project: Flink Issue Type: Bug Components: Table