[jira] [Created] (FLINK-27967) Unable to inject entropy on s3 prefix when doing a save point in Flink

2022-06-09 Thread Vinay Devadiga (Jira)
Vinay Devadiga created FLINK-27967: -- Summary: Unable to inject entropy on s3 prefix when doing a save point in Flink Key: FLINK-27967 URL: https://issues.apache.org/jira/browse/FLINK-27967 Project: F

Re: [DISCUSS] FLIP-238: Introduce FLIP-27-based Data Generator Source

2022-06-09 Thread Martijn Visser
Hi Alex, Thanks for creating the FLIP and opening up the discussion. +1 overall for getting this in place. One question: you've already mentioned that this focussed on the DataStream API. I think it would be a bit confusing that we have a Datagen connector (on the Table side) that wouldn't levera

Re: [VOTE] FLIP-223: Support HiveServer2 Endpoint

2022-06-09 Thread Jingsong Li
+1 Thanks for driving. Best, Jingsong On Thu, Jun 9, 2022 at 2:17 PM Nicholas Jiang wrote: > > +1 (not-binding) > > Best, > Nicholas Jiang > > On 2022/06/07 05:31:21 Shengkai Fang wrote: > > Hi, everyone. > > > > Thanks for all feedback for FLIP-223: Support HiveServer2 Endpoint[1] on > > the d

Re: [DISCUSS] FLIP-222: Support full query lifecycle statements in SQL client

2022-06-09 Thread Paul Lam
Hi team, It's great to see our opinions are finally converging! > `STOP JOB [WITH SAVEPOINT] [WITH DRAIN] ` LGTM. Adding it to the FLIP. To Jark, > We can simplify the statement to "CREATE SAVEPOINT FOR JOB ” Good point. The default savepoint dir should be enough for most cases. To Jing,

Re: [DISCUSS] FLIP-237: Thrift Format Support in Flink

2022-06-09 Thread Martijn Visser
Hi Chen, Thanks for creating the FLIP and opening the discussion. I have a couple of questions/remarks: * What I'm missing overall, is the section on 'Public Interfaces'. The FLIP has a large Proposed Changes section, but it reads more like your journey when you implemented Thrift in your fork. F

Re: [DISCUSS] FLIP-222: Support full query lifecycle statements in SQL client

2022-06-09 Thread Martijn Visser
Hi all, I would not include a DROP SAVEPOINT syntax. With the recently introduced CLAIM/NO CLAIM mode, I would argue that we've just clarified snapshot ownership and if you have a savepoint established "with NO_CLAIM it creates its own copy and leaves the existing one up to the user." [1] We shoul

Re: [DISCUSS] Deprecate SourceFunction APIs

2022-06-09 Thread Jing Ge
Hi, I am very happy to see opinions from different perspectives. That will help us understand the problem better. Thanks all for the informative discussion. Let's see the big picture and check following facts together: 1. FLIP-27 was intended to solve some technical issues that are very difficul

Re: [DISCUSS] FLIP-222: Support full query lifecycle statements in SQL client

2022-06-09 Thread Paul Lam
Hi Martijn, I think the `DROP SAVEPOINT` statement would not conflict with NO_CLAIM mode, since the statement is triggered by users instead of Flink runtime. We’re simply providing a tool for user to cleanup the savepoints, just like `bin/flink savepoint -d :savepointPath` in Flink CLI [1]. [1

[jira] [Created] (FLINK-27968) end-to-end-tests-sql CI test failed

2022-06-09 Thread LuNng Wang (Jira)
LuNng Wang created FLINK-27968: -- Summary: end-to-end-tests-sql CI test failed Key: FLINK-27968 URL: https://issues.apache.org/jira/browse/FLINK-27968 Project: Flink Issue Type: Bug Com

Re: [DISCUSS] Deprecate SourceFunction APIs

2022-06-09 Thread Martijn Visser
Hi all, I think implicitly we've already considered the SourceFunction and SinkFunction as deprecated. They are even marked as so on the Flink roadmap [1]. That also shows that connectors that are using these interfaces are either approaching end-of-life. The fact that we're actively migrating con

Re: [DISCUSS] Releasing 1.15.1

2022-06-09 Thread Yun Gao
Hi David, Very thanks for driving the new version, also +1 since we already accumulated some fixes. Regarding https://issues.apache.org/jira/browse/FLINK-27492, currently there are still some controversy with how to deal with the artifacts. I also agree we may not hold up the release with thi

Re: [VOTE] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-06-09 Thread Jing Zhang
+1 (binding) Best, Jing Zhang Martijn Visser 于2022年6月9日周四 14:58写道: > +1 (binding) > > Op do 9 jun. 2022 om 04:31 schreef Jingsong Li : > > > +1 (binding) > > > > Best, > > Jingsong > > > > On Tue, Jun 7, 2022 at 5:20 PM Jark Wu wrote: > > > > > > +1 (binding) > > > > > > Best, > > > Jark > > >

Re: [DISCUSS] FLIP-222: Support full query lifecycle statements in SQL client

2022-06-09 Thread Martijn Visser
Hi Paul, That's a fair point, but I still think we should not offer that capability via the CLI either. But that's a different discussion :) Thanks, Martijn Op do 9 jun. 2022 om 10:08 schreef Paul Lam : > Hi Martijn, > > I think the `DROP SAVEPOINT` statement would not conflict with NO_CLAIM >

[jira] [Created] (FLINK-27969) StreamPhysicalOverAggregate doesn't support consuming update and delete changes

2022-06-09 Thread Spongebob (Jira)
Spongebob created FLINK-27969: - Summary: StreamPhysicalOverAggregate doesn't support consuming update and delete changes Key: FLINK-27969 URL: https://issues.apache.org/jira/browse/FLINK-27969 Project: Fl

Re: [VOTE] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-06-09 Thread Leonard Xu
+1 (binding) minor typo: the interface in FLIP title should be SupportsStatisticReport as we discussed before Best, Leonard > 2022年6月9日 下午4:32,Jing Zhang 写道: > > +1 (binding) > > Best, > Jing Zhang > > Martijn Visser 于2022年6月9日周四 14:58写道: > >> +1 (binding) >> >> Op do 9 jun. 2022 om 04:3

[jira] [Created] (FLINK-27970) [JUnit5 Migration] Module: flink-hadoop-buik

2022-06-09 Thread Ryan Skraba (Jira)
Ryan Skraba created FLINK-27970: --- Summary: [JUnit5 Migration] Module: flink-hadoop-buik Key: FLINK-27970 URL: https://issues.apache.org/jira/browse/FLINK-27970 Project: Flink Issue Type: Sub-ta

[jira] [Created] (FLINK-27971) [JUnit5 Migration] Module: flink-json

2022-06-09 Thread Ryan Skraba (Jira)
Ryan Skraba created FLINK-27971: --- Summary: [JUnit5 Migration] Module: flink-json Key: FLINK-27971 URL: https://issues.apache.org/jira/browse/FLINK-27971 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-27972) Race condition between task/savepoint notification failure

2022-06-09 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-27972: Summary: Race condition between task/savepoint notification failure Key: FLINK-27972 URL: https://issues.apache.org/jira/browse/FLINK-27972 Project: Flink

[jira] [Created] (FLINK-27973) Introduce TableWrite and TableCommit as an abstraction layer above FileStore for writing RowData

2022-06-09 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-27973: --- Summary: Introduce TableWrite and TableCommit as an abstraction layer above FileStore for writing RowData Key: FLINK-27973 URL: https://issues.apache.org/jira/browse/FLINK-27973

Re: [DISCUSS] Deprecate SourceFunction APIs

2022-06-09 Thread Lijie Wang
Hi all, FYI, currently, some commonly used methods in StreamExecutionEnvironment are still based on the old SourceFunction (and there is no alternative): `StreamExecutionEnvironment#readFile(...)` `StreamExecutionEnvironment#readTextFile(...)` I think these should be migrated to the new source AP

Re: [DISCUSS] FLIP-238: Introduce FLIP-27-based Data Generator Source

2022-06-09 Thread Alexander Fedulov
Hi Martijn, It seems that they serve a bit different purposes though. The DataGenTableSource is for generating random data described by the Table DDL and is tied into the RowDataGenerator/DataGenerator concept which is implemented as an Iterator. The proposed API in contrast is supposed to provid

Re: [DISCUSS] FLIP-238: Introduce FLIP-27-based Data Generator Source

2022-06-09 Thread Martijn Visser
Hey Alex, Yes, I think we need to make sure that we're not causing confusion (I know I already was confused). I think the DataSupplierSource is already better, but perhaps there are others who have an even better idea. Thanks, Martijn Op do 9 jun. 2022 om 14:28 schreef Alexander Fedulov < alexa

Re: [DISCUSS] Deprecate SourceFunction APIs

2022-06-09 Thread Martijn Visser
Hi Lijie, I don't see any problem with deprecating those methods at this moment, as long as we don't remove them until the replacements are available. Besides that, are we sure there are no replacements already, especially with the new FileSource? Best regards, Martijn Op do 9 jun. 2022 om 14:2

Re: [DISCUSS] Deprecate SourceFunction APIs

2022-06-09 Thread Lijie Wang
Hi Martijn, I don't mean it's a blocker. Just a information. And I'm also +1 for this. Put it another way: should we migrate the `#readFile(...)` to new API or provide a similar method "readxxx“ based on the new Source API? And if we don't migrate it, does it mean that the `#readFile(...)` shou

[jira] [Created] (FLINK-27974) Potentially wrong classloader being used to create dynamic table sources

2022-06-09 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-27974: Summary: Potentially wrong classloader being used to create dynamic table sources Key: FLINK-27974 URL: https://issues.apache.org/jira/browse/FLINK-27974 Proj

[jira] [Created] (FLINK-27975) Remove unnecessary RBAC rules from operator

2022-06-09 Thread Jira
Márton Balassi created FLINK-27975: -- Summary: Remove unnecessary RBAC rules from operator Key: FLINK-27975 URL: https://issues.apache.org/jira/browse/FLINK-27975 Project: Flink Issue Type: I

[jira] [Created] (FLINK-27976) [WebUi] Allow order by jobname

2022-06-09 Thread Jira
João Boto created FLINK-27976: - Summary: [WebUi] Allow order by jobname Key: FLINK-27976 URL: https://issues.apache.org/jira/browse/FLINK-27976 Project: Flink Issue Type: Improvement Co

Re: [DISCUSS] Deprecate SourceFunction APIs

2022-06-09 Thread Ingo Bürk
Hi, these APIs don't expose the underlying source directly, so I don't think we need to worry about deprecating them as well. There's also nothing inherently wrong with using a deprecated API internally, though even just for the experience of using our own new APIs I would personally say that

Re: [DISCUSS] Deprecate SourceFunction APIs

2022-06-09 Thread Alexander Fedulov
Hi all, It seems that there is some understandable cautiousness with regard to deprecating methods and subclasses that do not have alternatives just yet. We should probably first agree if it is in general OK for Flink to use @Deprecated annotation for parts of the code that do not have alternativ

[jira] [Created] (FLINK-27977) SavePoints housekeeping API in Flink Cli, Rest API, SQL client

2022-06-09 Thread Jing Ge (Jira)
Jing Ge created FLINK-27977: --- Summary: SavePoints housekeeping API in Flink Cli, Rest API, SQL client Key: FLINK-27977 URL: https://issues.apache.org/jira/browse/FLINK-27977 Project: Flink Issue T

Re: [DISCUSS] FLIP-222: Support full query lifecycle statements in SQL client

2022-06-09 Thread Jing Ge
Hi Paul, Fired a ticket: https://issues.apache.org/jira/browse/FLINK-27977 for savepoints housekeeping. Best regards, Jing On Thu, Jun 9, 2022 at 10:37 AM Martijn Visser wrote: > Hi Paul, > > That's a fair point, but I still think we should not offer that capability > via the CLI either. But t

[jira] [Created] (FLINK-27978) Update spotless and add add-exports to support jdk17

2022-06-09 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-27978: --- Summary: Update spotless and add add-exports to support jdk17 Key: FLINK-27978 URL: https://issues.apache.org/jira/browse/FLINK-27978 Project: Flink Is

Re: [VOTE] FLIP-223: Support HiveServer2 Endpoint

2022-06-09 Thread Jing Ge
+1 (not-binding) Best regards, Jing On Thu, Jun 9, 2022 at 9:23 AM Jingsong Li wrote: > +1 > > Thanks for driving. > > Best, > Jingsong > > On Thu, Jun 9, 2022 at 2:17 PM Nicholas Jiang > wrote: > > > > +1 (not-binding) > > > > Best, > > Nicholas Jiang > > > > On 2022/06/07 05:31:21 Shengkai F

Re: [DISCUSS] Deprecate SourceFunction APIs

2022-06-09 Thread Konstantin Knauf
Hi everyone, thank you Jing for redirecting the discussion back to the topic at hand. I agree with all of your points. +1 to deprecate SourceFunction Is there really no replacement for the StreamExecutionEnvironment#readXXX. There is already a FLIP-27 based FileSource, right? What's missing to r

Re: [DISCUSS] Deprecate SourceFunction APIs

2022-06-09 Thread Lijie Wang
Hi all, Sorry for my mistake. The `StreamExecutionEnvironment#readFiles` and can be easily replaced by `FileSource#forRecordStreamFormat/forBulkFileFormat`. I have no other concerns. +1 to deprecate SourceFunction and deprecate the methods (in StreamExecutionEnvironment) based on SourceFunction

[jira] [Created] (FLINK-27979) Support to upgrade session cluster in a more fine grained way

2022-06-09 Thread Aitozi (Jira)
Aitozi created FLINK-27979: -- Summary: Support to upgrade session cluster in a more fine grained way Key: FLINK-27979 URL: https://issues.apache.org/jira/browse/FLINK-27979 Project: Flink Issue Type

[jira] [Created] (FLINK-27980) Add python examples to document of "DataStream API Integration"

2022-06-09 Thread pengmd (Jira)
pengmd created FLINK-27980: -- Summary: Add python examples to document of "DataStream API Integration" Key: FLINK-27980 URL: https://issues.apache.org/jira/browse/FLINK-27980 Project: Flink Issue T

[jira] [Created] (FLINK-27981) Add python examples to document of Time Attributes"

2022-06-09 Thread pengmd (Jira)
pengmd created FLINK-27981: -- Summary: Add python examples to document of Time Attributes" Key: FLINK-27981 URL: https://issues.apache.org/jira/browse/FLINK-27981 Project: Flink Issue Type: Improveme

[RESULT][VOTE]FLIP-234: Support Retryable Lookup Join To Solve Delayed Updates Issue In External Systems

2022-06-09 Thread Lincoln Lee
Hi everyone, FLIP-234[1] has been accepted. There are 4 approving votes which are all binding[2] - Binding: Jark Wu - Binding: Jingsong Li - Binding: godfrey he - Binding: Martijn Visser None against. Thanks again to everyone! [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-234%3A+

[RESULT][VOTE] FLIP-231: Introduce SupportsStatisticReport to support reporting statistics from source connectors

2022-06-09 Thread godfrey he
Hi, everyone. FLIP-231: Introduce SupportsStatisticReport to support reporting statistics from source connectors[1] has been accepted. There are 5 binding votes, 1 non-binding votes[2]. - Jing Ge(non-binding) - Jark Wu(binding) - Jingsong Li(binding) - Martijn Visser(binding) - Jing Zhang(binding

[jira] [Created] (FLINK-27982) FLIP-231: Introduce SupportsStatisticReport to support reporting statistics from source connectors

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27982: -- Summary: FLIP-231: Introduce SupportsStatisticReport to support reporting statistics from source connectors Key: FLINK-27982 URL: https://issues.apache.org/jira/browse/FLINK-27982

[jira] [Created] (FLINK-27983) Introduce SupportsStatisticsReport interface

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27983: -- Summary: Introduce SupportsStatisticsReport interface Key: FLINK-27983 URL: https://issues.apache.org/jira/browse/FLINK-27983 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-27984) Introduce FileBasedStatisticsReportableDecodingFormat interface

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27984: -- Summary: Introduce FileBasedStatisticsReportableDecodingFormat interface Key: FLINK-27984 URL: https://issues.apache.org/jira/browse/FLINK-27984 Project: Flink

[jira] [Created] (FLINK-27985) Introduce FlinkRecomputeStatisticsProgram to compute statistics after filter push and partition pruning

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27985: -- Summary: Introduce FlinkRecomputeStatisticsProgram to compute statistics after filter push and partition pruning Key: FLINK-27985 URL: https://issues.apache.org/jira/browse/FLINK-2798

[jira] [Created] (FLINK-27986) Refactor the name of finish method for JdbcOutputFormatBuilder

2022-06-09 Thread Lei Xie (Jira)
Lei Xie created FLINK-27986: --- Summary: Refactor the name of finish method for JdbcOutputFormatBuilder Key: FLINK-27986 URL: https://issues.apache.org/jira/browse/FLINK-27986 Project: Flink Issue T

[jira] [Created] (FLINK-27987) Let FileSystemTableSource extend from SupportsStatisticReport

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27987: -- Summary: Let FileSystemTableSource extend from SupportsStatisticReport Key: FLINK-27987 URL: https://issues.apache.org/jira/browse/FLINK-27987 Project: Flink Is

[jira] [Created] (FLINK-27988) Let HiveTableSource extend from SupportsStatisticReport

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27988: -- Summary: Let HiveTableSource extend from SupportsStatisticReport Key: FLINK-27988 URL: https://issues.apache.org/jira/browse/FLINK-27988 Project: Flink Issue Typ

[jira] [Created] (FLINK-27989) CSV format supports reporting statistics

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27989: -- Summary: CSV format supports reporting statistics Key: FLINK-27989 URL: https://issues.apache.org/jira/browse/FLINK-27989 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-27991) ORC format supports reporting statistics

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27991: -- Summary: ORC format supports reporting statistics Key: FLINK-27991 URL: https://issues.apache.org/jira/browse/FLINK-27991 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-27990) Parquet format supports reporting statistics

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27990: -- Summary: Parquet format supports reporting statistics Key: FLINK-27990 URL: https://issues.apache.org/jira/browse/FLINK-27990 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-27992) cep StreamExecMatch need check the parallelism and maxParallelism of the two transformation in it

2022-06-09 Thread jackylau (Jira)
jackylau created FLINK-27992: Summary: cep StreamExecMatch need check the parallelism and maxParallelism of the two transformation in it Key: FLINK-27992 URL: https://issues.apache.org/jira/browse/FLINK-27992

[jira] [Created] (FLINK-27993) When only use 'flex SQL' to develop programs, `watermark` can be defined when creating view tables

2022-06-09 Thread HunterHunter (Jira)
HunterHunter created FLINK-27993: Summary: When only use 'flex SQL' to develop programs, `watermark` can be defined when creating view tables Key: FLINK-27993 URL: https://issues.apache.org/jira/browse/FLINK-27993

Re: [VOTE] FLIP-223: Support HiveServer2 Endpoint

2022-06-09 Thread LuNing Wang
+ 1 Best regards, LuNing Wang Jing Ge 于2022年6月10日周五 04:08写道: > +1 (not-binding) > > Best regards, > Jing > > On Thu, Jun 9, 2022 at 9:23 AM Jingsong Li wrote: > > > +1 > > > > Thanks for driving. > > > > Best, > > Jingsong > > > > On Thu, Jun 9, 2022 at 2:17 PM Nicholas Jiang > > wrote: > > >

[jira] [Created] (FLINK-27994) ERROR org.apache.flink.runtime.source.coordinator.SourceCoordinator

2022-06-09 Thread wangkang (Jira)
wangkang created FLINK-27994: Summary: ERROR org.apache.flink.runtime.source.coordinator.SourceCoordinator Key: FLINK-27994 URL: https://issues.apache.org/jira/browse/FLINK-27994 Project: Flink

[jira] [Created] (FLINK-27995) Upgrade Janio version

2022-06-09 Thread Shengkai Fang (Jira)
Shengkai Fang created FLINK-27995: - Summary: Upgrade Janio version Key: FLINK-27995 URL: https://issues.apache.org/jira/browse/FLINK-27995 Project: Flink Issue Type: Improvement Co