[jira] [Created] (FLINK-17080) Utils.CollectHelper is possible to throw NPE if the sink is up but not initialized when the job fails

2020-04-10 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-17080: --- Summary: Utils.CollectHelper is possible to throw NPE if the sink is up but not initialized when the job fails Key: FLINK-17080 URL: https://issues.apache.org/jira/browse/FLINK-1708

[jira] [Created] (FLINK-17081) Batch test classes in Blink planner does not extend TestLogger

2020-04-10 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-17081: --- Summary: Batch test classes in Blink planner does not extend TestLogger Key: FLINK-17081 URL: https://issues.apache.org/jira/browse/FLINK-17081 Project: Flink

Re: [DISCUSS] FLIP-105: Support to Interpret and Emit Changelog in Flink SQL

2020-04-10 Thread Jark Wu
Hi, After a short offline discussion with Kurt, It seems that I misunderstood Kurt's meaning. Kurt meant: is `format=debezium` is enough, or split into two options `format=debezium` and `format.encoding=json`. Debezium not only support JSON encoding, but also Avro. Canal supports JSON and Protobu

[jira] [Created] (FLINK-17082) Remove mocking from SQL client tests

2020-04-10 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-17082: Summary: Remove mocking from SQL client tests Key: FLINK-17082 URL: https://issues.apache.org/jira/browse/FLINK-17082 Project: Flink Issue Type: Impr

Re: [DISCUSS] FLIP-123: DDL and DML compatibility for Hive connector

2020-04-10 Thread Rui Li
Hi Jingsong, Thanks for your input. I'd prefer to keep Hive syntax to a separate parser, because 1) Supporting both Hive and Flink syntax in one parser makes the grammar complicated and less efficient, e.g. we may need a bigger LOOKAHEAD value to resolve conflicts. 2) It can be difficult to add ne

[jira] [Created] (FLINK-17083) Restrict users of accumulators not to return null in Accumulator#getLocalValue

2020-04-10 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-17083: --- Summary: Restrict users of accumulators not to return null in Accumulator#getLocalValue Key: FLINK-17083 URL: https://issues.apache.org/jira/browse/FLINK-17083 Project:

Re: [VOTE] FLIP-113: Supports Dynamic Table Options for Flink SQL

2020-04-10 Thread Timo Walther
+1 (binding) Thanks for the healthy discussion. I think this feature can be useful during the development of a pipeline. Regards, Timo On 10.04.20 03:34, Danny Chan wrote: Hi all, I would like to start the vote for FLIP-113 [1], which is discussed and reached a consensus in the discussion t

[jira] [Created] (FLINK-17084) Implement type inference for ROW/ARRAY/MAP constructors

2020-04-10 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-17084: Summary: Implement type inference for ROW/ARRAY/MAP constructors Key: FLINK-17084 URL: https://issues.apache.org/jira/browse/FLINK-17084 Project: Flink

Javadocs Broken?

2020-04-10 Thread tison
Hi guys, Right now when I click "JavaDocs" in out docsite[1] it jumps to a page[2] I think is definitely not out api documentation. Any thoughts? Best, tison. [1] https://ci.apache.org/projects/flink/flink-docs-master/ [2] https://ci.apache.org/projects/flink/flink-docs-master/api/java/

Re: Javadocs Broken?

2020-04-10 Thread tison
s/out/our/

[jira] [Created] (FLINK-17085) Remove FlinkKubeClient#handleException since it does not do anything

2020-04-10 Thread Yang Wang (Jira)
Yang Wang created FLINK-17085: - Summary: Remove FlinkKubeClient#handleException since it does not do anything Key: FLINK-17085 URL: https://issues.apache.org/jira/browse/FLINK-17085 Project: Flink

[jira] [Created] (FLINK-17086) Flink sql client not able to read parquet hive table because `HiveMapredSplitReader` not supports name mapping reading for parquet format.

2020-04-10 Thread Lei Wang (Jira)
Lei Wang created FLINK-17086: Summary: Flink sql client not able to read parquet hive table because `HiveMapredSplitReader` not supports name mapping reading for parquet format. Key: FLINK-17086 URL: https://issues.

Re: [VOTE] FLIP-113: Supports Dynamic Table Options for Flink SQL

2020-04-10 Thread Jark Wu
+1 from my side (binding) Best, Jark On Fri, 10 Apr 2020 at 17:03, Timo Walther wrote: > +1 (binding) > > Thanks for the healthy discussion. I think this feature can be useful > during the development of a pipeline. > > Regards, > Timo > > On 10.04.20 03:34, Danny Chan wrote: > > Hi all, > > >

Re: [VOTE] FLIP-108: Add GPU support in Flink

2020-04-10 Thread Xintong Song
Sorry to pull this back. I have some concerns about the recent updated interface details. - Should we have a factory interface for `ExternalResourceDriver`, that takes the configuration and returns a driver instance? Otherwise, if we are creating the driver instance with reflection, we kind of imp

Re: [VOTE] FLIP-113: Supports Dynamic Table Options for Flink SQL

2020-04-10 Thread Kurt Young
+1 Best, Kurt On Fri, Apr 10, 2020 at 6:01 PM Jark Wu wrote: > +1 from my side (binding) > > Best, > Jark > > On Fri, 10 Apr 2020 at 17:03, Timo Walther wrote: > > > +1 (binding) > > > > Thanks for the healthy discussion. I think this feature can be useful > > during the development of a pipe

Re: [VOTE] FLIP-108: Add GPU support in Flink

2020-04-10 Thread Yangze Guo
Thanks for the feedback, Xintong. - Should we have a factory interface for `ExternalResourceDriver`, that takes the configuration and returns a driver instance? Otherwise, if we are creating the driver instance with reflection, we kind of implicitly requires the driver to have a public non-argumen

Re: [DISCUSS] Creating a new repo to host Flink benchmarks

2020-04-10 Thread Yu Li
+1 for the proposal, thanks for driving this Yun. Best Regards, Yu On Fri, 10 Apr 2020 at 11:25, Dian Fu wrote: > +1 for this proposal. > > > 在 2020年4月10日,上午10:58,Zhijiang 写道: > > > > +1 for the proposal. > > > > Best, > > Zhijiang > > > > > > -

[jira] [Created] (FLINK-17087) Use constant port for rest.port when it's set as 0 on Kubernetes

2020-04-10 Thread Canbin Zheng (Jira)
Canbin Zheng created FLINK-17087: Summary: Use constant port for rest.port when it's set as 0 on Kubernetes Key: FLINK-17087 URL: https://issues.apache.org/jira/browse/FLINK-17087 Project: Flink

Re: [DISCUSS] FLIP-124: Add open/close and Collector to (De)SerializationSchema

2020-04-10 Thread Jark Wu
Hi Xiaogang, I think this proposal doesn't conflict with your use case, you can still chain a ProcessFunction after a source which emits raw data. But I'm not in favor of chaining ProcessFunction after source, and we should avoid that, because: 1) For correctness, it is necessary to perform the w

[jira] [Created] (FLINK-17088) Search TaskManager log content based on keywords function

2020-04-10 Thread pingle wang (Jira)
pingle wang created FLINK-17088: --- Summary: Search TaskManager log content based on keywords function Key: FLINK-17088 URL: https://issues.apache.org/jira/browse/FLINK-17088 Project: Flink Issue

Re: [PROPOSAL] Contribute training materials to Apache Flink

2020-04-10 Thread Eduardo Winpenny Tejedor
+1 to the idea, David regarding your question, could it go in a quickstart/get started with Flink section? Next to or replacing the current 'Getting started' section? On Thu, 9 Apr 2020, 22:11 Seth Wiesman, wrote: > Hi David, > > +1 to add to the project. > > I agree that flink.apache.org and fl

[jira] [Created] (FLINK-17089) Checkpoint fail because RocksDBException: Error While opening a file for sequentially reading

2020-04-10 Thread Lu Niu (Jira)
Lu Niu created FLINK-17089: -- Summary: Checkpoint fail because RocksDBException: Error While opening a file for sequentially reading Key: FLINK-17089 URL: https://issues.apache.org/jira/browse/FLINK-17089 Pro

Re: [PROPOSAL] Contribute training materials to Apache Flink

2020-04-10 Thread David Anderson
Yes, the training materials could become part of the docs, as you suggest. The reason why I'm somewhat resistant to this idea is that the documentation is versioned. It will be easier to maintain the training content and its exercises and examples if we only have to be concerned with having one ver

Re: [VOTE] FLIP-108: Add GPU support in Flink

2020-04-10 Thread Yangze Guo
Hi there, I've updated the FLIP accordingly. Please take a look. If you have any further concerns please let me know. Best, Yangze Guo On Fri, Apr 10, 2020 at 6:40 PM Yangze Guo wrote: > > Thanks for the feedback, Xintong. > > - Should we have a factory interface for `ExternalResourceDriver`, th

Re: [VOTE] FLIP-108: Add GPU support in Flink

2020-04-10 Thread Becket Qin
Good feedback form Xintong. The latest FLIP looks good to me. Thanks, Jiangjie (Becket) Qin On Sat, Apr 11, 2020 at 9:20 AM Yangze Guo wrote: > Hi there, > I've updated the FLIP accordingly. Please take a look. If you have any > further concerns please let me know. > > Best, > Yangze Guo > > O

Re: [DISCUSS] FLIP-71 - E2E View support in Flink SQL

2020-04-10 Thread Jark Wu
Sorry for the late reply, I have some concern around "Supporting SHOW VIEWS|DESCRIBE VIEW name". Currently, in SQL CLI, the "SHOW TABLES" will also list views and "DESCRIBE name" can also describe a view. Shall we remove the view support in those commands if we want to support a dedicate "SHOW VIE

[VOTE] FLIP-105: Support to Interpret and Emit Changelog in Flink SQL

2020-04-10 Thread Jark Wu
Hi all, I would like to start the vote for FLIP-105 [1], which is discussed and reached a consensus in the discussion thread [2]. The vote will be open for at least 72h, unless there is an objection or not enough votes. Thanks, Jark [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-105

Re: [DISCUSS] FLIP-71 - E2E View support in Flink SQL

2020-04-10 Thread Zhenghua Gao
Hi Jark, >> Shall we remove the view support in those commands if we want to support a >> dedicate "SHOW VIEWS|DESCRIBE VIEW name"? Yes, we should correct those commands in SQL client. Will open tickets after the vote. *Best Regards,* *Zhenghua Gao* On Sat, Apr 11, 2020 at 11:25 AM Jark Wu wr

[jira] [Created] (FLINK-17090) Harden preckeck for the KubernetesConfigOptions.JOB_MANAGER_CPU

2020-04-10 Thread Canbin Zheng (Jira)
Canbin Zheng created FLINK-17090: Summary: Harden preckeck for the KubernetesConfigOptions.JOB_MANAGER_CPU Key: FLINK-17090 URL: https://issues.apache.org/jira/browse/FLINK-17090 Project: Flink

[jira] [Created] (FLINK-17091) AvroRowSerializationSchema doesn't support new Timestamp conversion classes

2020-04-10 Thread Paul Lin (Jira)
Paul Lin created FLINK-17091: Summary: AvroRowSerializationSchema doesn't support new Timestamp conversion classes Key: FLINK-17091 URL: https://issues.apache.org/jira/browse/FLINK-17091 Project: Flink