Hi guys,
I'm a bit torn. In general, +1 for making parameters effectively final.
The question is how to enforce it. We can make it explicit (like Aljoscha
said). All IDEs will show immediately warnings/errors for violations. It
would allow to softly migrate code.
Another option is to use a check
Luke Sun created FLINK-14332:
Summary: add flink-metrics-signalfx to flink-metrics
Key: FLINK-14332
URL: https://issues.apache.org/jira/browse/FLINK-14332
Project: Flink
Issue Type: New Feature
Hi,
Couple of arguments to counter the proposal of making the `final` keyword
obligatory. Can we prepare a code style/IDE settings to add it automatically?
If not, I would be strongly against it, since:
- Intellij’s automatic refactor actions will not work properly.
- I don’t think it’s a big d
Chesnay Schepler created FLINK-14333:
Summary: YARNSessionFIFOSecuredITCase fails on Travis
Key: FLINK-14333
URL: https://issues.apache.org/jira/browse/FLINK-14333
Project: Flink
Issue Ty
Hi Arvid,
Thanks for coming up with this FLIP. I think it addresses the issues raised in
the previous mailing list discussion [2].
For the record: +1 from my side to implement this.
Piotrek
> On 30 Sep 2019, at 14:31, Arvid Heise wrote:
>
> Hi Devs,
>
> I would like to start the formal dis
+1 for the FLIP.
Best,
Dawid
On 07/10/2019 08:45, Bowen Li wrote:
> Hi all,
>
> I'd like to start a new voting thread for FLIP-57 [1] on its latest status
> despite [2], and we've reached consensus in [2] and [3].
>
> This voting will be open for minimum 3 days till 6:45am UTC, Oct 10.
>
> Thank
Hi all,
I would like to start the vote for FLIP-74[1], which is discussed and
reached a consensus in the discussion thread[2].
The vote will be open util Oct. 9th(72h starting on Oct.7th), unless
there is an objection or not enough votes.
Best,
tison.
[1]
https://cwiki.apache.org/confluence/di
Thanks for your thoughts Arvid & Piotr,
I check out the effect of ParameterAssignment[1] and it does
prevent codes from modifying parameter which I argued above
the most value introduced by `final` modifier of parameter.
So firstly, I think it's good to enable ParameterAssignment in our
codebase.
Chesnay Schepler created FLINK-14334:
Summary: ElasticSearch docs refer to non-existent
ExceptionUtils.containsThrowable
Key: FLINK-14334
URL: https://issues.apache.org/jira/browse/FLINK-14334
Pro
Are you referring to "ExampleIntegrationTest"? If so, then I'm afraid
this test is slightly misleading since the order isn't guaranteed in
this case.
1) As long as the parallelism of the sink is 1 the elements should
arrive in order.
2) The order is maintained if parallelism=1 since elements
Hi all,
My quick take on it.
1. If I were to introduce any rule on that I agree with Aljoscha, we
should rather enforce the `final` keyword rather than the opposite.
2. I think it does not make sense to enforce rules on such an
unimportant (in my opinion) topic. Generally I agree with Piotr that
I've filed FLINK-14335 for fixing the java example.
On 07/10/2019 11:08, Chesnay Schepler wrote:
Are you referring to "ExampleIntegrationTest"? If so, then I'm afraid
this test is slightly misleading since the order isn't guaranteed in
this case.
1) As long as the parallelism of the sink is 1
Chesnay Schepler created FLINK-14335:
Summary: Java version of ExampleIntegrationTest in testing docs is
incorrect
Key: FLINK-14335
URL: https://issues.apache.org/jira/browse/FLINK-14335
Project:
After checking out the check style modules mentioned by Tison, I really do not
see a point of enforcing/adding `final`. With ParameterAssignment [1] it’s
redundant and will cause problems that I mentioned before.
Additionally enabling ParameterAssignment [1] would be probably much easier in
our
Thanks a lot for Your answer here Chesnay. I have one more question,
since the `fromElements` is creating the stream with parallelism 1, and I
can see that the env created for my local machine has a default parallelism
== 12. So I assume that the entries from the stream are propagated for the
first
Are you asking how the elements from the source are distributed across
the subtasks of the next operation?
That differs a bit across operations; in this case (a map/sink after a
source) AFAIK they are distributed in a round-robin manner.
On 07/10/2019 11:26, Dominik Wosiński wrote:
Thanks a
For Piotr's comment. IntelliJ does support adding/removing final parameters
automatically.
You could even automatically add them on save with the Save Actions plugin
[1].
[1] https://plugins.jetbrains.com/plugin/7642-save-actions
On Mon, Oct 7, 2019 at 11:22 AM Piotr Nowojski wrote:
> After ch
Thanks for updating the wiki pages Rong. Looks good to me.
Cheers,
Till
On Sun, Oct 6, 2019 at 7:21 PM Rong Rong wrote:
> Thanks everyone for the suggestions. I think the majority of us voted for
> using Github repo.
>
> I have updated the merging pull request wiki page [1] with the new
> instr
Chesnay Schepler created FLINK-14336:
Summary: Exceptions in AsyncCheckpointRunnable#run are never logged
Key: FLINK-14336
URL: https://issues.apache.org/jira/browse/FLINK-14336
Project: Flink
Till Rohrmann created FLINK-14337:
-
Summary: HistoryServerTest.testHistoryServerIntegration failed on
Travis
Key: FLINK-14337
URL: https://issues.apache.org/jira/browse/FLINK-14337
Project: Flink
Hi Jark,
I notice a critical bug[1] is marked resolved in 1.9.1 but given 1.9.1
has been cut I'd like to throw the issue here so that we're sure
whether or not it is included in 1.9.1.
Best,
tison.
[1] https://issues.apache.org/jira/browse/FLINK-14315
Jark Wu 于2019年9月30日周一 下午3:25写道：
> Hi ev
Danny Chen created FLINK-14338:
--
Summary: Upgrade Calcite version to 1.22 for Flink SQL
Key: FLINK-14338
URL: https://issues.apache.org/jira/browse/FLINK-14338
Project: Flink
Issue Type: Improve
I don't think using zookeeper should cause any problem on starting multiple
TMs per node.
For standalone cluster, having one TM per node is usually the easiest way.
It is easy to config (simply config the TM resource to the available
resource of the node), and it is more efficient (less TM framewo
Thanks Rong for updating the wiki pages.
Best,
Jark
> 在 2019年10月7日，18:37，Till Rohrmann 写道：
>
> Thanks for updating the wiki pages Rong. Looks good to me.
>
> Cheers,
> Till
>
> On Sun, Oct 6, 2019 at 7:21 PM Rong Rong wrote:
>
>> Thanks everyone for the suggestions. I think the majority of
Hi Zili,
Thanks for reminding me this, because of the Chinese National Day and Flink
Forward Europe,
we didn't receive any verification on the 1.9.1 RC1. And I guess we have to
extend the voting time after Flink Forward.
So I'm fine to have FLINK-14315 and rebuild another RC. What do you think
@Ti
king's uncle created FLINK-14339:
Summary: The checkpoint ID count wrong on restore savepoint log
Key: FLINK-14339
URL: https://issues.apache.org/jira/browse/FLINK-14339
Project: Flink
Issue
Hi Xintong Song
2. We could switch between the detailed mode(including cpu, task heap,
task off-heap, shuffle, on-heap managed, off-heap managed) and the summary
mode(only including cpu and mem), which is very easy to do in UI design.
4. I think the key point is not pagination in Web UI but the R
2. Sounds good to me.
4. If that is the case, I would suggest to make a large default page size,
so incase of huge log data we have less large pages rather than lots of
small pages.
Thank you~
Xintong Song
On Tue, Oct 8, 2019 at 11:03 AM Yadong Xie wrote:
> Hi Xintong Song
>
> 2. We could s
Congxian Qiu(klion26) created FLINK-14340:
-
Summary: Specify an unique DFSClient name for Hadoop FileSystem
Key: FLINK-14340
URL: https://issues.apache.org/jira/browse/FLINK-14340
Project: Flin
Hi Bowen,
Thanks for the proposal. I have two thoughts:
1) Regarding to "loadModule", how about
tableEnv.loadModule("xxx" [, propertiesMap]);
tableEnv.unloadModule(“xxx”);
This makes the API similar to SQL. IMO, instance of Module is not needed
and verbose as parameter.
And this makes it easier
liupengcheng created FLINK-14341:
Summary: Flink-python builds with failure: no such option: --prefix
Key: FLINK-14341
URL: https://issues.apache.org/jira/browse/FLINK-14341
Project: Flink
Is
Dian Fu created FLINK-14342:
---
Summary: Remove method FunctionDefinition#getLanguage
Key: FLINK-14342
URL: https://issues.apache.org/jira/browse/FLINK-14342
Project: Flink
Issue Type: Sub-task
32 matches
Mail list logo
