[jira] [Created] (FLINK-13578) Blink throws exception when using Types.INTERVAL_MILLIS in TableSource

2019-08-05 Thread Wei Zhong (JIRA)
Wei Zhong created FLINK-13578: - Summary: Blink throws exception when using Types.INTERVAL_MILLIS in TableSource Key: FLINK-13578 URL: https://issues.apache.org/jira/browse/FLINK-13578 Project: Flink

[jira] [Created] (FLINK-13579) Failed launching standalone cluster due to improper configured irrelevant config options for active mode.

2019-08-05 Thread Xintong Song (JIRA)
Xintong Song created FLINK-13579: Summary: Failed launching standalone cluster due to improper configured irrelevant config options for active mode. Key: FLINK-13579 URL: https://issues.apache.org/jira/browse/FLIN

Re: [Question] What is the difference between Embedded and SingleLeaderElectionService?

2019-08-05 Thread Zili Chen
Hi Till, SingleLeaderElectionService is an effectively subclass of EmbeddedLeaderService. The merge work can be done as the minor patch attached. I came into this area when working on FLINK-10333, implementing LeaderElectionService as the document describes. I noticed that besides Standalone and

Re: [Question] What is the difference between Embedded and SingleLeaderElectionService?

2019-08-05 Thread Zili Chen
Investigated the usage of EmbeddedLeaderService, as you said, it is mainly used in MiniCluster. The difference between EmbeddedLeaderService and ZooKeeperLeader(Election|Retrieval)Service is that the latter uses component host and port pre-configured while the former configured at the runtime. I'

[jira] [Created] (FLINK-13580) Add overload support for user defined function to blink-planner

2019-08-05 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-13580: Summary: Add overload support for user defined function to blink-planner Key: FLINK-13580 URL: https://issues.apache.org/jira/browse/FLINK-13580 Project: Flink

[jira] [Created] (FLINK-13581) BatchFineGrainedRecoveryITCase failed on Travis

2019-08-05 Thread Andrey Zagrebin (JIRA)
Andrey Zagrebin created FLINK-13581: --- Summary: BatchFineGrainedRecoveryITCase failed on Travis Key: FLINK-13581 URL: https://issues.apache.org/jira/browse/FLINK-13581 Project: Flink Issue T

Re: REST API / JarRunHandler: More flexibility for launching jobs

2019-08-05 Thread Zili Chen
Hi Thomas, If REST handler calls main(), the behavior inside main() is unpredictable. Now the jar run handler extract the job graph and submit it with the job id configured in REST request. If REST handler calls main() we can hardly even know how much jobs are executed. A new environment, as you

[jira] [Created] (FLINK-13582) Improve the implementation of LISTAGG in Blink planner to remove delimiter from state

2019-08-05 Thread Jing Zhang (JIRA)
Jing Zhang created FLINK-13582: -- Summary: Improve the implementation of LISTAGG in Blink planner to remove delimiter from state Key: FLINK-13582 URL: https://issues.apache.org/jira/browse/FLINK-13582 Pr

[Request For Review] Refactoring Client API

2019-08-05 Thread Zili Chen
Hi devs, Last week I drafted a design document on refactoring Flink's Client API [1] following the discussion in this thread[2]. Jeff(@zjffdu) and Thomas(@tweise) shared their insights and commented in the doc. Given that client apis are public user-facing interfaces, in order to serve a series o

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-05 Thread Aljoscha Krettek
Hi, I’m also in favour of using Optional only for method return values. I could be persuaded to allow them for parameters of internal methods but I’m sceptical about that. Aljoscha > On 2. Aug 2019, at 15:35, Yu Li wrote: > > TL; DR: I second Timo that we should use Optional only as method r

Re: [VOTE] Publish the PyFlink into PyPI

2019-08-05 Thread Aljoscha Krettek
+1 (binding) > On 1. Aug 2019, at 17:23, Hequn Cheng wrote: > > +1 (non-binding) > > Thanks a lot for driving this! @jincheng sun > > Best, Hequn > > On Thu, Aug 1, 2019 at 11:00 PM Biao Liu wrote: > >> Thanks Jincheng for working on this. >> >> +1 (non-binding) >> >> Thanks, >> Biao /'b

[jira] [Created] (FLINK-13583) Add SK telecom to Chinese Powered By page

2019-08-05 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-13583: - Summary: Add SK telecom to Chinese Powered By page Key: FLINK-13583 URL: https://issues.apache.org/jira/browse/FLINK-13583 Project: Flink Issue Type: Task

Re: [DISCUSS] Flink project bylaws

2019-08-05 Thread Stephan Ewen
I added a clarification to the table, clarifying that the current phrasing means that committers do not need another +1 for their commits. On Mon, Jul 29, 2019 at 2:11 PM Fabian Hueske wrote: > Hi Becket, > > Thanks a lot for pushing this forward and addressing the feedback. > I'm very happy wit

Re: [Question] What is the difference between Embedded and SingleLeaderElectionService?

2019-08-05 Thread Till Rohrmann
The idea of the EmbeddedLeaderService is to give you ZooKeeper like high availability if all components run inside of the same process. That way it is also easy to test HA functionality without having to start ZooKeeper. Technically, the EmbeddedLeaderService is not needed but it is very handy to

[jira] [Created] (FLINK-13584) RankLikeAggFunctionBase should respect type to construct literal

2019-08-05 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-13584: Summary: RankLikeAggFunctionBase should respect type to construct literal Key: FLINK-13584 URL: https://issues.apache.org/jira/browse/FLINK-13584 Project: Flink

Re: [Question] What is the difference between Embedded and SingleLeaderElectionService?

2019-08-05 Thread Zili Chen
Yes I can understand the idea. One more question, as you mentioned, the EmbeddedLeaderService is not needed. However, from our current codebase, if we configure rest.bind-port as "0", i.e., resolve the port at the runtime, we actually resolve the port on WebMonitorEndpoint#start. But WebMonitorEnd

[jira] [Created] (FLINK-13585) Test TaskAsyncCallTest#testSetsUserCodeClassLoader() deadlocks

2019-08-05 Thread Gary Yao (JIRA)
Gary Yao created FLINK-13585: Summary: Test TaskAsyncCallTest#testSetsUserCodeClassLoader() deadlocks Key: FLINK-13585 URL: https://issues.apache.org/jira/browse/FLINK-13585 Project: Flink Issue

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-05 Thread Till Rohrmann
I'd be in favour of - Optional for method return values if not performance critical - Optional can be used for internal methods if it makes sense - No optional fields Cheers, Till On Mon, Aug 5, 2019 at 12:07 PM Aljoscha Krettek wrote: > Hi, > > I’m also in favour of using Optional only for me

Re: [Question] What is the difference between Embedded and SingleLeaderElectionService?

2019-08-05 Thread Till Rohrmann
Not sure whether I fully understood the question but if you are asking how the StandaloneHaServices notify its listeners about a changed REST endpoint address, then this is not possible. The StandaloneHaServices do not tolerate failures of the Dispatcher, ResourceManager, JobMaster or WebMonitorEnd

[jira] [Created] (FLINK-13586) Method ClosureCleaner.clean broke backward compatibility between 1.8.0 and 1.8.1

2019-08-05 Thread JIRA
Gaël Renoux created FLINK-13586: --- Summary: Method ClosureCleaner.clean broke backward compatibility between 1.8.0 and 1.8.1 Key: FLINK-13586 URL: https://issues.apache.org/jira/browse/FLINK-13586 Projec

[jira] [Created] (FLINK-13587) Fix some transformation names are not set in blink planner

2019-08-05 Thread Jark Wu (JIRA)
Jark Wu created FLINK-13587: --- Summary: Fix some transformation names are not set in blink planner Key: FLINK-13587 URL: https://issues.apache.org/jira/browse/FLINK-13587 Project: Flink Issue Type:

Re: REST API / JarRunHandler: More flexibility for launching jobs

2019-08-05 Thread Thomas Weise
If the goal is to keep job creation and job submission separate and we agree that there should be more flexibility for the job construction, then JobGraph and friends should be stable API that the user can depend on. If that's the case, the path Chesnay pointed to may become viable. There was disc

[jira] [Created] (FLINK-13588) StreamTask.handleAsyncException throws away the exception cause

2019-08-05 Thread John Lonergan (JIRA)
John Lonergan created FLINK-13588: - Summary: StreamTask.handleAsyncException throws away the exception cause Key: FLINK-13588 URL: https://issues.apache.org/jira/browse/FLINK-13588 Project: Flink

[jira] [Created] (FLINK-13589) DelimitedInputFormat index error on multi-byte delimiters with whole file input splits

2019-08-05 Thread Adric Eckstein (JIRA)
Adric Eckstein created FLINK-13589: -- Summary: DelimitedInputFormat index error on multi-byte delimiters with whole file input splits Key: FLINK-13589 URL: https://issues.apache.org/jira/browse/FLINK-13589

Re: [Question] What is the difference between Embedded and SingleLeaderElectionService?

2019-08-05 Thread Zili Chen
Thanks for your reply. Let me rephrase the question, is it possible to configure rest.bind-port to "0", i.e., resolved at the runtime, in standalone mode? The problem is that the resolution is after the construction of standalone ha service which requires a known bind-port. See also(at f75d8e1fbb

Re: REST API / JarRunHandler: More flexibility for launching jobs

2019-08-05 Thread Zili Chen
It sounds like a request to change the interface Program into public interface Program { JobGraph getJobGraph(String... args); } Also, given that JobGraph is said as internal interface or cannot be relied on, we might introduce and use a representation that allows for cross version compatibilit

[jira] [Created] (FLINK-13591) 'Completed Job List' in Flink web doesn't display right when job name is very long

2019-08-05 Thread Kurt Young (JIRA)
Kurt Young created FLINK-13591: -- Summary: 'Completed Job List' in Flink web doesn't display right when job name is very long Key: FLINK-13591 URL: https://issues.apache.org/jira/browse/FLINK-13591 Projec

[jira] [Created] (FLINK-13590) flink-on-yarn sometimes could create many little files that are xxx-taskmanager-conf.yaml

2019-08-05 Thread shuwenjun (JIRA)
shuwenjun created FLINK-13590: - Summary: flink-on-yarn sometimes could create many little files that are xxx-taskmanager-conf.yaml Key: FLINK-13590 URL: https://issues.apache.org/jira/browse/FLINK-13590 P

[jira] [Created] (FLINK-13592) test_tpch.sh should not hardcode flink version

2019-08-05 Thread Kurt Young (JIRA)
Kurt Young created FLINK-13592: -- Summary: test_tpch.sh should not hardcode flink version Key: FLINK-13592 URL: https://issues.apache.org/jira/browse/FLINK-13592 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-13593) Prevent failing the wrong job in CheckpointFailureManager

2019-08-05 Thread Yu Li (JIRA)
Yu Li created FLINK-13593: - Summary: Prevent failing the wrong job in CheckpointFailureManager Key: FLINK-13593 URL: https://issues.apache.org/jira/browse/FLINK-13593 Project: Flink Issue Type: Bug

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-05 Thread Piotr Nowojski
Hi Qi, > For example, SingleInputGate is already creating Optional for every > BufferOrEvent in getNextBufferOrEvent(). How much performance gain would we > get if it’s replaced by null check? When I was introducing it there, I have micro-benchmarked this change, and there was no visible throu