Re: Optional vs Nullable

2017-08-25 Thread Chesnay Schepler
I think you're overselling optional a little bit. The unfortunate fact is that any Optional /can still be null itself/. As such, if there a method accepts an Optional it still has to check whether it is null, /and in addition whether it contains a null. /i.e. public void myMethod(Optional

Re: Optional vs Nullable

2017-08-25 Thread Dawid Wysakowicz
I agree with Chesnay, that Optional is not so perfect especially in places other than return value. Some other problems I could see: 1. Optional is a generic type, and generic types not always behave well with the TypeInformation due to type erasure. 2. Optionals due not work well with Reflecti

[jira] [Created] (FLINK-7510) Move "flink-connector-twitter & flink-connector-wikiedits" to bahir-flink

2017-08-25 Thread Hai Zhou (JIRA)
Hai Zhou created FLINK-7510: --- Summary: Move "flink-connector-twitter & flink-connector-wikiedits" to bahir-flink Key: FLINK-7510 URL: https://issues.apache.org/jira/browse/FLINK-7510 Project: Flink

Re: Optional vs Nullable

2017-08-25 Thread Piotr Nowojski
Chesney you are looking at this in wrong way. With Optionals, your proposed myMethod wouldn’t be allowed by our code style/convention. It should look like this: public void myMethod(Optional parameter) { checkNotNull(parameter, “parameter is null”); if (parameter.isPresent()) {

[jira] [Created] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

2017-08-25 Thread Dawid Wysakowicz (JIRA)
Dawid Wysakowicz created FLINK-7511: --- Summary: Remove dead code after dropping backward compatibility with <=1.2 Key: FLINK-7511 URL: https://issues.apache.org/jira/browse/FLINK-7511 Project: Flink

[jira] [Created] (FLINK-7512) avoid unnecessary buffer copies during network serialization

2017-08-25 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7512: -- Summary: avoid unnecessary buffer copies during network serialization Key: FLINK-7512 URL: https://issues.apache.org/jira/browse/FLINK-7512 Project: Flink Issue

[jira] [Created] (FLINK-7513) remove TestBufferFactory#MOCK_BUFFER

2017-08-25 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7513: -- Summary: remove TestBufferFactory#MOCK_BUFFER Key: FLINK-7513 URL: https://issues.apache.org/jira/browse/FLINK-7513 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-7514) fix BackPressureStatsTrackerITCase releasing buffers twice

2017-08-25 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7514: -- Summary: fix BackPressureStatsTrackerITCase releasing buffers twice Key: FLINK-7514 URL: https://issues.apache.org/jira/browse/FLINK-7514 Project: Flink Issue Ty

[jira] [Created] (FLINK-7515) allow actual 0-length content in NettyMessage#allocateBuffer()

2017-08-25 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7515: -- Summary: allow actual 0-length content in NettyMessage#allocateBuffer() Key: FLINK-7515 URL: https://issues.apache.org/jira/browse/FLINK-7515 Project: Flink Iss

[jira] [Created] (FLINK-7516) MemorySegment: do not allow copies into a read-only ByteBuffer

2017-08-25 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7516: -- Summary: MemorySegment: do not allow copies into a read-only ByteBuffer Key: FLINK-7516 URL: https://issues.apache.org/jira/browse/FLINK-7516 Project: Flink Iss

[jira] [Created] (FLINK-7517) let NettyBufferPool extend PooledByteBufAllocator

2017-08-25 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7517: -- Summary: let NettyBufferPool extend PooledByteBufAllocator Key: FLINK-7517 URL: https://issues.apache.org/jira/browse/FLINK-7517 Project: Flink Issue Type: Sub-t

[jira] [Created] (FLINK-7518) pass our own buffer instances to netty

2017-08-25 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7518: -- Summary: pass our own buffer instances to netty Key: FLINK-7518 URL: https://issues.apache.org/jira/browse/FLINK-7518 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-7519) Enrich ClientRestException with HttpResponseStatus

2017-08-25 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-7519: Summary: Enrich ClientRestException with HttpResponseStatus Key: FLINK-7519 URL: https://issues.apache.org/jira/browse/FLINK-7519 Project: Flink Issue Type:

[jira] [Created] (FLINK-7520) let our Buffer class extend from netty's buffer class

2017-08-25 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7520: -- Summary: let our Buffer class extend from netty's buffer class Key: FLINK-7520 URL: https://issues.apache.org/jira/browse/FLINK-7520 Project: Flink Issue Type: S

[jira] [Created] (FLINK-7521) Remove the 10MB limit from the current REST implementation.

2017-08-25 Thread Kostas Kloudas (JIRA)
Kostas Kloudas created FLINK-7521: - Summary: Remove the 10MB limit from the current REST implementation. Key: FLINK-7521 URL: https://issues.apache.org/jira/browse/FLINK-7521 Project: Flink

[jira] [Created] (FLINK-7522) Add termination future to ClusterEntrypoint

2017-08-25 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-7522: Summary: Add termination future to ClusterEntrypoint Key: FLINK-7522 URL: https://issues.apache.org/jira/browse/FLINK-7522 Project: Flink Issue Type: Improve

[jira] [Created] (FLINK-7523) test instability in LocalStreamEnvironmentITCase#testRunIsolatedJob

2017-08-25 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7523: -- Summary: test instability in LocalStreamEnvironmentITCase#testRunIsolatedJob Key: FLINK-7523 URL: https://issues.apache.org/jira/browse/FLINK-7523 Project: Flink

[jira] [Created] (FLINK-7524) Task "xxx" did not react to cancelling signal, but is stuck in method

2017-08-25 Thread Bowen Li (JIRA)
Bowen Li created FLINK-7524: --- Summary: Task "xxx" did not react to cancelling signal, but is stuck in method Key: FLINK-7524 URL: https://issues.apache.org/jira/browse/FLINK-7524 Project: Flink Is

[jira] [Created] (FLINK-7525) Add config option to disable Cancel functionality on UI

2017-08-25 Thread Ted Yu (JIRA)
Ted Yu created FLINK-7525: - Summary: Add config option to disable Cancel functionality on UI Key: FLINK-7525 URL: https://issues.apache.org/jira/browse/FLINK-7525 Project: Flink Issue Type: Improveme