Re: blink planner issue

9年7月16日(星期二) 23:45 > To:dev > Subject:Re: blink planner issue > > Hi Caizhi and Jark, > > I think you are correct, from the quick view for source code, it should > only compares field types in the equals method. > Currently some composite logical row type has compared name a

Re: blink planner issue

16日(星期二) 23:45 To:dev Subject:Re: blink planner issue Hi Caizhi and Jark, I think you are correct, from the quick view for source code, it should only compares field types in the equals method. Currently some composite logical row type has compared name and description, such as RowType and

Re: blink planner issue

Hi Caizhi and Kaka, Actually, equals-with-field-names and equals-without-field-names are both needed in Flink SQL. It's not correct to ignore field names comparison simply in RowType#equals. We have encountered this problems before because RowTypeInfo doesn't compare field names (see FLINK-12848).

Re: blink planner issue

Hi Caizhi and Jark, I think you are correct, from the quick view for source code, it should only compares field types in the equals method. Currently some composite logical row type has compared name and description, such as RowType and StructuredType. Thanks, Kaka Chen Caizhi Weng 于2019年7月16日周

Re: blink planner issue

Hi Caizhi and Mark, I think you are correct, from the quick view for source code, it should only compares field types in the equals method. Currently some composite logical row type has compared name and description, such as RowType and StructuredType. Thanks, Kaka Chen Caizhi Weng 于2019年7月16日周

Re: blink planner issue

Hi Kaka and Jark, On a side note, `RowTypeInfo` only compares field types in its `equals` method. I think our new logical row type shouldn't break this behavior. kaka chen 于2019年7月16日周二 下午10:53写道： > Hi Jark, > > Thanks! > > Thanks, > Kaka Chen > > Jark Wu 于2019年7月16日周二 下午10:30写道： > > > Hi Kaka

Re: blink planner issue

Hi Jark, Thanks! Thanks, Kaka Chen Jark Wu 于2019年7月16日周二 下午10:30写道： > Hi Kaka, > > Thanks for reporting this. We didn't cover integrate tests for connectors > yet because of FLINK-13276. We will cover that after FLINK-13276 is fixed. > > The problem you raised might because we misused `Logical

Re: blink planner issue

Hi Kaka, Thanks for reporting this. We didn't cover integrate tests for connectors yet because of FLINK-13276. We will cover that after FLINK-13276 is fixed. The problem you raised might because we misused `LogicalType.equals` which will checks field names as well. I have created an issue (FLINK-

Re: blink planner issue

I am looking this issue, the related codes which throw errors are: SinkCodeGenerator:: validateFieldType() ... // Tuple/Case class/Row type requested case tt: TupleTypeInfoBase[_] => fieldTypes.zipWithIndex foreach { case (fieldTypeInfo: GenericTypeInfo[_

blink planner issue

Hi All, We are trying to switch to blink table planner in HBase connector, which found the following error: Running org.apache.flink.addons.hbase.HBaseSinkITCase Formatting using clusterid: testClusterID Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 28.042 sec <<< FAILURE! -