Thanks for being so honest. I think everyone has had a "faux pas" like
this. Since our build process is quite complex, even seemingly trivial
changes can break the master. I also learned it the hard way and
always run tests on Travis.
On Wed, Dec 7, 2016 at 3:17 PM, Greg Hogan wrote:
> This was m
This was my mistake. The commit only involved web assets so I had tested
the runtime but had not run mvn verify. Also, I'm typically aware of the CI
status (receiving the emails for my own pull requests) but had failed to
note the failure of the license check on this PR.
On Wed, Dec 7, 2016 at 4:5
Since the Rat plugin which fails the build runs in the first seconds
of the build process, I wonder how that was not detected before
merging the commit? :)
On Wed, Dec 7, 2016 at 10:46 AM, Till Rohrmann wrote:
> Thanks Marton.
>
> On Wed, Dec 7, 2016 at 8:24 AM, Fabian Hueske wrote:
>
>> Thanks
Thanks Marton.
On Wed, Dec 7, 2016 at 8:24 AM, Fabian Hueske wrote:
> Thanks Marton!
>
> 2016-12-07 2:49 GMT+01:00 Márton Balassi :
>
> > Done, my Travis build came in all green:
> >
> > https://travis-ci.org/mbalassi/flink/builds/181809550
> >
> > The hotfix is pushed.
> >
> > On Tue, Dec 6, 20
Thanks Marton!
2016-12-07 2:49 GMT+01:00 Márton Balassi :
> Done, my Travis build came in all green:
>
> https://travis-ci.org/mbalassi/flink/builds/181809550
>
> The hotfix is pushed.
>
> On Tue, Dec 6, 2016 at 5:08 PM, Márton Balassi
> wrote:
>
> > The travis build is currently broken, if noon
Done, my Travis build came in all green:
https://travis-ci.org/mbalassi/flink/builds/181809550
The hotfix is pushed.
On Tue, Dec 6, 2016 at 5:08 PM, Márton Balassi
wrote:
> The travis build is currently broken, if noone has fixed it yet then I
> will push the fix for it.
>
> https://travis-ci.
The travis build is currently broken, if noone has fixed it yet then I will
push the fix for it.
https://travis-ci.org/apache/flink/builds/181765492
The following files have missing licenses:
flink-runtime-web/web-dashboard/assets/images/browserconfig.xml
flink-runtime-web/web-dashboard/assets/i
