Re: Tests for the Steaming classes

2015-03-23 Thread Stephan Ewen
I am currently travelling, I'll open the JIRAs as soon as I find a bit of time to sit down... On Mon, Mar 23, 2015 at 5:20 PM, Henry Saputra wrote: > +1 for more tests and plus more documentation both internal and javadoc. > Some stuff like memory usafe and data flows are bit different from batc

Re: Tests for the Steaming classes

2015-03-23 Thread Henry Saputra
+1 for more tests and plus more documentation both internal and javadoc. Some stuff like memory usafe and data flows are bit different from batch which have not been documented much. Looks like more will be coming to Flink to check out streaming solution in Flink as alternative to others. - Henry

Re: Tests for the Steaming classes

2015-03-23 Thread Gyula Fóra
+1 for lots of streaming tests On Mon, Mar 23, 2015 at 11:23 AM, Márton Balassi wrote: > Thanks for looking into this, Stephan. +1 for the JIRAs. > > On Mon, Mar 23, 2015 at 10:55 AM, Ufuk Celebi wrote: > > > On 23 Mar 2015, at 10:44, Stephan Ewen wrote: > > > > > Hi everyone! > > > > > > With

Re: Tests for the Steaming classes

2015-03-23 Thread Márton Balassi
Thanks for looking into this, Stephan. +1 for the JIRAs. On Mon, Mar 23, 2015 at 10:55 AM, Ufuk Celebi wrote: > On 23 Mar 2015, at 10:44, Stephan Ewen wrote: > > > Hi everyone! > > > > With the streaming stuff getting heavier exposure, I think it needs a few > > more tests. With so many changes

Re: Tests for the Steaming classes

2015-03-23 Thread Ufuk Celebi
On 23 Mar 2015, at 10:44, Stephan Ewen wrote: > Hi everyone! > > With the streaming stuff getting heavier exposure, I think it needs a few > more tests. With so many changes, untested features are running a high risk > of being "patched away" by accident. > > For the runtime and batch API part,

Tests for the Steaming classes

2015-03-23 Thread Stephan Ewen
Hi everyone! With the streaming stuff getting heavier exposure, I think it needs a few more tests. With so many changes, untested features are running a high risk of being "patched away" by accident. For the runtime and batch API part, we go with the policy that every new feature can only be merg