I agree with Ufuk. Reworking tests might cause a lot of problems! We
should do this with great care only!
The most important thing is to pay attention to open PRs and ask to
write unit tests. I would also suggest, to have at least one new unit
test per fixed bug (that of course test exactly the bu
I just created a JIRA issue [1].
Regards,
Chiwan Park
[1] https://issues.apache.org/jira/browse/FLINK-2712
> On Sep 20, 2015, at 1:33 AM, Chiwan Park wrote:
>
> Okay, I’ll create a JIRA issue and send a pull request for it. :)
>
> Regards,
> Chiwan Park
>
>> On Sep 19, 2015, at 7:35 PM, Ufuk
Okay, I’ll create a JIRA issue and send a pull request for it. :)
Regards,
Chiwan Park
> On Sep 19, 2015, at 7:35 PM, Ufuk Celebi wrote:
>
> Thanks Stephan for pointing this out. I agree with you. +1
>
> @Chiwan: Good idea with the Wiki. Actually maybe even better to add it to the
> contribut
Thanks Stephan for pointing this out. I agree with you. +1
@Chiwan: Good idea with the Wiki. Actually maybe even better to add it to the
contribution guide? Do you have time to open a PR with Stephan’s suggestions?
@Martin: I agree that it does not suffice to just point this out as a new
guidel
Should there be a concerted effort to reduce the amount of unnecessary
integration tests and cover those cases by unit tests?
We could collect the cases in a ticket and work through the list one by
one, no?
Best regards,
Martin
Chiwan Park schrieb am Fr., 18. Sep. 2015 um
12:33 Uhr:
> Hi Steph
Hi Stephan,
Thanks for nice guide! I think we can upload this to the wiki or how to
contribute documentation.
This guide would be helpful for newcomers.
Regards,
Chiwan Park
> On Sep 17, 2015, at 9:33 PM, Stephan Ewen wrote:
>
> Hi all!
>
> The build time of Flink with all tests is nearing 1
Hi all!
The build time of Flink with all tests is nearing 1h on Travis for the
shortest run.
It is good that we do excessive testing, there are many mechanisms that
need that.
I have also seen that a lot of fixes that could be tested in a UnitTest
style are actually tested as a full Flink program
