Re: Slow duplicated tests

2017-01-10 Thread Alexey Demin
Hi https://github.com/apache/flink/pull/3089 Check please 2017-01-10 18:42 GMT+04:00 Robert Metzger : > I think the code has been refactored many times since then. > > If the code of the tests is really the same I'm okay with deleting the > duplicate method. > > On Tue, Jan 10, 2017 at 3:29 PM

Re: Slow duplicated tests

2017-01-10 Thread Robert Metzger
I think the code has been refactored many times since then. If the code of the tests is really the same I'm okay with deleting the duplicate method. On Tue, Jan 10, 2017 at 3:29 PM, Aljoscha Krettek wrote: > Thanks for looking into this! I think we can put in the fix and remove one > of the tes

Re: Slow duplicated tests

2017-01-10 Thread Aljoscha Krettek
Thanks for looking into this! I think we can put in the fix and remove one of the tests, yes. @Robert What do you think? I think you initially added this test a lng while back. On Mon, 9 Jan 2017 at 20:11 Alexey Demin wrote: > Hi, > > I am trying make small review for slow test and I found

Slow duplicated tests

2017-01-09 Thread Alexey Demin
Hi, I am trying make small review for slow test and I found small issue: NonReusingReOpenableHashTableITCase testSpillingHashJoinWithMassiveCollisions testSpillingHashJoinWithTwoRecursions for testSpillingHashJoinWithTwoRecursions exist description /* * This test is basically identical to th