We could help this by having shorter local and input argument names and
better timing for the line wrapping.
We already have separate code style for java, for example keeping tabs
instead of spaces, and scala because java code more verbose and declarative
compare to scala.
I am ok with Java do not
I don't want to remove the rule to encourage people to write ugly scala
code ;)
Also, I hope its the exception to use more than 100 chars.
But there are some cases where it is really okay to have longer lines (for
example exception messages or method signatures in some cases).
I agree with Stephan
Ah seemed like kafka has taken out the max line rule.
I prefer to keep the max char lines, maybe making it larger than 100,
especially with Scala code.
On Wednesday, February 18, 2015, Henry Saputra
wrote:
> I would argue it is helpful especially if you use text editor like vim or
> even GitHub
I would argue it is helpful especially if you use text editor like vim or
even GitHub diff page.
Most modern scala projects like spark and kafka also enforce the rule.
- Henry
On Wednesday, February 18, 2015, Stephan Ewen wrote:
> It is true, you can write endless chains of functions in Scala
It is true, you can write endless chains of functions in Scala that become
hard to read, which should be prevented.
In my opinion, line length limits are not a good tool to do that. In most
cases they simply introduce linebreaks between constant names and parameters
which hurt code readability mor
Sorry Robert and all, pressed Send button too early =(
One of the main reasons to keep the max 100 chars line (or 120) is to
make sure that the code is readable an understandable, which in Scala
you can easily get the code to be complicated and in a single line.
- Henry
[1] http://www.scalastyle
Oh, since we are using tabs I think they are counted as one character?
On Tuesday, February 17, 2015, Robert Metzger wrote:
> I agree with Stephan that we should remove the scalastyle rule enforcing
> lines of 100 characters length.
>
>
>
> On Mon, Jan 5, 2015 at 10:21 AM, Henry Saputra >
> wro
Stephan was taking about imports statements.
I want to keep line length to 100 or 120.
Code that is longer than 100 char per line need to be revisited.
On Tuesday, February 17, 2015, Robert Metzger wrote:
> I agree with Stephan that we should remove the scalastyle rule enforcing
> lines of 100 c
I agree with Stephan that we should remove the scalastyle rule enforcing
lines of 100 characters length.
On Mon, Jan 5, 2015 at 10:21 AM, Henry Saputra
wrote:
> @Stephan - sure I could work on it. Been wanting to do it for a while.
> No, it is not the checkstyle issue.
>
> - Henry
>
> On Mon,
