Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-07-04 Thread Mang Zhang
. Now, the FLIP looks good to me. Best regards, Yuxia 发件人: "zhangmang1" 收件人: luoyu...@alumni.sjtu.edu.cn 抄送: "dev" , "Martijn Visser" , imj...@gmail.com 发送时间: 星期二, 2022年 7 月 05日 上午 11:35:35 主题: Re:Re: Re: Re: Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CR

Re:Re: Re: Re: Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-07-04 Thread Mang Zhang
Hi yuxia, I updated the FLIP and adjusted your concern for RTAS and AtomicCatalog, not sure if it solved your concern, looking forward to your reply! -- Best regards, Mang Zhang At 2022-07-05 11:26:22, "Jark Wu" wrote: >Thanks for the update, the FLIP looks good to me now. > >Best, >

Re: Re: Re: Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-07-04 Thread Jark Wu
Thanks for the update, the FLIP looks good to me now. Best, Jark On Tue, 5 Jul 2022 at 10:57, Mang Zhang wrote: > Hi Jark, > Regarding the two issues of concern to yuxia, we did some offline > discussions and adjusted the implementation plan. > > >1) RTAS > RTAS is not supported in FLIP, so we

Re:Re: Re: Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-07-04 Thread Mang Zhang
Hi Jark, Regarding the two issues of concern to yuxia, we did some offline discussions and adjusted the implementation plan. >1) RTAS RTAS is not supported in FLIP, so we will remove rtas from option name and do option forward compatibility when it is supported in the future. >2) AtomicCatal

Re: Re: Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-07-04 Thread Jark Wu
Hi Mang, I'm not sure whether your response has addressed Yuxia's concern or not. Would be better to receive a confirmation from participants before starting the vote. Actually, I have the same feeling with Yuxia's reply. 1) RTAS If it's hard to have a consistent behavior for RTAS between stream

Re:Re: Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-30 Thread Mang Zhang
Hi Martijn, Thank you for your reply, these are two good questions. >1. The FLIP mentions that if the user doesn't specify the WITH option part >in the query of the sink table, it will be assumed that the user wants to >create a managed table. What will happen if the user doesn't have Table >Store

Re: Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-30 Thread Martijn Visser
Hi Mang, I have two questions/remarks: 1. The FLIP mentions that if the user doesn't specify the WITH option part in the query of the sink table, it will be assumed that the user wants to create a managed table. What will happen if the user doesn't have Table Store configured/installed? Will we t

Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-28 Thread Mang Zhang
Hi Yuxia, Thank you very much for your reply. >1: Also, the mixture of ctas and rtas confuses me as the FLIP talks nothing >about rtas but refer it in the configuration suddenly. And if we're not to >implement rtas in this FLIP, it may be better not to refer it and the `rtas` >shouldn't expos

Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-24 Thread Mang Zhang
Hi, Martijn Thanks for your reply! I looked at the SQL standard, CTAS is part of the SQL standard. Feature T172 is "AS subquery clause in table definition". -- Best regards, Mang Zhang At 2022-05-04 21:49:00, "Martijn Visser" wrote: >Hi everyone, > >Can we identify if this proposed syntax

Re:Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-05 Thread Mang Zhang
Hi, Yuxia Thanks for your reply! About the question 1, we will not support, FLIP-218[1] is to simplify the complexity of user DDL and make it easier for users to use. I have never encountered this case in a big data. About the question 2, we will provide a public API like below public void clean