Re: Support distinct aggregation over data stream on Table/SQL API

2018-02-15 Thread Fabian Hueske
Hi Rong, Thanks for the update! Please suggest JIRAs to close (or close them yourself if possible) if they are covered by the ones that you create. At the moment, we aim for feature parity between SQL and Table API. So ideally all features are available in both APIs. This is usually not too compl

Re: Support distinct aggregation over data stream on Table/SQL API

2018-02-15 Thread Rong Rong
Thanks Fabian for the review, I will incorporate the feedback and finalized the design doc and open a JIRA to track all sub-tasks. Please also feel free to comment if there's any other related DISTINCT aggregation use cases not covered by the design doc. One higher level question regarding #4, sh

Re: Support distinct aggregation over data stream on Table/SQL API

2018-02-14 Thread Fabian Hueske
Hi Rong, Thanks for taking the initiative to improve the support for DISTINCT aggregations! I've made a pass over your design document and left a couple of comments. I think it is a really good write up and serves as a good start. IMO, the next steps could be to 1) continue and finalize the discu