Re:Re: Re: Re: FLIP-510: Drop ChangelogNormalize for operations which don't need it

2025-03-09 Thread Xuyang
I have no other questions. +1 for it. -- Best! Xuyang At 2025-03-07 19:37:09, "Dawid Wysakowicz" wrote: >> >> From my understanding, for a sink, if its schema includes a primary key, >> we can assume it has >> the ability to process delete messages (with '-D') and perform deletio

Re: Re: Re: FLIP-510: Drop ChangelogNormalize for operations which don't need it

2025-03-07 Thread Dawid Wysakowicz
> > From my understanding, for a sink, if its schema includes a primary key, > we can assume it has > the ability to process delete messages (with '-D') and perform deletions > by key (PK). If it does not > include a PK, we would implicitly treat it as a log-structured table that > supports full ro

Re: Re: FLIP-510: Drop ChangelogNormalize for operations which don't need it

2025-02-28 Thread Dawid Wysakowicz
Hey Xuyang, Ad. 1 Yes, you're right, but we already do that for determining if we need UPDATE_BEFORE or not. FlinkChangelogModeInferenceProgram already deals with that. Ad. 2 Unfortunately it is. This is also the only reason I need a FLIP. We can determine internally for every internal operator if