Re: Re: Re: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-08-31 Thread Martijn Visser
source tables, e.g. there are billions of records to > read. > > >> Frankly speaking, we have been haunted by this problem for a long > time when > > >> using the Flink CDC Connectors to read large tables. > > >> > > > >> > Therefore, in

RE: Re: Re: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-08-09 Thread Roc Marshal
g. there are billions of records to read. > >> Frankly speaking, we have been haunted by this problem for a long time when > >> using the Flink CDC Connectors to read large tables. > >> > > >> > Therefore, in order to prevent JobManager from experiencing

Re: Re: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-08-01 Thread Martijn Visser
JdbcSourceEnumerator should avoid saving too many >> JdbcSourceSplits in the unassigned list. And it would be better if all the >> splits would be computed on the fly. >> > >> > Best, >> > Weike >> > >> > -邮件原件- >> > 发件人: Lijie W

Re: Re: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-07-04 Thread Martijn Visser
> > -邮件原件----- > > 发件人: Lijie Wang > > 发送时间: 2022年7月1日 上午 10:25 > > 收件人: dev@flink.apache.org > > 主题: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27 > > > > Hi Roc, > > > > Thanks for driving the discussion. > > >

RE: Re: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-07-01 Thread Roc Marshal
would be better if all the splits would be > computed on the fly. > > Best, > Weike > > -邮件原件- > 发件人: Lijie Wang > 发送时间: 2022年7月1日 上午 10:25 > 收件人: dev@flink.apache.org > 主题: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27 > > Hi Roc,

Re: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-07-01 Thread Dong Weike
avoid saving too many JdbcSourceSplits in the unassigned list. And it would be better if all the splits would be computed on the fly. Best, Weike -邮件原件- 发件人: Lijie Wang 发送时间: 2022年7月1日 上午 10:25 收件人: dev@flink.apache.org 主题: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

RE: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-06-30 Thread Roc Marshal
Hi, Lijie. Thanks for the catching and sorry for the typo in sorting out the draft. I updated it. Best regards, Roc Marshal On 2022/07/01 02:24:56 Lijie Wang wrote: > Hi Roc, > > Thanks for driving the discussion. > > Could you describe in detail what the JdbcSourceSplit represents? It loo

Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-06-30 Thread Lijie Wang
Hi Roc, Thanks for driving the discussion. Could you describe in detail what the JdbcSourceSplit represents? It looks like something wrong with the comments of JdbcSourceSplit in FLIP(it describe as "A {@link SourceSplit} that represents a file, or a region of a file"). Best, Lijie Roc Mar

RE: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-06-30 Thread Roc Marshal
Hi, Boto. Thanks for your reply. +1 to me on watermark strategy definition in ‘streaming’ & table source. I'm not sure if FLIP-202[1] is suitable for a separate discussion, but I think your proposal is very helpful to the new source. It would be great if the new source could be compa