Re:Re: Re: Re: [DISCUSS] FLIP-229: Introduces Join Hint for Flink SQL Batch Job

2022-05-09 Thread Xuyang
Hi Cao. If i guess right, what you mean is the scope that the join hint takes affect. In your example 1, the expected result is that the hint will not takes affect both on (t1 join t2) and (t3 join t1) if we have the sql following, "SELECT /*+ SHUFFLE_HASH(test1) */ t1.a FROM (select test1.* from

Re: Re: Re: [DISCUSS] FLIP-229: Introduces Join Hint for Flink SQL Batch Job

2022-05-09 Thread cao zou
Hi Xuyang, thanks for your explanation. For more information about inheritPath and the logic of propagating, you can see `RelOptUtil`. As the doc says, The hint will be propagated from the root node to the children nodes. if we have an AST as follows: LogicalProjectHint1[] > +- LogicalJoin

Re: Re: [DISCUSS] FLIP-229: Introduces Join Hint for Flink SQL Batch Job

2022-05-08 Thread Jingsong Li
Thanks Xuyang for driving. zoucao also mentioned alias. Can you explain in the FLIP why alias is not supported? What are the difficulties and maybe we can try to overcome them. Or how do we need to report errors if we don't support it. Best, Jingsong On Mon, May 9, 2022 at 10:53 AM Xuyang wrot