Re:Re: Re:Re: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-27 Thread Mang Zhang
;> >Looking forward to further feedback from others. >> > >> > >> > >> >-- >> > >> >Best regards, >> >Mang Zhang >> > >> > >> > >> > >> > >> >At 2022-06-24 19:52:58, "ron&q

Re: Re:Re: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-25 Thread Jark Wu
; > > > > > > > > > > >At 2022-06-24 19:52:58, "ron" wrote: > >>Thanks for godfrey further feedback, your suggestions are very good to > me, the FLIP has updated according to your feedback. It will be very good > if you look at it a

Re:Re:Re: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-24 Thread Mang Zhang
ing forward to further feedback from others. >> >> >>> -----原始邮件- >>> 发件人: "godfrey he" >>> 发送时间: 2022-06-24 17:00:51 (星期五) >>> 收件人: dev >>> 抄送: "Yun Gao" >>> 主题: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT

Re:Re: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-24 Thread Mang Zhang
>> 发送时间: 2022-06-24 17:00:51 (星期五) >> 收件人: dev >> 抄送: "Yun Gao" >> 主题: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE >> TABLE(CTAS) >> >> Hi all, >> >> Sorry for the late reply. >> >> >table.co

Re: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-24 Thread ron
-06-24 17:00:51 (星期五) > 收件人: dev > 抄送: "Yun Gao" > 主题: Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE > TABLE(CTAS) > > Hi all, > > Sorry for the late reply. > > >table.cor-table-as-select.atomicity-enabled > Regarding `cor`, thi

Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-24 Thread godfrey he
Hi all, Sorry for the late reply. >table.cor-table-as-select.atomicity-enabled Regarding `cor`, this abbreviation is not commonly used. >Create Table As Select(CTAS) feature depends on the serializability of the >catalog. To quickly see if the catalog supports CTAS, we need to try to >seriali

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-03 Thread Jing Ge
Hi Mang, Thanks for driving this! Finally there is a discussion about CTAS. It is one of the most important features. I agree with Jark that it would be good to be able to take care of both atomicity and isolation, which lead to Spark DataSource v2. Would you like to help me understand the connec

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-30 Thread Yun Gao
Hi, Regarding the drop operation, with some offline discussion with Dalong and Zhu, we think that listening in the client side might be problematic since it would exit after submitting the jobs in detached mode, thus the operation might need to be in the JobMaster side. For the listener interf

Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-24 Thread Jark Wu
Hi Mang and Godfrey, I'm okay with `Table#saveAs(tablePath)`, but it would be better to consider overriding table options and create or replace table. So we may also need to provide methods for the returned object: - #option(key, value) - #create() - #createIfNotExist() - #createOrReplace() //

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-23 Thread godfrey he
Hi Jark, > "Table#createTableAs(tablePath)" seems a >little strange to me. `Table#createTableAs` is a bit misleading, I learn to Table#saveAs(tablePath). Best, Godfrey Jark Wu 于2022年5月18日周三 23:09写道: > > Hi Godfrey, > > Regarding Table API for CTAS, "Table#createTableAs(tablePath)" seems a > li

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-18 Thread Jark Wu
Hi Godfrey, Regarding Table API for CTAS, "Table#createTableAs(tablePath)" seems a little strange to me. Usually, the parameter after AS should be the query, but the query is in front of AS. I slightly prefer a method on TableEnvironment besides "createTable" (i.e. a special createTable with writi

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-18 Thread Jark Wu
Hi Mang, Thanks for proposing this, CTAS is a very important API for batch users. I think the key problem of this FLIP is the ACID semantics of the CTAS operation. We care most about two parts of the semantics: 1) Atomicity: the created table should be rolled back if the write is failed. 2) Isola

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-17 Thread godfrey he
Hi Mang, Thanks for driving this FLIP. Please follow the FLIP template[1] style, and the `Syntax ` is part of the `Public API Changes` section. ‘Program research’ and 'Implementation Plan' are part of the `Proposed Changes` section, or move ‘Program research’ to the appendix. > Providing methods