Re: Possible bug in Kafka producer partitioning logic

2017-04-12 Thread Gyula Fóra
No worries, we have already pushed the fix for our jobs on a custom build :) Have a safe trip! Gyula Tzu-Li (Gordon) Tai ezt írta (időpont: 2017. ápr. 11., K, 23:11): > That workaround should work, yes. > The proper fix would also be something similar I guess, only just exposing > extra APIs to

Re: Possible bug in Kafka producer partitioning logic

2017-04-11 Thread Tzu-Li (Gordon) Tai
That workaround should work, yes. The proper fix would also be something similar I guess, only just exposing extra APIs to properly provide different partitioners for different topics. Btw, sorry for the slow responses, as I’m also currently traveling for the Flink Forward conference in San Fran

Re: Possible bug in Kafka producer partitioning logic

2017-04-10 Thread Gyula Fóra
In the worst case scenario we will have a custom build that will just cache the different partition numbers in a map. (But still call partitioner.open only once) I think this simple intermediate fix would actually be good enough for most people who get blocked by this in the short run. Gyula Gyul

Re: Possible bug in Kafka producer partitioning logic

2017-04-10 Thread Gyula Fóra
I understand the reasoning, on the other hand this creates a problem that is very hard to work around. :/ Do you have any suggestions how to get around this? Gyula Tzu-Li (Gordon) Tai ezt írta (időpont: 2017. ápr. 10., H, 15:57): > I would prefer to make this a blocker for a future bugfix actu

Re: Possible bug in Kafka producer partitioning logic

2017-04-10 Thread Tzu-Li (Gordon) Tai
I would prefer to make this a blocker for a future bugfix actually, and not 1.2.1. The reason is that to fix this properly we might need to look again into (and possibly change) how partitioners are provided. The main problem is that the `open` method can only possibly be called once with the p

Re: Possible bug in Kafka producer partitioning logic

2017-04-10 Thread Gyula Fóra
Thanks for checking this out. I would say this is definitely a blocking issue for the bugfix release, what do you think? Gyula Tzu-Li (Gordon) Tai ezt írta (időpont: 2017. ápr. 10., H, 15:39): Hi Gyula, Yes, I think the semantics of the Partitioner interface is a bit off. The `numPartitions`

Re: Possible bug in Kafka producer partitioning logic

2017-04-10 Thread Tzu-Li (Gordon) Tai
Hi Gyula, Yes, I think the semantics of the Partitioner interface is a bit off. The `numPartitions` value ideally should be the number of partitions of the `targetTopic`. Here’s a JIRA I just filed to track the issue:  https://issues.apache.org/jira/browse/FLINK-6288. Cheers, Gordon On April 1