Re: Flaky tests

2019-02-28 Thread Ufuk Celebi
@Till, Robert: +1. That would be helpful. On Thu, Feb 28, 2019 at 4:08 PM Till Rohrmann wrote: > > @Ufuk my understanding, though never written down, was to mark test > stability issues as critical and adding the test-stability label. Maybe we > should state this somewhere more explicitly. > > On

Re: Flaky tests

2019-02-28 Thread Till Rohrmann
@Ufuk my understanding, though never written down, was to mark test stability issues as critical and adding the test-stability label. Maybe we should state this somewhere more explicitly. On Thu, Feb 28, 2019 at 1:59 PM Ufuk Celebi wrote: > I fully agree with Aljoscha and Chesnay (although my re

Re: Flaky tests

2019-02-28 Thread Ufuk Celebi
I fully agree with Aljoscha and Chesnay (although my recent PR experience was still close to what Stanislav describes). @Robert: Do we have standard labels that we apply to tickets that report a flaky test? I think this would be helpful to make sure that we have a good overview of the state of fla

Re: Flaky tests

2019-02-27 Thread Aljoscha Krettek
I agree with Chesnay, and I would like to add that the most important step towards fixing flakiness is awareness and willingness. As soon as you accept flakiness and start working around it (as you mentioned) more flakiness will creep in, making it harder to get rid of it in the future. Aljosch

Re: Flaky tests

2019-02-27 Thread Chesnay Schepler
We've been in the same position a while back with the same effects. We solved it by creating JIRAs for every failing test and cracking down hard on them; I don't think there's any other way to address this. However to truly solve this one must look at the original cause to prevent new flaky test