Hi Dawid,
thanks for this proposal. This is a very nice improvement to the SQL
engine. Changelog normalize is a very state-intensive operation. Any
possibility to avoid it should be implemented.
Updating ChangelogMode is an elegant solution and avoid updating the
RowKind. When we introduced
Thank you for the feedback. I updated the name in the Flip and I'll start
the vote in a separate thread.
On Tue, 11 Mar 2025 at 09:21, Leonard Xu wrote:
> +1 for this proposal after went through Dawid and Xuyang’s discussion, and
> I think we can start a vote if there’re no objections.
>
> For t
+1 for this proposal after went through Dawid and Xuyang’s discussion, and I
think we can start a vote if there’re no objections.
For the naming, shorter is better in this case, +1 for
ChangelogMode.keyOnlyDeletes() after discussed with ChatGPT.
Best,
Leonard
I have no other questions. +1 for it.
--
Best！
Xuyang
At 2025-03-07 19:37:09, "Dawid Wysakowicz" wrote:
>>
>> From my understanding, for a sink, if its schema includes a primary key,
>> we can assume it has
>> the ability to process delete messages (with '-D') and perform deletio
>
> From my understanding, for a sink, if its schema includes a primary key,
> we can assume it has
> the ability to process delete messages (with '-D') and perform deletions
> by key (PK). If it does not
> include a PK, we would implicitly treat it as a log-structured table that
> supports full ro
Hi, Dawid.
Thanks for your response. I believe I've identified a key point, but I’m a bit
unclear about the
following you said. Could you please provide an example for clarification?
```
The only missing information is if the external sink can consume deletes by key
and if a source
produces
Hey Xuyang,
Ad. 1
Yes, you're right, but we already do that for determining if we need
UPDATE_BEFORE or not. FlinkChangelogModeInferenceProgram already deals with
that.
Ad. 2
Unfortunately it is. This is also the only reason I need a FLIP. We can
determine internally for every internal operator if
Hi Dawid,
Thanks for the FLIP, looks like a good improvement for me that will bring a
lot of benefits. +1
Best regards,
Martijn
On Tue, Feb 25, 2025 at 6:51 AM Sergey Nuyanzin wrote:
> +1 for such improvement
>
> On Mon, Feb 24, 2025 at 12:01 PM Dawid Wysakowicz
> wrote:
> >
> > Hi everyone,
+1 for such improvement
On Mon, Feb 24, 2025 at 12:01 PM Dawid Wysakowicz
wrote:
>
> Hi everyone,
>
> I would like to initiate a discussion for the FLIP-510[1] below, which aims
> on optimising certain use cases in SQL which at the moment add
> ChangelogNormalize, but don't necessarily need to do
