Re: Dependency convergence

2017-10-06 Thread Aljoscha Krettek
+2 ;-) > On 5. Oct 2017, at 11:26, Till Rohrmann wrote: > > +1 for pulling our dependencies straight and guarding it via the > maven-enforcer-plugin. > > On Wed, Oct 4, 2017 at 8:58 PM, Piotr Nowojski > wrote: > >> I meant for whole flink project. >> >>> On Oct 4, 2017, at 8:43 PM, Bowen Li

Re: Dependency convergence

2017-10-05 Thread Till Rohrmann
+1 for pulling our dependencies straight and guarding it via the maven-enforcer-plugin. On Wed, Oct 4, 2017 at 8:58 PM, Piotr Nowojski wrote: > I meant for whole flink project. > > > On Oct 4, 2017, at 8:43 PM, Bowen Li wrote: > > > > +1. This is great, Piotrek! > > > > BTW, can you clarify wha

Re: Dependency convergence

2017-10-04 Thread Piotr Nowojski
I meant for whole flink project. > On Oct 4, 2017, at 8:43 PM, Bowen Li wrote: > > +1. This is great, Piotrek! > > BTW, can you clarify what you mean by 'project wide'? Is it the whole > `flink` project or just `flink-connector-kafka`? I think it's useful to > be applied to the whole flink pro

Re: Dependency convergence

2017-10-04 Thread Bowen Li
+1. This is great, Piotrek! BTW, can you clarify what you mean by 'project wide'? Is it the whole `flink` project or just `flink-connector-kafka`? I think it's useful to be applied to the whole flink project. I've seen dependencies conflict problem like this in flink-connector-kinesis. Enabling th