Re: Breakage in Flink CLI in 1.5.0

2018-06-21 Thread Till Rohrmann
The reason why you still have to do it is because we still have to support the legacy mode where the client needs to know the JobManager RPC address. Once we remove the legacy mode, we could change the HighAvailabilityServices such that we have client facing HA services which only retrieve the rest

Re: Breakage in Flink CLI in 1.5.0

2018-06-21 Thread Sampath Bhat
hi Yes I've specified the rest.address for the flink client to connect to the rest.address and the rest.address is valid and working fine but my question is why am I supposed to give jobmanager.rpc.address for flink client to connect to flink cluster if flink client depends only on rest.address? O

Re: Breakage in Flink CLI in 1.5.0

2018-06-21 Thread Till Rohrmann
Hi, if the rest.address is different from the jobmanager.rpc.address, then you should specify that in the flink-conf.yaml and Flink will connect to rest.address. Only if rest.address is not specified, the system will fall back to use the jobmanager.rpc.address. Currently, the rest server endpoint

Re: Breakage in Flink CLI in 1.5.0

2018-06-20 Thread Sampath Bhat
Hello Till Thanks for clarification. But I've few questions based on your reply. In non-HA setups we need the jobmanager.rpc.address to derive the hostname of the rest server. why is there dependency on jobmanager.rpc.address to get the hostname rest server? This holds good only for normal deploy

Re: Breakage in Flink CLI in 1.5.0

2018-06-20 Thread Till Rohrmann
It will, but it defaults to jobmanager.rpc.address if no rest.address has been specified. On Wed, Jun 20, 2018 at 9:49 AM Chesnay Schepler wrote: > Shouldn't the non-HA case be covered by rest.address? > > On 20.06.2018 09:40, Till Rohrmann wrote: > > Hi Sampath, > > it is no longer possible to

Re: Breakage in Flink CLI in 1.5.0

2018-06-20 Thread Chesnay Schepler
Shouldn't the non-HA case be covered by rest.address? On 20.06.2018 09:40, Till Rohrmann wrote: Hi Sampath, it is no longer possible to not start the rest server endpoint by setting rest.port to -1. If you do this, then the cluster won't start. The comment in the flink-conf.yaml holds only tr

Re: Breakage in Flink CLI in 1.5.0

2018-06-20 Thread Till Rohrmann
Hi Sampath, it is no longer possible to not start the rest server endpoint by setting rest.port to -1. If you do this, then the cluster won't start. The comment in the flink-conf.yaml holds only true for the legacy mode. In non-HA setups we need the jobmanager.rpc.address to derive the hostname o

Re: Breakage in Flink CLI in 1.5.0

2018-06-20 Thread Chesnay Schepler
I was worried this might be the case. The rest.port handling was simply copied from the legacy web-server, which explicitly allowed shutting it down. It may (I'm not entirely sure) also not be necessary for all deployment modes; for example if the job is baked into the job/taskmanager images.

Re: Breakage in Flink CLI in 1.5.0

2018-06-19 Thread Sampath Bhat
Hi Chesnay Adding on to this point you made - " the rpc address is still *required *due to some technical implementations; it may be that you can set this to some arbitrary value however." For job submission to happen successfully we should give specific rpc address and not any arbitrary value. I

Re: Breakage in Flink CLI in 1.5.0

2018-06-19 Thread Sampath Bhat
Hi Chesnay If REST API (i.e. the web server) is mandatory for submitting jobs then why is there an option to set rest.port to -1? I think it should be mandatory to set some valid port for rest.port and make sure flink job manager does not come up if valid port is not set for rest.port? Or else the

Re: Breakage in Flink CLI in 1.5.0

2018-06-19 Thread Chesnay Schepler
In 1.5 we reworked the job-submission to go through the REST API instead of akka. I believe the jobmanager rpc port shouldn't be necessary anymore, the rpc address is still /required /due to some technical implementations; it may be that you can set this to some arbitrary value however. As a