Re: A whole bag of ML issues

2016-03-29 Thread Trevor Grant
I was thinking that all IterativeSolvers would benefit from a setOptimizer method. I didn't realize you had been working on GLM. If that is the case (which I think is wise) then feel free to put a setOptimizer in GLM, I'll leave it in my NeuralNetworks, and lets just try to have some consistency i

Re: A whole bag of ML issues

2016-03-29 Thread Theodore Vasiloudis
> Adding a setOptimizer to IterativeSolver. Do you mean MLR here? IterativeSolver is implemented by different solvers, I don't think adding a method like this makes sense there. In the case of MLR a better alternative that includes a bit more work is to create a Generalized Linear Model framework

Re: A whole bag of ML issues

2016-03-29 Thread Trevor Grant
OK, I'm trying to respond to you and Till in one thread so someone call me out if I missed a point but here goes: SGD Predicting Vectors : There was discussion in the past regarding this- at the time it was decided to go with only Doubles for simplicity. I feel strongly that there is cause now fo

Re: A whole bag of ML issues

2016-03-29 Thread Till Rohrmann
Hi Trevor, great to hear that you have a working prototype :-) And it is also good that you shared your insights you gained when implementing it. Flink’s ML library is far from perfect and, thus, all kinds of feedback is highly valuable. In general it is always good to contribute code back if you

Re: A whole bag of ML issues

2016-03-29 Thread Theodore Vasiloudis
Hello Trevor, These are indeed a lot of issues, let's see if we can fit the discussion for all of them in one thread. I'll add some comments inline. - Expand SGD to allow for predicting vectors instead of just Doubles. We have discussed this in the past and at that point decided that it didn't