Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-26 Thread Rui Fan
Thanks Lincoln for the quick response! And closing this vote thread, results will be announced in a separate email. Many thanks to everyone for helping check! Best, Rui On Mon, Nov 27, 2023 at 3:41 PM Lincoln Lee wrote: > Hi Rui, > > Thanks for your quick response and sorry for the false alarm

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-26 Thread Lincoln Lee
Hi Rui, Thanks for your quick response and sorry for the false alarm, all the three failures are caused by the testing environment(a high version of cluster was left in the test environment and interfered with the test, after I reset the env, all tests looked good). So retract my previous -1 vote

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-26 Thread Rui Fan
Hey Lincoln, Thanks for your testing and feedback, and I tried it locally with jdk8. 1. start standalone cluster (bin/start-cluster.sh) 2. Run all your sql, everything works fine except the last SQL. Last sql: SELECT IF(k > 3, 'true', 'false'), k from t1; It reports exception: [ERROR] Could no

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-26 Thread Lincoln Lee
-1 (not-binding) Started SQL Client, used datagen source to verify the fixed SQL issues, but FLINK-33010, FLINK-30966, FLINK-31967 still got NPE, not sure how much extra work it would take to fix them at this point, also calcite in 1.16 is 3 versions lower than 1.17, so I suggest revert and remove

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-24 Thread Martijn Visser
+1 (binding) - Validated hashes - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven - Verified licenses - Verified web PRs On Fri, Nov 24, 2023 at 7:29 AM Jing Ge wrote: > > +1(not-binding) > > - verified signatures hash > - verified hash >

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-23 Thread Jing Ge
+1(not-binding) - verified signatures hash - verified hash - checked the tag - checked the repo - verified there are no binaries in the source archive - built from sources Best regards, Jing On Thu, Nov 23, 2023 at 7:44 PM Feng Jin wrote: > +1(non-binding) > > - verified signatures and hashsum

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-23 Thread Feng Jin
+1(non-binding) - verified signatures and hashsums - Verified there are no binaries in the source archive - Built Flink from sources - Started local standalone cluster, submitted sql job using sql-client Best, Feng On Thu, Nov 23, 2023 at 11:00 PM Hang Ruan wrote: > +1 (non-binding) > > - veri

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-23 Thread Hang Ruan
+1 (non-binding) - verified signatures - verified hashsums - Verified there are no binaries in the source archive - reviewed the Release Note - reviewed the web PR Best, Hang Jiabao Sun 于2023年11月23日周四 22:15写道: > Thanks for driving this release. > > +1 (non-binding) > > - Checked the tag in git

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-23 Thread Jiabao Sun
Thanks for driving this release. +1 (non-binding) - Checked the tag in git - Verified signatures and hashsums - Verified there are no binaries in the source archive - Built Flink from sources Best, Jiabao > 2023年11月23日 21:55,Sergey Nuyanzin 写道: > > +1 (non-binding) > > - Downloaded artifacts

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-23 Thread Sergey Nuyanzin
+1 (non-binding) - Downloaded artifacts - Built Flink from sources - Verified checksums & signatures - Verified pom/NOTICE files - reviewed the web PR On Thu, Nov 23, 2023 at 1:28 PM Leonard Xu wrote: > +1 (binding) > > - verified signatures > - verified hashsums > - checked that all POM files

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-23 Thread Leonard Xu
+1 (binding) - verified signatures - verified hashsums - checked that all POM files point to the same version 1.16.3 - started SQL Client, used MySQL CDC connector to read changelog from database , the result is expected - reviewed the web PR, left minor comment Best, Leonard > 2023年11月21日 下午

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-21 Thread Matthias Pohl
+1 (binding) * Downloaded artifacts * Built Flink from sources * Verified SHA512 checksums & GPG signatures * Compared checkout with provided sources * Verified pom file versions * Went over NOTICE/pom file changes without finding anything suspicious * Deployed standalone session cluster and ran W

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-20 Thread Rui Fan
+1 (non-binding) Verified based on this wiki[1]. - Verified signatures and sha512 - The source archives do not contain any binaries - Build the source with Maven 3 and java8 (Checked the license as well) - bin/start-cluster.sh with java8, it works fine and no any unexpected LOG - Ran demo, it's f

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-16 Thread Yun Tang
+1 (non-binding) * Verified signatures * Build from source code, and it looks good * Verified that jar packages are built with maven-3.2.5 and JDK8 * Reviewed the flink-web PR * Start a local standalone cluster and submit examples Best Yun Tang ___