Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-16 Thread Chesnay Schepler
The tag has been fixed. The problem did not affect the releases in any way. On 16/12/2021 11:39, Nicolaus Weidner wrote: Thanks for doing the releases, Chesnay! It looks like the release-1.11.6 tag incorrectly points to the 1.12.7 release commit: $ git show release-1.11.6 tag release-1.11.6

Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-16 Thread Nicolaus Weidner
Thanks for doing the releases, Chesnay! It looks like the release-1.11.6 tag incorrectly points to the 1.12.7 release commit: $ git show release-1.11.6 tag release-1.11.6 Tagger: Chesnay Schepler Date: Thu Dec 16 04:12:44 2021 +0100 Release Flink 1.11.6 <...> commit 88d9950bb2c912772c46c676

Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-15 Thread Israel Ekpo
Thanks for running and release Chesnay I hope so too. On Wed, Dec 15, 2021 at 9:56 PM Chesnay Schepler wrote: > The vote duration has passed and we have approved the releases. > > Binding votes: > * Till > * Yu > * Stephan > > I will now finalize the release. Let's hope this time no new CVE pop

Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-15 Thread Chesnay Schepler
The vote duration has passed and we have approved the releases. Binding votes: * Till * Yu * Stephan I will now finalize the release. Let's hope this time no new CVE pops up... On 15/12/2021 03:55, Chesnay Schepler wrote: Hi everyone, This vote is for the emergency patch releases for 1.11, 1.

Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-15 Thread Israel Ekpo
The pull request for Flink-web looks good to me +1 (non binding) from me On Wed, Dec 15, 2021 at 8:19 PM Yun Gao wrote: > > Ah actually we may have to merge another commit into the release > > branches for that to be the case for 1.11/1.12. > > > Anyway, I still wouldn't block the release on

Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-15 Thread Yun Gao
> Ah actually we may have to merge another commit into the release > branches for that to be the case for 1.11/1.12. > Anyway, I still wouldn't block the release on that. Yes, it should only be cases for 1.11 / 1.12~ With a double check the other two versions contains the doc modification. Very

Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-15 Thread Yun Gao
Hi Chesnay, Very thanks for the explanation! Then +1 (non-binding) * Verifies the binary distributions could run successfully with the example jobs. * Verifies the new tags only contains the log4j version bump PRs. * The latest blog post and release notes looks good to me. Very thanks for driv

Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-15 Thread Chesnay Schepler
Ah actually we may have to merge another commit into the release branches for that to be the case for 1.11/1.12. Anyway, I still wouldn't block the release on that. On 16/12/2021 02:03, Chesnay Schepler wrote: That's not a problem as far as I'm concerned, because the documentation of these rel

Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-15 Thread Chesnay Schepler
That's not a problem as far as I'm concerned, because the documentation of these releases is never actually published anywhere. The documentation at nightlies.apache.org will reference 2.16.0. On 16/12/2021 02:01, Yun Gao wrote: Hi, May I have a double confirmation that it seems we still have

Re: Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-15 Thread Yun Gao
Hi, May I have a double confirmation that it seems we still have log4j version written as 2.15.0 in dev/project-configuration.md in the commit corresponding to release tags, which seems to be not consistent with the PR in the github, is it expected and would it have influence? Best, Yun -

Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-15 Thread Stephan Ewen
+1 (binding) - Verified commit history, looks good => stumbled over the changes in the "create_release_branch.sh ", which are present in each release commit. [1] => agree that these are not an issue, because this is an out-of-band release - Release notes for 1.14.2 are off, contain

Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-15 Thread Seth Wiesman
+1 (non-binding) - Checked diff of all versions and verified dep upgrade - Verified checksum and signatures - Built 1.14 from source - checked blog post Seth On Wed, Dec 15, 2021 at 10:22 AM Yu Li wrote: > +1 > > * Verified checksums and signatures > * Reviewed website PR >- Minor: left a

Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-15 Thread Yu Li
+1 * Verified checksums and signatures * Reviewed website PR - Minor: left a comment to mention CVE-2021-45046 * Checked and confirmed new tags only contain log4j version bump * Checked release notes and found no issues - I've moved FLINK-25317 to 1.14.3 Thanks for driving these releases Ch

Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-15 Thread Chesnay Schepler
FYI; the publication of the python release for 1.11/1.12 will be delayed because we hit the project size limit on pypi again, and increasing that limit may take a while. On the positive side, this gives us more time to fix the mac builds. On 15/12/2021 03:55, Chesnay Schepler wrote: Hi everyon

Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-15 Thread Chesnay Schepler
I had to monkey patch the release scripts a bit; it's unfortunate that the changes ended up in the releases, but I don't think it's a blocker. On 15/12/2021 11:01, Till Rohrmann wrote: Thanks for driving these releases Chesnay! +1 * Verified checksums and signatures * Reviewed website PR * Ch

Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-15 Thread Till Rohrmann
Thanks for driving these releases Chesnay! +1 * Verified checksums and signatures * Reviewed website PR * Checked that build tags only contain log4j version bump In the release-1.14.2-rc1 there are some changes to the create_release_branch.sh script that don't seem necessary. But I think this do

Re: [VOTE] Release 1.11.6/1.12.7/1.13.5/1.14.2, release candidate #1

2021-12-15 Thread Yun Tang
+ 1 (non-binding) * Select several files of each release to verify the signature and sha512sum. * Reviewed the flink-web PR * checked that those 4 release-branchs only contains fix to bump log4j2 version to 2.15.0 and then to 2.16.0 * Checked the JIRA release notes and found th