Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-21 Thread Yu Li
Hi All, Since the voting time has passed and we've reached a consensus on the further discussions [1], I'm concluding the vote now. Result: - 6 x +1 (binding) - 9 x +1 (non-binding) - 0 x -1 - 0 x +/-0 Since there're enough binding votes and no disapproval, the vote has passed and FLIP-8

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-21 Thread Gary Yao
+1 (binding) Best, Gary On Thu, Nov 21, 2019 at 7:55 AM Zhu Zhu wrote: > Thanks Yu for this proposal. > +1(non-binding) for the overall design. > > I have 2 questions about the result check though. Posted in the discussion > ML thread. > > Thanks, > Zhu Zhu > > Becket Qin 于2019年11月21日周四 上午11:5

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-20 Thread Zhu Zhu
Thanks Yu for this proposal. +1(non-binding) for the overall design. I have 2 questions about the result check though. Posted in the discussion ML thread. Thanks, Zhu Zhu Becket Qin 于2019年11月21日周四 上午11:57写道: > Hi Yu, > > Thanks for updating the FLIP wiki. +1 from me. I do not have further > qu

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-20 Thread Becket Qin
Hi Yu, Thanks for updating the FLIP wiki. +1 from me. I do not have further questions. Jiangjie (Becket) Qin On Wed, Nov 20, 2019 at 8:58 PM Yu Li wrote: > Thanks all for the vote and further discussions. > > I have updated the FLIP document according to aihua's reply (with some > minor refi

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-20 Thread Yu Li
Thanks all for the vote and further discussions. I have updated the FLIP document according to aihua's reply (with some minor refinement/supplements). For your convenience, below are the contents I added: ** *There're also other dimensions other than Flink char

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-19 Thread aihua li
hi,Becket, Thanks for the comments! > 1. How do the testing records look like? The size and key distributions. The records looks like a long string,which default size is 1k. The key is randomly generated according to the specified range plus a fixed string to assure that the data is ev

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-19 Thread lining jing
+1 (non-binding) Dian Fu 于2019年11月19日周二 下午6:45写道: > +1 (non-binding) > > Regards, > Dian > > > 在 2019年11月19日,下午6:31,Piotr Nowojski 写道: > > > > +1 (non-binding) > > > > Piotrek > > > >> On 19 Nov 2019, at 04:20, Yang Wang wrote: > >> > >> +1 (non-binding) > >> > >> It is great to have a new end

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-19 Thread Dian Fu
+1 (non-binding) Regards, Dian > 在 2019年11月19日,下午6:31,Piotr Nowojski 写道: > > +1 (non-binding) > > Piotrek > >> On 19 Nov 2019, at 04:20, Yang Wang wrote: >> >> +1 (non-binding) >> >> It is great to have a new end-to-end test framework, even it is only for >> performance tests now. >> >> B

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-19 Thread Piotr Nowojski
+1 (non-binding) Piotrek > On 19 Nov 2019, at 04:20, Yang Wang wrote: > > +1 (non-binding) > > It is great to have a new end-to-end test framework, even it is only for > performance tests now. > > Best, > Yang > > Jingsong Li 于2019年11月19日周二 上午9:54写道: > >> +1 (non-binding) >> >> Best, >> J

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-18 Thread Yang Wang
+1 (non-binding) It is great to have a new end-to-end test framework, even it is only for performance tests now. Best, Yang Jingsong Li 于2019年11月19日周二 上午9:54写道: > +1 (non-binding) > > Best, > Jingsong Lee > > On Mon, Nov 18, 2019 at 7:59 PM Becket Qin wrote: > > > +1 (binding) on having the t

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-18 Thread Jingsong Li
+1 (non-binding) Best, Jingsong Lee On Mon, Nov 18, 2019 at 7:59 PM Becket Qin wrote: > +1 (binding) on having the test suite. > > BTW, it would be good to have a few more details about the performance > tests. For example: > 1. How do the testing records look like? The size and key distributio

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-18 Thread Becket Qin
+1 (binding) on having the test suite. BTW, it would be good to have a few more details about the performance tests. For example: 1. How do the testing records look like? The size and key distributions. 2. The resources for each task. 3. The intended configuration for the jobs. 4. What exact sourc

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-18 Thread Zhijiang
+1 (binding)! It is a good thing to enhance our testing work. Best, Zhijiang -- From:Hequn Cheng Send Time:2019 Nov. 18 (Mon.) 18:22 To:dev Subject:Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework +1 (binding)

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-18 Thread Hequn Cheng
+1 (binding)! I think this would be very helpful to detect regression problems. Best, Hequn On Mon, Nov 18, 2019 at 4:28 PM vino yang wrote: > +1 (non-binding) > > Best, > Vino > > jincheng sun 于2019年11月18日周一 下午2:31写道: > > > +1 (binding) > > > > OpenInx 于2019年11月18日周一 下午12:09写道: > > > > > +1

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-18 Thread vino yang
+1 (non-binding) Best, Vino jincheng sun 于2019年11月18日周一 下午2:31写道: > +1 (binding) > > OpenInx 于2019年11月18日周一 下午12:09写道: > > > +1 (non-binding) > > > > On Mon, Nov 18, 2019 at 11:54 AM aihua li wrote: > > > > > +1 (non-binding) > > > > > > Thanks Yu Li for driving on this. > > > > > > > 在 20

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-17 Thread jincheng sun
+1 (binding) OpenInx 于2019年11月18日周一 下午12:09写道: > +1 (non-binding) > > On Mon, Nov 18, 2019 at 11:54 AM aihua li wrote: > > > +1 (non-binding) > > > > Thanks Yu Li for driving on this. > > > > > 在 2019年11月15日,下午8:10,Yu Li 写道: > > > > > > Hi All, > > > > > > I would like to start the vote for

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-17 Thread OpenInx
+1 (non-binding) On Mon, Nov 18, 2019 at 11:54 AM aihua li wrote: > +1 (non-binding) > > Thanks Yu Li for driving on this. > > > 在 2019年11月15日,下午8:10,Yu Li 写道: > > > > Hi All, > > > > I would like to start the vote for FLIP-83 [1] which is discussed and > > reached consensus in the discussion

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-17 Thread aihua li
+1 (non-binding) Thanks Yu Li for driving on this. > 在 2019年11月15日,下午8:10,Yu Li 写道: > > Hi All, > > I would like to start the vote for FLIP-83 [1] which is discussed and > reached consensus in the discussion thread [2]. > > The vote will be open for at least 72 hours (excluding weekend). I'

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-16 Thread Congxian Qiu
+1 (non-binding) Best, Congxian Yu Li 于2019年11月15日周五 下午8:11写道: > Hi All, > > I would like to start the vote for FLIP-83 [1] which is discussed and > reached consensus in the discussion thread [2]. > > The vote will be open for at least 72 hours (excluding weekend). I'll try > to close it by 20