Re: [VOTE] FLIP-74: Flink JobClient API

2019-10-15 Thread vino yang
+1 (non-binding) Best, Vino Aljoscha Krettek 于2019年10月15日周二 下午2:59写道: > +1 (binding) > > Best, > Aljoscha > > > On 15. Oct 2019, at 04:01, Zili Chen wrote: > > > > Hi all, > > > > +1 from my side. > > > > Given the current state of this voting thread, FLIP-74 is accepted > > with 3 binding vot

Re: [VOTE] FLIP-74: Flink JobClient API

2019-10-14 Thread Aljoscha Krettek
+1 (binding) Best, Aljoscha > On 15. Oct 2019, at 04:01, Zili Chen wrote: > > Hi all, > > +1 from my side. > > Given the current state of this voting thread, FLIP-74 is accepted > with 3 binding vote and 2 non-binding vote. Thanks for your > participation! > > I will update the wiki to refle

Re: [VOTE] FLIP-74: Flink JobClient API

2019-10-14 Thread Zili Chen
Hi all, +1 from my side. Given the current state of this voting thread, FLIP-74 is accepted with 3 binding vote and 2 non-binding vote. Thanks for your participation! I will update the wiki to reflect that the result of the vote. Best, tison. Zili Chen 于2019年10月11日周五 下午8:48写道: > Well. Then

Re: [VOTE] FLIP-74: Flink JobClient API

2019-10-11 Thread Zili Chen
Well. Then I'd remove the requirement to change cancelWithSavepoint but remain why we exclude it from JobClient. We might still change signature to completable future for a consistent async view of ClusterClient but it is quite an implement detail and we don't stick to it on FLIP level. Best, tis

Re: [VOTE] FLIP-74: Flink JobClient API

2019-10-11 Thread Kostas Kloudas
Hi Tison, Thanks for integrating the comments! +1 for accepting the FLIP from my side. What I meant is that in the Proposed Changes section, the FLIP still has that the cancelWithSavepoin(jobId, savepointDir) of the clusterClient should change to return a CompletableFuture. I believe that this ch

Re: [VOTE] FLIP-74: Flink JobClient API

2019-10-11 Thread Zili Chen
Hi Kostas, Thanks for your reply. (1) cancelWithSavepoint() has already been excluded from the FLIP. But to emphasize that we make the decision to exclude it I add it to reject alternatives. (2) Updated FLIP to reflect the consensus :-) Best, tison. Kostas Kloudas 于2019年10月11日周五 下午5:12写道: >

Re: [VOTE] FLIP-74: Flink JobClient API

2019-10-11 Thread Kostas Kloudas
Hi all, I only have two minor comments before voting and they have to do with the following: 1) In the discussion, we agreed to remove the cancelWithSavepoint() from the JobClient as this is deprecated in the rest API. This is not in the FLIP. 2) The section "ClusterDescriptor or Executor(FLIP-73

Re: [VOTE] FLIP-74: Flink JobClient API

2019-10-11 Thread Biao Liu
+1 (non-binding), glad to have this improvement! Thanks, Biao /'bɪ.aʊ/ On Fri, 11 Oct 2019 at 14:44, Jeff Zhang wrote: > +1, overall design make sense to me > > SHI Xiaogang 于2019年10月11日周五 上午11:15写道: > > > +1. The interface looks fine to me. > > > > Regards, > > Xiaogang > > > > Zili Chen 于

Re: [VOTE] FLIP-74: Flink JobClient API

2019-10-10 Thread Jeff Zhang
+1, overall design make sense to me SHI Xiaogang 于2019年10月11日周五 上午11:15写道: > +1. The interface looks fine to me. > > Regards, > Xiaogang > > Zili Chen 于2019年10月9日周三 下午2:36写道: > > > Given the ongoing FlinkForward Berlin event, I'm going to extend > > this vote thread with a bit of period, said u

Re: [VOTE] FLIP-74: Flink JobClient API

2019-10-10 Thread SHI Xiaogang
+1. The interface looks fine to me. Regards, Xiaogang Zili Chen 于2019年10月9日周三 下午2:36写道: > Given the ongoing FlinkForward Berlin event, I'm going to extend > this vote thread with a bit of period, said until Oct. 11th(Friday). > > Best, > tison. > > > Zili Chen 于2019年10月7日周一 下午4:15写道: > > > Hi

Re: [VOTE] FLIP-74: Flink JobClient API

2019-10-08 Thread Zili Chen
Given the ongoing FlinkForward Berlin event, I'm going to extend this vote thread with a bit of period, said until Oct. 11th(Friday). Best, tison. Zili Chen 于2019年10月7日周一 下午4:15写道: > Hi all, > > I would like to start the vote for FLIP-74[1], which is discussed and > reached a consensus in the