Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-04-04 Thread Yash Anand
Hi everyone, Thank you all for your votes. I am now closing the vote and will announce the results in a separate email. Thanks, Yash Anand On Wed, Mar 19, 2025 at 11:31 AM Yash Anand wrote: > Thanks all. > We have reached 3 binding votes. Sorry for the last minute changes to the > FLIP. If the

Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-03-19 Thread Yash Anand
Thanks all. We have reached 3 binding votes. Sorry for the last minute changes to the FLIP. If there are no objections, I will close the vote by tomorrow. Thanks, Yash Anand On Wed, Mar 19, 2025 at 10:55 AM Timo Walther wrote: > +1 (binding) > > Thank you for the update Yash. The FLIP is in a g

Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-03-19 Thread Timo Walther
+1 (binding) Thank you for the update Yash. The FLIP is in a good shape now. Regards, Timo On 17.03.25 17:50, Yash Anand wrote: Hi Timo, Thank you for your feedback. I have updated the FLIP to address your questions and concerns. Please let me know if you have any other feedback. Thanks, Yas

Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-03-17 Thread Yash Anand
Hi Timo, Thank you for your feedback. I have updated the FLIP to address your questions and concerns. Please let me know if you have any other feedback. Thanks, Yash Anand On Tue, Mar 11, 2025 at 5:55 AM Timo Walther wrote: > Hi Yash, > > thanks for updating the FLIP. > > Here is more feedback

Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-03-15 Thread Timo Walther
Hi Yash, could you provide the full API of the ModelDescriptor in the FLIP? Thanks, Timo On 10.03.25 16:55, Mingge Deng wrote: Thanks Yash! +1 (binding) Best, Mingge On Mon, Mar 10, 2025 at 8:51 AM Dawid Wysakowicz wrote: +1 (binding) Best, Dawid On Wed, 19 Feb 2025 at 18:37, Hao Li

Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-03-11 Thread Dawid Wysakowicz
+1 (binding) Best, Dawid On Wed, 19 Feb 2025 at 18:37, Hao Li wrote: > +1 (non-binding) > > Thanks Yash, > Hao > > On Tue, Feb 18, 2025 at 10:46 AM Yash Anand > wrote: > > > Hi Everyone, > > > > I'd like to start a vote on FLIP-507: Add Model DDL methods in TABLE API > > [1] which has been disc

Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-03-11 Thread Mingge Deng
Thanks Yash! +1 (binding) Best, Mingge On Mon, Mar 10, 2025 at 8:51 AM Dawid Wysakowicz wrote: > +1 (binding) > Best, > Dawid > > On Wed, 19 Feb 2025 at 18:37, Hao Li wrote: > > > +1 (non-binding) > > > > Thanks Yash, > > Hao > > > > On Tue, Feb 18, 2025 at 10:46 AM Yash Anand > > > wrote:

Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-03-11 Thread Timo Walther
Hi Yash, thanks for updating the FLIP. Here is more feedback from my side: Add `option(ConfigOption configOption, T value)` similar to `TableDescriptor`. Use `comment()` instead of `setComment` to be in sync with `TableDescriptor`. In `TableDescriptor`, the schema is not part of the `newB

Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-03-11 Thread Leonard Xu
Thanks @Anand for the quick response and update, the updated FLIP looks clear enough to me. +1(binding) Best, Leonard > 2025年3月11日 12:46,Yash Anand 写道: > > Hi Leonard, > > Thank you for your input. I will update the FLIP accordingly to make it > more clear and standardized enough. > > Than

Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-03-11 Thread Yash Anand
Hi Timo, Thanks for pointing that out. I have added the full API of the ModelDescriptor in the FLIP. Thanks, Yash Anand On Mon, Mar 10, 2025 at 11:27 AM Timo Walther wrote: > Hi Yash, > > could you provide the full API of the ModelDescriptor in the FLIP? > > Thanks, > Timo > > > On 10.03.25 1

Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-03-10 Thread Yash Anand
Hi Leonard, Thank you for your input. I will update the FLIP accordingly to make it more clear and standardized enough. Thanks, Yash Anand On Mon, Mar 10, 2025 at 11:08 PM Leonard Xu wrote: > Sorry for jumping the thread late, but I think current status of this FLIP > is not ready, at least

Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-03-10 Thread Leonard Xu
Sorry for jumping the thread late, but I think current status of this FLIP is not ready, at least for me (1) Could you finish your proposed API according Flink API bylaws? For example the code piece should be: Builder { SELF option(String key, String value SELF setComment(@Null

Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-02-19 Thread Hao Li
+1 (non-binding) Thanks Yash, Hao On Tue, Feb 18, 2025 at 10:46 AM Yash Anand wrote: > Hi Everyone, > > I'd like to start a vote on FLIP-507: Add Model DDL methods in TABLE API > [1] which has been discussed in this thread [2]. > > The vote will be open for at least 72 hours unless there is an