Re: Re: [VOTE] FLIP-173: Support DAG of algorithms

2022-03-29 Thread Dong Lin
Hi everyone, We (Jiangjie Qin, Yun Gao, Zhipeng Zhang, Weibo Zhao, Yunfeng Zhou and myself) would like to make the following minor API change to this FLIP. We will update Stage's Java doc to say the following, which changed the load(..) first parameter type from StreamExecutionEnvironment to Stre

Re: Re: [VOTE] FLIP-173: Support DAG of algorithms

2021-11-15 Thread Dong Lin
Hi everyone, We would like to make the following API changes to this FLIP: 1) Updates Stage's Java doc to say the following Every Stage subclass should implement a static method with signature "static T load(StreamExecutionEnvironment env, String path)", where T refers to the concrete subclass. T

Re: Re: [VOTE] FLIP-173: Support DAG of algorithms

2021-09-20 Thread Dong Lin
Thanks everyone for your votes! The proposal has passed with the following votes: +1 (Binding): 3 (Stephan, Becket, Yun) +1 (Non-binding): 0 -1: 0 Thanks, Dong On Sun, Sep 19, 2021 at 8:21 PM Yun Gao wrote: > Very thanks Dong and Zhipeng for proposing the FLIP > on Flink ML! > > The FLIP look

Re: Re: [VOTE] FLIP-173: Support DAG of algorithms

2021-09-19 Thread Yun Gao
Very thanks Dong and Zhipeng for proposing the FLIP on Flink ML! The FLIP looks good to me and +1 from my side, Best, Yun --Original Mail -- Sender:Becket Qin Send Date:Sun Sep 19 12:35:39 2021 Recipients:+dev Subject:Re: [VOTE] FLIP-173: Support DAG of algor

Re: [VOTE] FLIP-173: Support DAG of algorithms

2021-09-18 Thread Becket Qin
+1 on the FLIP, really excited to see the relaunch of the Flink ML development! Thanks Dong and Zhipeng for driving this. Cheers, Jiangjie (Becket) Qin On Sat, Sep 18, 2021 at 12:17 AM Stephan Ewen wrote: > I think this will be a useful addition. > > Regarding the API and specific design deci

Re: [VOTE] FLIP-173: Support DAG of algorithms

2021-09-17 Thread Stephan Ewen
I think this will be a useful addition. Regarding the API and specific design decisions: I think this looks ok. I didn't dig very deep and would be fine to just go with the author's proposal. The main motivation for having a separate flink-ml repository was to develop more easily, make changes and