Re: [VOTE] Apache Flink Stateful Functions Release 2.0.0, release candidate #3

2020-03-29 Thread Tzu-Li (Gordon) Tai
Thanks. The licensing issues that Hequn found are fixed in RC4: http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/VOTE-Apache-Flink-Stateful-Functions-Release-2-0-0-release-candidate-4-td39453.html This vote thread is hereby cancelled. Since the new RC4 only fixes licensing issues an

Re: [VOTE] Apache Flink Stateful Functions Release 2.0.0, release candidate #3

2020-03-29 Thread Hequn Cheng
Hi, @Gordon I have created the corresponding JIRAs and PRs for the license problems: - https://issues.apache.org/jira/browse/FLINK-16853 - https://issues.apache.org/jira/browse/FLINK-16854 @Igal @Gordon, Thanks a lot for the confirmation of the package name, that addresses my concerns now. Best,

Re: [VOTE] Apache Flink Stateful Functions Release 2.0.0, release candidate #3

2020-03-29 Thread Konstantin Knauf
Hi Gordon, +1 (non-binding) * built from sources...check * build python SDK from sources...check * went through walkthrough based on local builds...check Cheers, Konstantin On Sun, Mar 29, 2020 at 6:30 PM Igal Shilman wrote: > Hi @Hequn Cheng , and @Tzu-Li (Gordon) Tai > > Indeed the names

Re: [VOTE] Apache Flink Stateful Functions Release 2.0.0, release candidate #3

2020-03-29 Thread Igal Shilman
Hi @Hequn Cheng , and @Tzu-Li (Gordon) Tai Indeed the names are generated automatically and are following a convention. Cheers, Igal. On Sun, Mar 29, 2020 at 6:28 PM Tzu-Li (Gordon) Tai wrote: > @Hequn Cheng > On second thought I think it would not hurt to create a RC4 to fix the > version st

Re: [VOTE] Apache Flink Stateful Functions Release 2.0.0, release candidate #3

2020-03-29 Thread Tzu-Li (Gordon) Tai
@Hequn Cheng On second thought I think it would not hurt to create a RC4 to fix the version strings. Will fix those and create that now. On Mon, Mar 30, 2020 at 12:06 AM Tzu-Li (Gordon) Tai wrote: > > > On Mon, Mar 30, 2020 at 12:00 AM Tzu-Li (Gordon) Tai > wrote: > >> @Hequn Cheng >> Good ca

Re: [VOTE] Apache Flink Stateful Functions Release 2.0.0, release candidate #3

2020-03-29 Thread Tzu-Li (Gordon) Tai
On Mon, Mar 30, 2020 at 12:00 AM Tzu-Li (Gordon) Tai wrote: > @Hequn Cheng > Good catches again! > > Regarding the incorrect versions: > I think technically those would not be hard blockers, since what matters > is their inclusion and licenses being acknowledged. > It would still be good to fix

Re: [VOTE] Apache Flink Stateful Functions Release 2.0.0, release candidate #3

2020-03-29 Thread Tzu-Li (Gordon) Tai
@Hequn Cheng Good catches again! Regarding the incorrect versions: I think technically those would not be hard blockers, since what matters is their inclusion and licenses being acknowledged. It would still be good to fix those though - could you open a ticket for those? Regarding the names of t

Re: [VOTE] Apache Flink Stateful Functions Release 2.0.0, release candidate #3

2020-03-29 Thread Hequn Cheng
Hi Gordon, Thanks a lot for the new RC. I found some new blockers about licenses: - Module statefun-flink-distribution com.google.protobuf:protobuf-java:3.8.0 (The version should be 3.7.1) - Module statefun-ridesharing-example-simulator com.google.code.findbugs:jsr305:3.0.2:compile (Remove compi