Re: [SURVEY] Dropping non Credit-based Flow Control

Hi, Thank you all for the feedback. I’ve created a ticket [1] to remove the non Credit-based Flow Control code paths. Piotrek [1] https://issues.apache.org/jira/browse/FLINK-14516 > On 23 Oct 2019, at 10:59, Nico Kruber wrote: > > +1 > >

Re: [SURVEY] Dropping non Credit-based Flow Control

+1 I have not heard of a real-world use-case that suffered more than it gained and also think it is time to remove the old paths. There are, however, still improvements to be made in credit-based flow control (like [1]) but that should not stop us from removing the old paths if no-one is really u

Re: [SURVEY] Dropping non Credit-based Flow Control

+1 Credit-based flow control has long been used in our production environment as well. It works fine and there seems no reason to use non credit-based implementation. Regards, Xiaogang Zhu Zhu 于2019年10月19日周六 下午3:01写道： > +1 to drop the non credit-based flow control. > We have turned to credit-b

Re: [SURVEY] Dropping non Credit-based Flow Control

+1 to drop the non credit-based flow control. We have turned to credit-based flow control for long in production. It has been good for all our cases. The non credit-based flow control code has been a burden when we are trying to change the network stack code for new features. Thanks, Zhu Zhu Bia

Re: [SURVEY] Dropping non Credit-based Flow Control

Thanks for start this survey, Piotr. We have benefitted from credit-based flow control a lot. I can't figure out a reason to use non credit-based model. I think we have kept the older code paths long enough (1.5 -> 1.9). That's a big burden to maintain. Especially there are a lot duplicated codes

Re: [SURVEY] Dropping non Credit-based Flow Control

Thanks for bringing this survey Piotr. Actually I was also trying to dropping the non credit-based code path from release-1.9, and now I think it is the proper time to do it motivated by [3]. The credit-based mode is as default from Flink 1.5 and it has been verified to be stable and reliable in