Re: [DISCUSS] flink-connector-rabbitmq api changes

2020-05-04 Thread seneg...@gmail.com
> > >>>> Hey all + thanks Konstantin, > > > >>>> > > > >>>> Like mentioned, we also run into issues with the RMQ Source > > > >>> inflexibility. > > > >>>> I think Aljoscha's idea of supportin

Re: [DISCUSS] flink-connector-rabbitmq api changes

2020-05-04 Thread Austin Cawley-Edwards
27;d definitely benefit from the changes proposed here but have > > another > > >>>> issue with the Correlation ID. When a message gets in the queue > > >> without a > > >>>> correlation ID, the source errors and the job cannot recover, > >

Re: [DISCUSS] flink-connector-rabbitmq api changes

2020-05-04 Thread seneg...@gmail.com
ion. It would be nice to be able to > >> dead-letter > >>>> these inputs from the source, but I don't think that's possible with > >> the > >>>> current source interface (don't know too much about the source > >>> specifics).

Re: [DISCUSS] flink-connector-rabbitmq api changes

2020-05-04 Thread Aljoscha Krettek
ions that have gone unmaintained, I'm also happy to chip it at maintaining them! Best, Austin From: Konstantin Knauf Sent: Thursday, April 30, 2020 6:14 AM To: dev Cc: Austin Cawley-Edwards Subject: Re: [DISCUSS] flink-connector-rabbitmq api changes Hi everyone, ju

Re: [DISCUSS] flink-connector-rabbitmq api changes

2020-05-03 Thread seneg...@gmail.com
know too much about the source > > specifics). > > > We might be able to work around this with a custom Correlation ID > > > extractor, as proposed by Karim. > > > > > > Also, if there are other tickets in the RMQ integrations that have gone > > > un

Re: [DISCUSS] flink-connector-rabbitmq api changes

2020-05-01 Thread Austin Cawley-Edwards
rations that have gone > > unmaintained, I'm also happy to chip it at maintaining them! > > > > Best, > > Austin > > > > From: Konstantin Knauf > > Sent: Thursday, April 30, 2020 6:14 AM > > To: dev

Re: [DISCUSS] flink-connector-rabbitmq api changes

2020-05-01 Thread seneg...@gmail.com
ns that have gone > unmaintained, I'm also happy to chip it at maintaining them! > > Best, > Austin > > From: Konstantin Knauf > Sent: Thursday, April 30, 2020 6:14 AM > To: dev > Cc: Austin Cawley-Edwards > Subject: Re: [DISCUSS] f

Re: [DISCUSS] flink-connector-rabbitmq api changes

2020-04-30 Thread Austin Cawley-Edwards
x27;m also happy to chip it at maintaining them! Best, Austin From: Konstantin Knauf Sent: Thursday, April 30, 2020 6:14 AM To: dev Cc: Austin Cawley-Edwards Subject: Re: [DISCUSS] flink-connector-rabbitmq api changes Hi everyone, just looping in Austin as he men

Re: [DISCUSS] flink-connector-rabbitmq api changes

2020-04-30 Thread Konstantin Knauf
Hi everyone, just looping in Austin as he mentioned that they also ran into issues due to the inflexibility of the RabiitMQSourcce to me yesterday. Cheers, Konstantin On Thu, Apr 30, 2020 at 11:23 AM seneg...@gmail.com wrote: > Hello Guys, > > Thanks for all the responses, i want to stress ou

Re: [DISCUSS] flink-connector-rabbitmq api changes

2020-04-30 Thread seneg...@gmail.com
Hello Guys, Thanks for all the responses, i want to stress out that i didn't feel ignored i just thought that i forgot an important step or something. Since i am a newbie i would follow whatever route you guys would suggest :) and i agree that the RMQ connector needs a lot of love still "which i

Re: [DISCUSS] flink-connector-rabbitmq api changes

2020-04-30 Thread Aljoscha Krettek
Hi, I think it's good to contribute the changes to Flink directly since we already have the RMQ connector in the respository. I would propose something similar to the Kafka connector, which takes both the generic DeserializationSchema and a KafkaDeserializationSchema that is specific to Kafk

Re: [DISCUSS] flink-connector-rabbitmq api changes

2020-04-30 Thread Robert Metzger
Hey Karim, I'm sorry that you had such a bad experience contributing to Flink, even though you are nicely following the rules. You mentioned that you've implemented the proposed change already. Could you share a link to a branch here so that we can take a look? I can assess the API changes easier

Re: [DISCUSS] flink-connector-rabbitmq api changes

2020-04-29 Thread Dawid Wysakowicz
Hi Karim, Sorry you did not have the best first time experience. You certainly did everything right which I definitely appreciate. The problem in that particular case, as I see it, is that RabbitMQ is not very actively maintained and therefore it is not easy too find a committer willing to take o

Re: [DISCUSS] flink-connector-rabbitmq api changes

2020-04-29 Thread seneg...@gmail.com
Hello, I am new to the mailing list and to contributing in Big opensource projects in general and i don't know if i did something wrong or should be more patient :) I put a topic for discussion as per the contribution guide " https://flink.apache.org/contributing/how-to-contribute.html"; almost a