Re: [DISCUSS] deprecated function need more detail

2017-03-20 Thread Ufuk Celebi
There is a related checkstyle rule: http://checkstyle.sourceforge.net/apidocs/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedCheck.html Added a JIRA for adding it here: https://issues.apache.org/jira/browse/FLINK-6127 We actually wrote this down in our hidden Wiki at https://c

Re: [DISCUSS] deprecated function need more detail

2017-03-20 Thread Stephan Ewen
+1 I think we actually had the same discussion already a while back. Let's bring it back to everyone's awareness! On Wed, Nov 23, 2016 at 12:09 PM, Paris Carbone wrote: > +1 > > This should always be the norm, especially for user-facing code. > > While we are at it, perhaps when someone depre

Re: [DISCUSS] deprecated function need more detail

2016-11-23 Thread Paris Carbone
+1 This should always be the norm, especially for user-facing code. While we are at it, perhaps when someone deprecates functionality the new alternative should also be replaced right away. E.g. Checkpointed is deprecated but all state management tests are actually using this alternative. chee

Re: [DISCUSS] deprecated function need more detail

2016-11-23 Thread Kostas Kloudas
+1 and we should apply the same to all deprecated interfaces/abstract classes. > On Nov 23, 2016, at 11:13 AM, Aljoscha Krettek wrote: > > +1 That sounds excellent. > > On Wed, 23 Nov 2016 at 11:04 Till Rohrmann wrote: > >> +1 for your proposal. >> >> Cheers, >> Till >> >> On Wed, Nov 23, 2

Re: [DISCUSS] deprecated function need more detail

2016-11-23 Thread Aljoscha Krettek
+1 That sounds excellent. On Wed, 23 Nov 2016 at 11:04 Till Rohrmann wrote: > +1 for your proposal. > > Cheers, > Till > > On Wed, Nov 23, 2016 at 9:33 AM, Fabian Hueske wrote: > > > I agree on this one. > > Whenever we deprecate a method or a feature we should add a comment that > > explains t

Re: [DISCUSS] deprecated function need more detail

2016-11-23 Thread Till Rohrmann
+1 for your proposal. Cheers, Till On Wed, Nov 23, 2016 at 9:33 AM, Fabian Hueske wrote: > I agree on this one. > Whenever we deprecate a method or a feature we should add a comment that > explains the new API or why the feature was removed without replacement. > > Enforcing this information th

Re: [DISCUSS] deprecated function need more detail

2016-11-23 Thread Fabian Hueske
I agree on this one. Whenever we deprecate a method or a feature we should add a comment that explains the new API or why the feature was removed without replacement. Enforcing this information through checkstyle makes sense as well, IMO. Cheers, Fabian 2016-11-23 4:42 GMT+01:00 sjk : > Hi, all