I decided that the classes listed above are generic enough to be placed
into *flink-test-utils*.
Here is the PR for the discussed changes that needs a review:
https://github.com/apache/flink/pull/20188
Best,
Alex
On Wed, Jul 6, 2022 at 1:35 PM Alexander Fedulov
wrote:
> Hi Chesnay,
>
> the fo
Hi Chesnay,
the following classes also need to be migrated along with the
*FlinkContainerTestEnvironment*:
*JobSubmission*
*SQLJobSubmission*
*ParameterProperty*
*FileUtils*
We can either put them directly into* flink-connector-test-utils *or
into *flink-test-utils
*and add a dependency *fli
Thanks for starting this discussion. I think it makes sense to make a clear
definition and goal of ITCases and e2e tests. For me, compared to e2e
tests, ITCases are more lightweight and only focus on some specific part of
the e2e pipeline. E2e tests cover the whole pipeline and could be
considered
Thanks for the clarifications. I agree then that it indeed makes sense to
move the related classes into connector-test-utils for now and reconsider
when and if concrete use cases of FlinkContainerTestEnvironment outside of
the connectors' scope come up.
On Wed, May 25, 2022 at 5:23 PM Chesnay Sch
1) That's a fair point. So far everything that came out of the connector
e2e framework was unfortunately somehow coupled to connectors
conceptually. I wouldn't mind changing that, because as you said this
could also be useful for other things, but it needs a more holistic view
over the entire s
I see. A couple of considerations:
1. I would assume FlinkContainerTestEnvironment could be used for more
things than solely connectors, hence it should ideally not be placed into
flink-connector-test-utils
2. If we put it and its dependencies into flink-test-utils, what would be
the purpose of t
I'd be more inclined to move the FlinkContainerTestEnvironment to
flink-(connector-)test-utils for the time being, because the vast
majority of stuff in flink-end-to-end-tests-common isn't really in a
state where we want to share it.
On 25/05/2022 11:55, Alexander Fedulov wrote:
Hi everyone,
Hi Alex,
Thank you for driving this effort!
I think it's a good idea to publish flink-end-to-end-tests-common to maven,
to help with the development of the external components.
Best,
On Wed, May 25, 2022 at 11:56 AM Alexander Fedulov
wrote:
> Hi everyone,
>
> As part of the efforts to external
