Hi all,
Thanks for sharing your opinions!
I'd like to draw a conclusion. I had an offline discussion with @Hangxiang
Yu and @Junrui Lee today, and we agreed that option 2 could make the
package cleaner, thus it is a better way to go.
We will follow option 2, and the deprecation will be discussed
Personally, I'd be in favor of option 2. And based on the fact that
migrating from the deprecated CheckpointingMode to the new one takes barely
any effort (simply re-import the class), I'd be fine with removing the
deprecated class in 2.0.
But I'd also be fine with the other options.
Either way,
Hi Zakelly,
+1 for option 1. I prefer to minimize unnecessary additional development
and discussions due to internal code relocations and to avoid imposing
migration costs on users.
Best regards,
Junrui
Zakelly Lan 于2024年2月28日周三 14:46写道：
> Hi Lincoln,
>
> Given that we have finished the testin
Hi Lincoln,
Given that we have finished the testing for 1.19, I agree it is better not
merge this into 1.19. Thanks for RMs' attention!
Hi Chesney and Junrui,
Thanks for your advice. My original intention is to move the class as well
as change the package to make it clean. But it involves much m
Hi Zakelly,
I agree with Chesnay's response. I would suggest that during the process of
moving CheckpointingMode from the flink-streaming-java module to the
flink-core module, we should keep the package name unchanged. This approach
would be completely transparent to users. In fact, this practice
Moving classes (== keep the same package) to a module higher up in the
dependency tree should not be a breaking change and can imo be done
anytime without any risk to users.
On 27/02/2024 17:01, Lincoln Lee wrote:
Hi Zakelly,
Thanks for letting us 1.19 RMs know about this!
This change has be
Hi Zakelly,
Thanks for letting us 1.19 RMs know about this!
This change has been discussed during today's release sync meeting, we
suggest not merge it into 1.19.
We can continue discussing the removal in 2.x separately.
Best,
Lincoln Lee
Hangxiang Yu 于2024年2月27日周二 11:28写道：
> Hi, Zakelly.
>
Hi, Zakelly.
Thanks for driving this.
Moving this class to flink-core makes sense to me which could make the code
path and configs clearer.
It's marked as @Public from 1.0 and 1.20 should be the next long-term
version, so 1.19 should have been a suitable version to do it.
And also look forward to t
